From fbef77b5d03d06b04e88900ca2cae1b38fb25711 Mon Sep 17 00:00:00 2001 From: Brenda Wallace Date: Thu, 13 Jun 2019 23:00:54 +1200 Subject: [PATCH] Fix members list spec, and DRY --- spec/features/members_list_spec.rb | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/spec/features/members_list_spec.rb b/spec/features/members_list_spec.rb index 9523b6238..f00b1daaf 100644 --- a/spec/features/members_list_spec.rb +++ b/spec/features/members_list_spec.rb @@ -6,25 +6,25 @@ describe "members list" do let!(:member2) { create :member, login_name: "Zephyrosaurus", confirmed_at: Time.zone.parse('2014-01-11') } let!(:member3) { create :member, login_name: "Testingname", confirmed_at: Time.zone.parse('2014-05-09') } - it "default alphabetical sort" do + subject { page.all("#maincontainer h4.login-name") } + + before do visit members_path expect(page).to have_css "#sort" expect(page).to have_selector "form" + end + + it "default alphabetical sort" do click_button('Show') - all_links = page.all("#maincontainer p.login-name") - expect(all_links.first).to have_text member1.login_name - expect(all_links.last).to have_text member2.login_name + expect(subject.first).to have_text member1.login_name + expect(subject.last).to have_text member2.login_name end it "recently joined sort" do - visit members_path - expect(page).to have_css "#sort" - expect(page).to have_selector "form" select("recently", from: 'sort') click_button('Show') - all_links = page.all("#maincontainer p.login-name") - expect(all_links.first).to have_text member3.login_name - expect(all_links.last).to have_text member1.login_name + expect(subject.first).to have_text member3.login_name + expect(subject.last).to have_text member1.login_name end end end