We deprecated controller and view specs on the grounds that they were
brittle, and were a poorer measure of user experience than feature
specs. However, feature specs have their own problems: they're much
slower to run, and flakier (see #901). We also ran into a few cases
where feature specs erroneously passed because they were checking for
the presence of a string that occurred in the error page!
Hence, we're cautiously un-deprecating controller and view specs.
Fixes#1132
We have added a sequence for login_name which is similar to the one for
emails in which the member name is incremented each time a new member is
saved.
In addition, we have updated all specs which asked for an explicit
login_name of member1 to use a regex looking only for member and some
digit.
There's still probably stuff broken, but this seemed like a good spot to
commit. Sorry for the enormous chunk of code. I was attempting to
update the views, but found that I needed to update a few things
elsewhere as well to make them work.
- .watchr script mostly nicked from
http://www.rubyinside.com/how-to-rails-3-and-rspec-2-4336.html
- I moved the views specs to mirror the location of the files they test
in /app, in order to keep the .watchr script simple
- as an added bonus, `rake spec:views` now works :-)
