67 Commits
Author SHA1 Message Date
163289e853 Fix RSpec/IndexedLet RuboCop issues in spec files (#4556)
* Fix RSpec/IndexedLet RuboCop issues in spec files

Replace indexed let variable names with descriptive names across 11 spec files.
This improves readability and complies with the RSpec/IndexedLet rule.

Co-authored-by: CloCkWeRX <365751+CloCkWeRX@users.noreply.github.com>

* Rubocop

---------

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
2026-04-26 03:10:03 +09:30
Daniel O'Connor ba75afb3f5 Rubocop: RSpecRails/InferredSpecType 2026-04-23 13:39:46 +00:00
Daniel O'Connor f1acb35520 Merge pull request #4537 from Growstuff/FactoryBot/SyntaxMethods
Rubocop: FactoryBot/SyntaxMethods
2026-04-23 22:29:24 +09:30
google-labs-jules[bot]andDaniel O'Connor 8564ec7a7c Add comments to photos (#4130)
* Add comments to photos

Extend the photo show page to support comments by logged in users.

- Make the Comment model polymorphic.
- Update the Photo and Post models to have comments.
- Update the comments controller to handle the polymorphic association.
- Update the photo show page to display comments and a comment form.
- Create a reusable comments partial.

* Add migration

* Fix tests

* Fix tests

* Slightly fix tests

* Fix variables

* Add field

* Refactor slightly

* Refactor slightly

* Refactor slightly

* Refactor

* Photos respond to this as well

* Refactor to polymorphic_url

* Rename

* Wrong relationship

* Refactor and fix tests

* Fix relationships

* Fix rendering

* Fix tests

* Fix model tests

* Fix test

* Fix test

* Fix test

* Fix test

* Fix controller spec

* Fix view tests

---------

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
Co-authored-by: Daniel O'Connor <daniel.oconnor@gmail.com>
2025-08-24 21:10:16 +09:30
ee45b518ce Rubocop fixes (Stacked PR) (#3454)
* Fix todo

* Rubcop

* Rubocop

* Rubocop

* Rename harvests_routing_spec.rb to harvests_controller_routing_spec.rb

Making codeclimate happier

* Rename for CodeFactor: updates_routing_spec.rb to posts_controller_updates_routing_spec.rb

For codefactor

* Rename for CodeFactor: follows_routing_spec.rb to follows_controller_routing_spec.rb

* Rename for CodeFactor: forums_routing_spec.rb to forums_controller_routing_spec.rb

* Rename spec/routing/roles_routing_spec.rb to spec/routing/admin/roles_controller_routing_spec.rb

* Rename authentications_routing_spec.rb to authentications_controller_routing_spec.rb

* Rename for CodeFactor: plantings_routing_spec.rb to plantings_controller_routing_spec.rb

* Rename for CodeFactor: scientific_names_routing_spec.rb to scientific_names_controller_routing_spec.rb

* Rename for CodeFactor: seeds_routing_spec.rb to seeds_controller_routing_spec.rb

* Rename for CodeFactor: comments_routing_spec.rb to comments_controller_routing_spec.rb

* Rename for CodeFactor: garden_types_routing_spec.rb to garden_types_controller_routing_spec.rb

* Rename for CodeFactor: admin_routing_spec.rb to admin_controller_routing_spec.rb

* Rename for CodeFactor: gardens_routing_spec.rb to gardens_controller_routing_spec.rb

* Rename for CodeFactor: photos_routing_spec.rb to photos_controller_routing_spec.rb

* Rename for CodeFactor: plant_parts_routing_spec.rb to plant_parts_controller_routing_spec.rb

* Rename for CodeFactor: crops_routing_spec.rb to crops_controller_routing_spec.rb

* [CodeFactor] Apply fixes

* Rename

* Code factor bot

---------

Co-authored-by: Cesy <cesy.avon@gmail.com>
Co-authored-by: codefactor-io <support@codefactor.io>
2024-01-07 21:05:59 +10:30
Daniel O'Connor d1f754a288 Rubocop 2022-11-08 00:23:38 +10:30
Daniel O'Connor 2db3d1bacc Various corrections 2022-11-08 00:21:23 +10:30
Daniel O'Connor a8b8a58f33 Various rspec autocorrections 2022-11-08 00:09:50 +10:30
Daniel O'Connor b24b9f82e6 Rubocop - auto corrections 2022-11-06 16:34:36 +10:30
Daniel O'Connor ea5486ffe1 Swap percy over (#2986)
* Swap percy over

* Swap require over

* Change API

* Update package.json
2022-03-27 11:44:18 +10:30
codefactor-io 4ff95fbac9 [CodeFactor] Apply fixes 2020-01-21 22:26:08 +13:00
Brenda 7257b2ada1 Update with frozen literals 2020-01-10 16:50:52 +13:00
Brenda Wallace 04fd1a343a Rubocop update (#2334)
* Update rubocop config

* Rubocop update - for rubocop 0.77

* [CodeFactor] Apply fixes

* rubocop fixes

* [CodeFactor] Apply fixes to commit 2826c2e
2019-12-16 22:35:33 +13:00
Brenda Wallace 7c38f7eca6 Pull homepage data directly from elasticsearch (#2316)
* Pull homepage data directly from elasticsearch

* Removing non-elasticsearch options

* [CodeFactor] Apply fixes to commit c46b2e7
2019-12-09 10:03:48 +13:00
Brenda Wallace c6fffebb28 Update specs for new index layout with api docs 2019-11-18 10:50:13 +13:00
André Aubin 279d85456b Switching gravatar urls to secure subdomain 2019-10-24 23:51:52 +00:00
André Aubin 66045866b3 Switch to HTTPS for Gravatar urls 2019-10-24 23:51:52 +00:00
Brenda Wallace 34b399cd8e Use more signed in contexts in browse crops spec
More member role contexts on alt name spec

More member role contexts in crop feature specs

Don't wrap the shared_context
2019-08-18 16:10:03 +12:00
Brenda Wallace 756cf1fe3a Removing unused code in specs 2019-08-18 14:51:24 +12:00
Brenda Wallace a334ea03bf fix spec 2019-08-17 19:20:43 +12:00
Brenda Wallace 586bc21e93 Merge remote-tracking branch 'upstream/dev' into fix/feature-spec-sessions
Conflicts:
	spec/features/members/profile_spec.rb
	spec/features/notifications_spec.rb
	spec/features/percy/percy_spec.rb
2019-08-17 16:09:32 +12:00
Brenda Wallace c1deed70ad Keep username consistent in specs 2019-08-17 14:32:18 +12:00
Brenda Wallace 8936933251 Shared context for signing in (and then out) in feature specs 2019-08-17 14:10:56 +12:00
Brenda Wallace 6af95fa722 Help percy find the correct link 2019-08-07 16:19:11 +12:00
Brenda Wallace 6383dbc19f more percy specs 2019-07-11 10:18:54 +00:00
Brenda Wallace 67af069804 more percy specs 2019-07-11 12:08:15 +12:00
Brenda Wallace 7266f6b590 include some interesting members in percy spec
so they show on the home page
2019-07-06 12:08:34 +12:00
Brenda Wallace 3f24fbe181 rubocop linting 2019-06-24 18:38:28 +12:00
Brenda Wallace e56133a944 Delete percy_new_spec.rb 2019-06-12 12:10:02 +12:00
Brenda Wallace c708608e9b Tidy up members#show photo display 2019-06-07 13:09:29 +12:00
Brenda Wallace 4c92c97aaa Add names to admin pages in percy spec 2019-05-25 10:29:40 +12:00
Brenda Wallace 7ffefcf1b5 Add admin and crop wrangling to percy spec 2019-05-25 10:24:31 +12:00
Brenda Wallace 6af086e94d Tidy up percy specs for major #new pages 2019-05-25 10:04:16 +12:00
Brenda Wallace f711b7e3b7 Add crops new to the percy specs 2019-05-24 20:37:16 +12:00
codefactor-io 0d9d7efbe7 [CodeFactor] Apply fixes 2019-05-19 08:35:36 +00:00
Brenda Wallace 9adca482d6 member in percy spec located 2019-05-19 20:34:46 +12:00
Brenda Wallace 8a2e5f1f54 Fix percy spec 2019-05-19 18:07:05 +12:00
Brenda Wallace 2e5445da3e Create some activity on the member's page 2019-05-19 15:46:42 +12:00
Brenda Wallace 5f1d65dfc0 typo. tradeable -> tradable 2019-05-19 15:36:45 +12:00
Brenda Wallace 4de9b2f558 fix bug in percy spec 2019-05-19 15:34:37 +12:00
Brenda Wallace 7528a337cf Seeds to be in percy specs 2019-05-19 15:10:31 +12:00
codefactor-io 4af8282a44 [CodeFactor] Apply fixes 2019-05-18 19:36:26 +00:00
Brenda Wallace b19bef0ec3 Adding posts and comments to percy spec 2019-05-18 22:29:49 +12:00
Brenda Wallace 7bf2d75605 More post content in percy specs 2019-05-18 21:45:31 +12:00
Brenda Wallace f019969240 Tidy up posts 2019-05-18 21:41:41 +12:00
Brenda Wallace 72479eb44f Another gardens#show test 2019-05-17 12:26:50 +12:00
Brenda Wallace d4eaacf11e Add menus to percy spec 2019-05-17 12:18:48 +12:00
Brenda Wallace a65d2ba7b5 Addings gardens#show to percy spec 2019-05-16 21:57:12 +12:00
Brenda Wallace b5c88d8f33 set plant part in percy spec 2019-05-14 21:08:23 +12:00
codefactor-io 69531f232d [CodeFactor] Apply fixes 2019-05-12 19:56:07 +00:00