Commit Graph

709 Commits

Author SHA1 Message Date
google-labs-jules[bot]
8564ec7a7c Add comments to photos (#4130)
* Add comments to photos

Extend the photo show page to support comments by logged in users.

- Make the Comment model polymorphic.
- Update the Photo and Post models to have comments.
- Update the comments controller to handle the polymorphic association.
- Update the photo show page to display comments and a comment form.
- Create a reusable comments partial.

* Add migration

* Fix tests

* Fix tests

* Slightly fix tests

* Fix variables

* Add field

* Refactor slightly

* Refactor slightly

* Refactor slightly

* Refactor

* Photos respond to this as well

* Refactor to polymorphic_url

* Rename

* Wrong relationship

* Refactor and fix tests

* Fix relationships

* Fix rendering

* Fix tests

* Fix model tests

* Fix test

* Fix test

* Fix test

* Fix test

* Fix controller spec

* Fix view tests

---------

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
Co-authored-by: Daniel O'Connor <daniel.oconnor@gmail.com>
2025-08-24 21:10:16 +09:30
google-labs-jules[bot]
0b639d5940 Remove twitter authentication
This change removes the twitter authentication feature from the application.

It removes the `omniauth-twitter` gem and all related code from controllers, views, and tests. It also removes the twitter icon and environment variable settings.
2025-08-24 07:03:20 +00:00
Daniel O'Connor
8b4f0771c5 Ruby 3.2: Rubocop - Fix Negation matcher (#3780)
* Ruby 3.2/Bundler 2.4

* Fix creation

* Upgrade to js-routes 2. Put all js routes into a global namespace.

* Remove js-routes

* Remove

* Adjust ownership

* Appease codeclimate for the nth time

* Fix deprecation warning by explicitly calling to_fs

* Fix deprecation warning by explicitly calling to_fs

* Fix deprecation warning by explicitly calling to_fs

* Swap to will paginate successor for bootstrap

* Update app/views/members/show.html.haml

* Update app/views/plantings/index.rss.haml

* Update .env

* Update .devcontainer/.env

* Fix spec

* Update spec

* Fix spec

* Pin to 2.4.22

* 3 space indent

* Regenerate

* Update rubocop

* Rubocop

* More rubocop

* Regenerate

* Fix Capybara/NegationMatcher
2024-07-13 15:20:11 +09:30
Daniel O'Connor
000f4979db Trial Ruby32 (#3418)
* Ruby 3.2/Bundler 2.4

* Fix creation

* Upgrade to js-routes 2. Put all js routes into a global namespace.

* Remove js-routes

* Remove

* Adjust ownership

* Appease codeclimate for the nth time

* Fix deprecation warning by explicitly calling to_fs

* Fix deprecation warning by explicitly calling to_fs

* Fix deprecation warning by explicitly calling to_fs

* Swap to will paginate successor for bootstrap

* Update app/views/members/show.html.haml

* Update app/views/plantings/index.rss.haml

* Update .env

* Update .devcontainer/.env

* Fix spec

* Update spec

* Fix spec

* Pin to 2.4.22

* 3 space indent

* Regenerate

* Update rubocop
2024-07-13 14:45:33 +09:30
Daniel O'Connor
49284eb169 Fix haml preview (#3610)
* HAML

* rewrite

* Fix specs - but likely still wrong

* Return temple

* Trailing line

* Fix specs

* This was rearranged, apparently.

* Fix tests

* Retain escaping

* Fix specs

* Rubocop

* Attempt to fix rendering

* Fix output

* Move away from filter

* Move away from filter

* Fix spec

* Fix specs

* Fix structure to avoid nested paragraph tags
2024-02-04 15:08:18 +10:30
Daniel O'Connor
fb86448061 HAML 6 (#3607)
* HAML

* rewrite

* Fix specs - but likely still wrong

* Return temple

* Trailing line

* Fix specs

* This was rearranged, apparently.

* Fix tests

* Retain escaping

* Fix specs

* Rubocop

* Apparently the escaped filter doesn't work with interpolation. Swap to our implementation
2024-02-03 17:33:39 +10:30
Daniel O'Connor
b77df88df9 Issues/1475: Ensure we have pagination (#3193)
* Paginate, 100 at a time

* Limited i18n

* Paginate roles

* Pagination

* Pagination

* i18n and pagination

* Paginate alternate names

* Silence code climate

* Rewrite coverage as a feature

* Remove coverage in favour of crops/scientific_name_spec

* Add missing admin link

* Rewrite coverage as feature

* Rewrite coverage

---------

Co-authored-by: Brenda Wallace <brenda@wallace.net.nz>
2024-01-21 14:19:36 +10:30
Daniel O'Connor
ee45b518ce Rubocop fixes (Stacked PR) (#3454)
* Fix todo

* Rubcop

* Rubocop

* Rubocop

* Rename harvests_routing_spec.rb to harvests_controller_routing_spec.rb

Making codeclimate happier

* Rename for CodeFactor: updates_routing_spec.rb to posts_controller_updates_routing_spec.rb

For codefactor

* Rename for CodeFactor: follows_routing_spec.rb to follows_controller_routing_spec.rb

* Rename for CodeFactor: forums_routing_spec.rb to forums_controller_routing_spec.rb

* Rename spec/routing/roles_routing_spec.rb to spec/routing/admin/roles_controller_routing_spec.rb

* Rename authentications_routing_spec.rb to authentications_controller_routing_spec.rb

* Rename for CodeFactor: plantings_routing_spec.rb to plantings_controller_routing_spec.rb

* Rename for CodeFactor: scientific_names_routing_spec.rb to scientific_names_controller_routing_spec.rb

* Rename for CodeFactor: seeds_routing_spec.rb to seeds_controller_routing_spec.rb

* Rename for CodeFactor: comments_routing_spec.rb to comments_controller_routing_spec.rb

* Rename for CodeFactor: garden_types_routing_spec.rb to garden_types_controller_routing_spec.rb

* Rename for CodeFactor: admin_routing_spec.rb to admin_controller_routing_spec.rb

* Rename for CodeFactor: gardens_routing_spec.rb to gardens_controller_routing_spec.rb

* Rename for CodeFactor: photos_routing_spec.rb to photos_controller_routing_spec.rb

* Rename for CodeFactor: plant_parts_routing_spec.rb to plant_parts_controller_routing_spec.rb

* Rename for CodeFactor: crops_routing_spec.rb to crops_controller_routing_spec.rb

* [CodeFactor] Apply fixes

* Rename

* Code factor bot

---------

Co-authored-by: Cesy <cesy.avon@gmail.com>
Co-authored-by: codefactor-io <support@codefactor.io>
2024-01-07 21:05:59 +10:30
Daniel O'Connor
9f6fe4d7d8 Fix #3247 broken links 2023-03-13 02:00:46 +00:00
Italo Pires
5faf990167 Removed white space 2022-12-10 18:50:17 -03:00
Italo Pires
24ac3fc9be Rename it from shows to render 2022-12-10 18:42:13 -03:00
Italo Pires
74f2ffe86e Fix test warning about assert link with capybara 2022-12-10 18:38:11 -03:00
Daniel O'Connor
d22215f870 Merge branch 'bump-ruby-3.1.x' into rubocop-safe 2022-11-08 00:32:36 +10:30
Daniel O'Connor
13a78b76ee Mark WIP 2022-11-08 00:31:23 +10:30
Daniel O'Connor
d1f754a288 Rubocop 2022-11-08 00:23:38 +10:30
Daniel O'Connor
2db3d1bacc Various corrections 2022-11-08 00:21:23 +10:30
Daniel O'Connor
a8b8a58f33 Various rspec autocorrections 2022-11-08 00:09:50 +10:30
Daniel O'Connor
b726f40d9b Fix deprecation 2022-11-08 00:04:39 +10:30
Daniel O'Connor
0d550134e5 Deprecation 2022-11-08 00:03:36 +10:30
Daniel O'Connor
cd43e73fd4 to_s 2022-11-07 23:20:49 +10:30
Daniel O'Connor
b24b9f82e6 Rubocop - auto corrections 2022-11-06 16:34:36 +10:30
Brenda Wallace
43a577fa50 Update rubocop config 2021-01-05 19:46:07 +13:00
Rowan Crawford
3c8b59811b ws, is there no prettier equivalent? 2020-11-03 07:03:13 +13:00
Rowan Crawford
c889b63611 the answer is not mutating @crop 2020-11-03 07:03:13 +13:00
Brenda Wallace
d36d5ff1e3 mark test as javascript 2020-11-03 07:03:13 +13:00
Rowan Crawford
86c832d6ad ws 2020-11-03 07:03:13 +13:00
Rowan Crawford
59a693ec1f test doesn't work because don't understand how to write specs 2020-11-03 07:03:13 +13:00
Brenda Wallace
f2b385bd5e Help view spec find the correct template 2020-08-26 12:36:58 +12:00
Brenda Wallace
b9c411d385 Removed cloudmade test 2020-08-26 12:36:58 +12:00
Brenda
821ddd90cb fix specs 2020-02-10 14:21:03 +13:00
codefactor-io
34ddf8e98f [CodeFactor] Apply fixes 2020-01-21 13:12:28 +13:00
codefactor-io
7e30b6b6e0 [CodeFactor] Apply fixes 2020-01-03 11:28:51 +00:00
Brenda Wallace
a89534da53 harvest tidy up 2019-12-28 10:06:10 +13:00
Brenda Wallace
23886de24b revert plantings#index spec 2019-12-27 09:07:47 +13:00
Brenda Wallace
9e0f35b22b fixing plantings rss feed 2019-12-26 23:22:12 +13:00
codefactor-io
99d436a91f [CodeFactor] Apply fixes to commit 5962081 2019-12-24 22:45:59 +00:00
Brenda Wallace
5962081c9e fix specs fpr seeds rss feed 2019-12-25 11:42:29 +13:00
Brenda Wallace
2c5d5e0983 fix ruby syntax in spec 2019-12-24 22:18:14 +13:00
Brenda Wallace
b25a13df89 fix rss feeds 2019-12-24 21:53:00 +13:00
Brenda Wallace
56c3fdd4fe index records before vie spec 2019-12-24 20:23:27 +13:00
Brenda Wallace
44a59a30e1 seeds#index rss format specs updated to use ES 2019-12-24 09:44:12 +13:00
Brenda Wallace
d71d8aa603 seeds view spec refresehs the ES index 2019-12-24 09:24:43 +13:00
Brenda Wallace
1f17ea1e03 fixes (most of) seed rss specs 2019-12-23 16:52:56 +13:00
Brenda Wallace
8f25ef5258 index seeds in spec 2019-12-23 15:07:24 +13:00
Brenda Wallace
96f6fd3708 update to expect syntax 2019-12-22 17:16:13 +13:00
Brenda Wallace
6b1f85fe72 Merge branch 'dev' into cache/harvests 2019-12-21 17:27:23 +13:00
Brenda Wallace
97c4bd3919 Remove newrelic (#2339)
* Remove newrelic
* Update forum view spec
* only test for the first 20 chars of post subject
2019-12-21 17:07:20 +13:00
codefactor-io
cb75e4ff0c [CodeFactor] Apply fixes to commit 44d635e 2019-12-21 03:25:07 +00:00
Brenda Wallace
44d635e9b3 Update plantings#index view spec to use hashes like an ES search result 2019-12-21 16:24:21 +13:00
codefactor-io
e8760f9c38 [CodeFactor] Apply fixes 2019-12-20 03:33:23 +00:00