Brenda Wallace
f4af682d45
Updated code for Rail 5
2018-01-03 17:12:17 +13:00
Brenda Wallace
24f18f78da
use bare percent literals
2017-12-06 14:33:51 +13:00
Brenda Wallace
182c626226
Prefer if/unless modifier
2017-12-06 14:23:12 +13:00
Brenda Wallace
515325c44e
Fixed up % delimiters
2017-12-06 14:14:31 +13:00
Brenda Wallace
2d00206abf
Converted sprintf to format
2017-12-06 14:10:26 +13:00
Brenda Wallace
a6a7f789a3
Rubocop upgrade (and some style fixes)
2017-12-01 21:07:39 +13:00
Brenda Wallace
adf07ce5ef
Planting feature specs passing
2017-11-01 13:57:49 +13:00
Brenda Wallace
b09c4aa7a1
Update display, to show predicted finish date
2017-11-01 13:57:49 +13:00
Brenda Wallace
b538330785
Form to delete your own account
2017-05-21 21:51:44 +12:00
Brenda Wallace
17236a4a8a
Garden thumbnail display cleanup
2017-04-16 13:48:22 +12:00
Brenda Wallace
c89c20e842
View harvests for a planting
2017-03-12 14:44:11 +13:00
Brenda Wallace
6c282ffbd7
rubocop fix for redundant self assignment
2017-03-02 22:21:15 +13:00
Brenda Wallace
550848a513
ParenthesesAroundCondition fixup
2017-02-19 16:20:45 +13:00
Brenda Wallace
6f74566d47
Truncate, escape, and DRY og:description fields
2017-02-08 09:49:19 +13:00
Brenda Wallace
f96f459595
Moved title logic into application helper
...
For harvests, plantings, and seeds
2017-02-08 07:25:59 +13:00
Brenda Wallace
096146cb84
Fix: @owner -> owner in harvests_title
2017-02-08 07:25:59 +13:00
Brenda Wallace
ba1c40702b
DRY up gardens and plantings helper
2017-02-08 07:25:59 +13:00
Brenda Wallace
338265d9e9
Haml cleanup for plantings views
2017-02-08 07:25:59 +13:00
Brenda Wallace
e1e9c32652
Moved havests#index title to a helper
2017-02-08 07:25:59 +13:00
Brenda Wallace
740b8587f2
Moved complex parts of garden/nav into helper
2017-02-08 07:25:59 +13:00
Brenda Wallace
ac7d44cb72
Cleaned up most of harvest's haml
2017-02-08 07:25:59 +13:00
Brenda Wallace
80371c835c
Moved long line (ebay url) to helper
2017-02-06 10:40:58 +13:00
Brenda Wallace
19aa3a1ca4
PlantingsHelper simplification
2017-02-03 20:42:15 +13:00
Brenda Wallace
40a981c94d
Removed unnecesary braces on hash args
2017-01-22 15:10:11 +13:00
Brenda Wallace
3b1753d3d5
Garden's name in link
2017-01-02 20:36:25 +13:00
Brenda Wallace
ca7868b79a
Use guard clauses
2016-12-14 21:28:35 +00:00
Brenda Wallace
8981a222ea
Simplified display_weight
2016-12-06 00:32:20 +00:00
Brenda Wallace
91b0c1898e
Simplifying display_harvest_description
2016-12-05 20:40:34 +00:00
Brenda Wallace
26e5a414cf
Line no longer needs wrapping
2016-12-04 21:23:33 +00:00
Brenda Wallace
92195d51d2
Removed redundant returns
2016-12-04 21:21:35 +00:00
Miles Gould
9400225f65
Return a string from display_days_before_maturity
...
Sometimes we were returning a string, and sometimes we were returning an
integer. We're only ever displaying the result, and this seems a little
more consistent.
2016-11-30 10:16:02 +00:00
Miles Gould
b0b864a5d4
Fix off-by-one bug in display_days_before_maturity
...
We were counting from DateTime.now rather than Date.current, causing us to
under-count by a day.
2016-11-30 10:16:02 +00:00
pozorvlak
d3b927b44b
Merge pull request #1096 from Growstuff/master
...
Master to dev for 1092
2016-11-30 09:44:12 +00:00
Brenda Wallace
900e7361c6
Check we have a planted_at ts before doing maths with it
2016-11-30 17:39:26 +13:00
Brenda Wallace
723ebff923
Spacing fixes
2016-11-26 12:13:17 +13:00
Brenda Wallace
62e7c716dd
Removed extra empty blank lines
2016-11-26 12:06:02 +13:00
Brenda Wallace
2e46cccd21
Hash alignment
2016-11-26 11:52:10 +13:00
Brenda Wallace
ebacd83dde
Case statement indentation clean up
2016-11-26 11:42:34 +13:00
Brenda Wallace
c878baa886
Indented parameters cleanup
2016-11-26 11:41:07 +13:00
Brenda Wallace
917e33bccf
Merge remote-tracking branch 'upstream/dev' into bw/long-lines-fixed
2016-11-20 19:24:53 +13:00
Brenda Wallace
2872a1c29d
Wrapped all long lines.
...
reduced rubocop's line length limit to 120
2016-11-17 22:02:18 +13:00
Brenda Wallace
5e0cff5b8e
Merge remote-tracking branch 'upstream/dev' into bw/covert-tabs-to-spaces
...
Conflicts:
app/helpers/seeds_helper.rb
spec/support/controller_macros.rb
2016-11-17 19:04:44 +13:00
Brenda Wallace
5ec2877577
Covert all tabs to spaces
2016-11-16 13:18:26 +13:00
Brenda Wallace
6bd9bd98d9
Removed extra blank lines, & added a end of file
2016-11-16 12:52:48 +13:00
Brenda Wallace
510c31f669
Removed 3 blank lines that codeclimate didn't like
2016-11-14 15:10:13 +13:00
Brenda Wallace
bdb057ca0f
Removed all trailing white space
2016-11-14 15:05:32 +13:00
Daniel O'Connor
7f6a1a424d
Merge remote-tracking branch 'upstream/dev' into add_facebook_signup
2016-08-15 23:13:55 +09:30
Daniel O'Connor
dba6b2a291
Mitigate security concerns with target=_blank via https://www.jitbit.com/alexblog/256-targetblank---the-most-underestimated-vulnerability-ever/
2016-08-15 21:31:45 +09:30
Daniel O'Connor
7947fd6e91
Clean up link_to as per #1013
2016-07-08 17:08:17 +09:30
Daniel O'Connor
43e7d6f7c2
Merge remote-tracking branch 'upstream/dev' into add_facebook_signup
2016-07-05 03:09:36 +09:30