Brenda Wallace
f4af682d45
Updated code for Rail 5
2018-01-03 17:12:17 +13:00
Brenda Wallace
2394f4d237
One view for showing photos on an item
2017-12-17 11:40:55 +13:00
Brenda Wallace
970da53873
Merge remote-tracking branch 'origin/feature/photos-1457' into feature/photos-1457
2017-12-17 09:15:24 +13:00
Brenda Wallace
3cc637017d
Avoid {} for multiline
2017-12-06 14:29:21 +13:00
Brenda Wallace
2d00206abf
Converted sprintf to format
2017-12-06 14:10:26 +13:00
Brenda Wallace
09f82d5995
Tidy up home/crops partial view
2017-11-29 20:59:37 +13:00
Logan Gingerich
ede5187369
Whitespace fix, spec fix, and spec addition
2017-11-19 11:13:41 +13:00
milesgould
d8bf8ae4df
De-deprecate controller and view specs
...
We deprecated controller and view specs on the grounds that they were
brittle, and were a poorer measure of user experience than feature
specs. However, feature specs have their own problems: they're much
slower to run, and flakier (see #901 ). We also ran into a few cases
where feature specs erroneously passed because they were checking for
the presence of a string that occurred in the error page!
Hence, we're cautiously un-deprecating controller and view specs.
Fixes #1132
2017-11-17 16:51:24 +00:00
Brenda Wallace
2fbba52bc8
Updating specs to use same owner for garden and planting
2017-11-13 19:18:14 +13:00
Brenda Wallace
f2fac9db1b
Time.zone.local
2017-11-04 11:39:53 +13:00
Logan Gingerich
10a8df47a9
Factorygirl to factorybot - fixes #1413 ( #1425 )
...
* FactoryGirl Changed to FactoryBot
file fix
changes based on comments received
Bundle Update on 2017-10-29
style update to align hash literal
added package-lock
* indentation fixes with rubocop
* name added to contributors
2017-11-01 15:03:31 +00:00
Brenda Wallace
0e0af44d9f
post show specs, use expect syntax, and more tests for js injection
2017-10-23 10:44:37 +01:00
Brenda Wallace
45af8d5f4f
Converting to expect syntax
2017-10-23 10:44:37 +01:00
Brenda Wallace
6fef56ebb7
DRY the crops controller
2017-05-29 16:17:43 +12:00
Brenda Wallace
4726b57c47
Inactive plantings show as tiny thumbnails
2017-05-28 17:13:04 +12:00
Brenda Wallace
6c0b1018bc
Updated spec for homepage seeds
2017-05-20 17:16:03 +12:00
Brenda Wallace
d57c46066a
updated view spec to find glypicon
2017-05-06 13:27:23 +12:00
Brenda Wallace
cff1d8bfb9
Photo#show for signed in and not signed in, and other members
2017-04-18 07:09:47 +00:00
Brenda Wallace
bbdc54cb69
Photos#show links to items
2017-04-18 07:09:47 +00:00
Brenda Wallace
36f1f7b71a
updating view spec - link to delete photo has changed
2017-04-18 07:09:47 +00:00
Brenda Wallace
8c5db9229a
fixed forced octal
2017-03-01 17:49:42 +13:00
Brenda Wallace
ae3752e021
DefWithParentheses fixup
2017-02-19 16:19:16 +13:00
Brenda Wallace
818466a142
MethodCallWithoutArgsParentheses fixup
2017-02-19 16:17:03 +13:00
Brenda Wallace
e184503caa
Fix up to match rubocop's MultilineMethodCallBraceLayout recommendation
2017-02-19 16:17:03 +13:00
Brenda Wallace
a46b8ebe76
Fix up all UnneededInterpolation
2017-02-16 12:26:47 +13:00
Brenda Wallace
40a981c94d
Removed unnecesary braces on hash args
2017-01-22 15:10:11 +13:00
Brenda Wallace
f214f608ff
Rename member.is_paid? to paid?
2017-01-14 20:51:22 +13:00
Brenda Wallace
464c570d99
Fixed parentheses that are interp-ed as grouped expression
2016-12-06 21:23:55 +13:00
Brenda Wallace
92195d51d2
Removed redundant returns
2016-12-04 21:21:35 +00:00
Mackenzie Morgan
832719b01a
merge from upstream dev
2016-11-29 09:37:25 -05:00
Mackenzie Morgan
fe860aa1ab
clean up some tests
2016-11-28 22:33:00 -05:00
Brenda Wallace
8763c22284
Merge remote-tracking branch 'upstream/dev' into bw/indentation-for-great-glory
...
Conflicts:
app/models/crop.rb
2016-11-29 02:33:30 +00:00
Brenda Wallace
38fbc52a6f
String interp doesn't need .to_s
2016-11-27 10:17:01 +13:00
Brenda Wallace
723ebff923
Spacing fixes
2016-11-26 12:13:17 +13:00
Brenda Wallace
62e7c716dd
Removed extra empty blank lines
2016-11-26 12:06:02 +13:00
Brenda Wallace
bbc19a5436
Array indentation fixed
2016-11-26 11:49:51 +13:00
Brenda Wallace
d268d2b09e
Fixed indentation on comments
2016-11-26 11:45:25 +13:00
Brenda Wallace
c878baa886
Indented parameters cleanup
2016-11-26 11:41:07 +13:00
Brenda Wallace
564731667e
Fixed up all remaining hash alignment
2016-11-26 11:17:42 +13:00
Brenda Wallace
83392ddda1
Indentation clean ups
2016-11-26 10:51:54 +13:00
Brenda Wallace
6bd9bd98d9
Removed extra blank lines, & added a end of file
2016-11-16 12:52:48 +13:00
Brenda Wallace
bdb057ca0f
Removed all trailing white space
2016-11-14 15:05:32 +13:00
Daniel O'Connor
29765ebc19
rubocop --only HashSyntax --auto-correct
2016-08-22 19:02:27 +09:30
Daniel O'Connor
0620646c6d
Fix failing specs
...
- Updated assert_select behaviour given this is now based on nokogiri
- Adjust some specs not to look for a specific asset name, but a behaviour
- Adjust some specs for HTML5 style attributes instead of xhtml style
- Fix tests that did not render before
2016-06-10 16:01:30 +09:30
Cesy Avon
259c1e1731
Fix #476 show edited and posted date on posts and comments
2016-06-02 14:37:33 +00:00
Cesy
29102e3b52
Cleaning up more tests
2016-05-22 16:05:07 +00:00
Cesy
8c0fc54344
Sorting tests related to moving to CMS
2016-05-22 16:04:39 +00:00
Daniel O'Connor
4b4e0cf69a
$ rubocop --only HashSyntax --auto-correct
...
483 files inspected, 2018 offenses detected, 2018 offenses corrected
2016-05-19 15:53:11 -04:00
Daniel O'Connor
bfffaab77f
Have to stub the controller load_and_authorize_resource behaviour, as these tests aren't run in that context.
2016-03-28 22:26:36 +10:30
Daniel O'Connor
32af1b28a8
Update the expectations: an edit link is visible to crop wranglers (which used to be an expectation about the id appearing in a link)
2016-03-28 22:03:59 +10:30
