We deprecated controller and view specs on the grounds that they were
brittle, and were a poorer measure of user experience than feature
specs. However, feature specs have their own problems: they're much
slower to run, and flakier (see #901). We also ran into a few cases
where feature specs erroneously passed because they were checking for
the presence of a string that occurred in the error page!
Hence, we're cautiously un-deprecating controller and view specs.
Fixes#1132
* FactoryGirl Changed to FactoryBot
file fix
changes based on comments received
Bundle Update on 2017-10-29
style update to align hash literal
added package-lock
* indentation fixes with rubocop
* name added to contributors
- Updated assert_select behaviour given this is now based on nokogiri
- Adjust some specs not to look for a specific asset name, but a behaviour
- Adjust some specs for HTML5 style attributes instead of xhtml style
- Fix tests that did not render before
We have to call post.save in the posts/index specs, because post_path
fails unless the post has been persisted (and hence had its slug
generated). I think. That fixed the failing tests, anyway.
- add Permalink
- show Reply instead of "Comment" (iff you can comment)
- Edit link shows if you have permission to edit
- reorganised tests for post/_single
- posts/_single now requires current_user; patch tests for comments.
* dev: (28 commits)
Upgrade bootstrap by running `rails g bootstrap:install`
added .to_i to times to attempt to pass tests on travis
stubbed Time.now to prevent test failures
Added friendly IDs for forum and role
General prettification and making it look nice.
show forum name in post meta
Added a rake task to create an admin user.
hooked roles up to cancan
Added roles, but haven't yet hooked them up to CanCan
PT story 41985889, Hides 'new garden' tab on other member's pages
Add forums to top nav
Display posts in summary on forum page
tests for markdown
post in (or not in) a forum
prettifying forum views
added associations between forums, posts, and members
rails g scaffold Forum
Rearranging password fields
Attempted rearranging settings page, broke something
Upgrade to Rails 3.2.12, after *another* security flaw.
...
Conflicts:
spec/models/member_spec.rb
We have added a sequence for login_name which is similar to the one for
emails in which the member name is incremented each time a new member is
saved.
In addition, we have updated all specs which asked for an explicit
login_name of member1 to use a regex looking only for member and some
digit.
