Commit Graph
24 Commits
Author SHA1 Message Date
Brenda WallaceandClaude Opus 5 6dbab4678f Stop avatars shifting the page during feature specs (#4847)
* Stop avatars shifting the page during feature specs

spec/features/places/searching_a_place_spec.rb intermittently failed on
"goes to members' index page": the click on "View all members >>" landed
on nothing and the browser stayed put.

Member avatars come from gravatar.com over the network and were rendered
with img-fluid and no dimensions, so they reserved no space until they
arrived. The link sits directly under that grid. Capybara found the link,
an avatar landed, the link moved, and the click missed.

rails_helper meant to prevent this, but its guard tested for Poltergeist's
url_blacklist. Poltergeist is long gone and Selenium's browser has no such
method, so the condition was always false and the block never ran.

- Give the two avatar image tags explicit width and height, so the box is
  reserved before the image loads. This fixes real layout shift for
  members too, not only the specs.
- Replace the dead guard with config.x.blank_avatars, which browser specs
  set, making avatar_uri return a blank inline GIF. Helper specs still
  assert the real Gravatar URLs.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

* Fix avatar URI logic to prevent layout shift in all environments

---------

Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
2026-09-24 13:36:44 +09:30
Brenda Wallace 5cedea9da8 removing trailing whitespace 2019-06-14 16:23:31 +12:00
Brenda Wallace 3ed173ebcd Material design changes 2019-02-17 21:33:36 +13:00
Brenda Wallace ac07f18b2d Show most recent seeds first 2017-12-07 15:00:16 +13:00
Brenda Wallace 35d8461811 Order recent plantings by when they were planted 2017-12-07 13:39:32 +13:00
Brenda Wallace 6ecb919f34 haml clean ups for members views 2017-02-13 07:32:43 +13:00
Brenda Wallace 1db30d98ce Haml clean up for members 2017-02-07 15:35:34 +13:00
Lucas Nogueira b911ebfd07 Replace pluralize calls 2016-06-08 22:03:40 -03:00
Daniel O'Connor ff779b6679 Trial rendering as comma separated 2015-08-29 07:51:53 +09:30
Daniel O'Connor f357916779 For more accurate specs, explicitly target the login-name container 2015-08-29 07:49:55 +09:30
Daniel O'Connor c87a5f2d6b Fix #819 by removing the popover behaviour for a standard avatar; and putting the stats onto the card. 2015-08-27 14:35:15 +09:30
Mackenzie Morgan b0d4f9c731 switch homepage and members/ page member thumbnails to be a flexbox layout so it's more responsive. Fixes #780 2015-07-23 13:56:07 -04:00
Taylor Griffin 007f7112a7 replaced caching using observers with a key-based (and simplified) caching system 2014-12-19 21:17:43 +11:00
Amy Hendrix 98cbac8a70 Remove an extra class on member thumbs 2014-07-14 21:18:15 -04:00
Amy Hendrix 81a996b8cc New markup for thumbnails 2014-07-14 20:50:35 -04:00
Amy Hendrix f0cd8df6e0 Update column classes 2014-07-13 18:16:57 -04:00
Amy Hendrix 8d0d01991b Bootstrap3 update: row classes 2014-07-13 15:15:08 -04:00
Miles Gould 9c5b6f6192 Rename Crop.system_name to Crop.name 2013-10-18 11:52:05 +01:00
Skud cc97fd8f49 think we've FINALLY really fixed the member layout 2013-08-22 00:30:02 +10:00
Skud 908cf41f39 tweaked thumbnail to take up less vertical space 2013-08-21 23:42:16 +10:00
Skud 7e98981c0a standardise on _id for caching 2013-08-14 12:09:11 +10:00
Skud 5d3a44ae0c cache stats and member thumbnails on homepage 2013-08-14 11:47:09 +10:00
Skud e1d6c6bf70 fixed member thumbnails on homepage and changed member index to match 2013-08-09 14:58:36 +10:00
Skud efb3c1cf50 Added a display of interesting members to the homepage.
Also merged in the latest dev (hence some minor changes to non-homepage,
non-member stuff).  I think I messed up the merge a bit :-/
2013-04-02 13:59:34 +11:00