Logan Gingerich
10a8df47a9
Factorygirl to factorybot - fixes #1413 ( #1425 )
...
* FactoryGirl Changed to FactoryBot
file fix
changes based on comments received
Bundle Update on 2017-10-29
style update to align hash literal
added package-lock
* indentation fixes with rubocop
* name added to contributors
2017-11-01 15:03:31 +00:00
Brenda Wallace
97c7277a73
fixed up ambigous regex and use of expect in specs
2017-10-23 10:44:37 +01:00
Brenda Wallace
e1731793dd
controller specs for PhotoAssociations
2017-04-18 07:09:47 +00:00
Brenda Wallace
d44f9ef4e9
Removed assignment of useless variable
2017-03-29 08:21:34 +13:00
Brenda Wallace
998befb30f
Limited plantings to member's own garden, and approved crops
2017-03-16 15:29:25 +13:00
pozorvlak
837934167b
Merge branch 'dev' into harvests-controller
2017-02-20 13:02:58 +00:00
Brenda Wallace
0f523381f0
DRY the harvest controller
2017-02-20 09:58:36 +13:00
Brenda Wallace
e184503caa
Fix up to match rubocop's MultilineMethodCallBraceLayout recommendation
2017-02-19 16:17:03 +13:00
Brenda Wallace
d00f743c47
rubocop fix up on spec
2017-02-17 16:00:11 +13:00
Brenda Wallace
d15eb32133
Added some utf8, kōrero mai (te reo māori)
2017-02-17 09:47:12 +13:00
Brenda Wallace
ae398f1a63
Spec checks you can't change post id in comments#update
2017-02-17 09:20:15 +13:00
Brenda Wallace
cd3cee5d5f
DRY comments controller and add more spec scenarios
2017-02-17 09:14:01 +13:00
Brenda Wallace
4dd99f54db
Removed deprecation notice from controller spec
2017-02-12 20:55:06 +13:00
Brenda Wallace
b8e06a1d1d
Specs for deleting someone else's like
2017-02-12 20:50:50 +13:00
Brenda Wallace
f7b8113af1
Fixed spec, now requests json response
2017-02-12 20:36:24 +13:00
Brenda Wallace
b0394d1028
checks json returned by likes controller
2017-02-12 17:42:24 +13:00
Brenda Wallace
865f323f97
controller specs for likes controller
2017-02-12 15:35:15 +13:00
Daniel O'Connor
b24514fa82
Look at right attribute
2017-02-06 14:11:44 +10:30
Daniel O'Connor
f0a81d4100
Fix #1182 and improve test coverage
2017-02-06 14:10:40 +10:30
Brenda Wallace
40a981c94d
Removed unnecesary braces on hash args
2017-01-22 15:10:11 +13:00
Shiny
d40eccdb63
Merge branch 'dev' into bw/harvests-linkto-plantings
2017-01-05 16:31:22 +13:00
Brenda Wallace
283bb76a9e
Link a harvest to a planting, and display
2017-01-04 22:45:49 +13:00
Brenda Wallace
ab75f830fb
Controller garden specs for member doing what they shouldn't
2016-12-25 10:38:07 +13:00
Brenda Wallace
92195d51d2
Removed redundant returns
2016-12-04 21:21:35 +00:00
Brenda Wallace
178c181cf5
Merge remote-tracking branch 'upstream/dev' into bw/useless-assignments
...
Conflicts:
app/controllers/crops_controller.rb
app/models/crop.rb
spec/models/scientific_name_spec.rb
2016-11-30 10:32:02 +13:00
Mackenzie Morgan
832719b01a
merge from upstream dev
2016-11-29 09:37:25 -05:00
Mackenzie Morgan
e1a2b168c9
rename scientific_names.scientific_name to scientific_names.name
...
this mirrors alternate_names.name and allows making code more DRY
2016-11-28 21:57:51 -05:00
Brenda Wallace
8c7fcd9d49
Fixed all useless assignments
2016-11-26 19:36:59 +13:00
Brenda Wallace
bcdd2a9167
Changed called to rails dynamic find_by
2016-11-26 15:55:38 +13:00
Brenda Wallace
723ebff923
Spacing fixes
2016-11-26 12:13:17 +13:00
Brenda Wallace
62e7c716dd
Removed extra empty blank lines
2016-11-26 12:06:02 +13:00
Brenda Wallace
83392ddda1
Indentation clean ups
2016-11-26 10:51:54 +13:00
Brenda Wallace
dac2343b68
Further code duplication reduction
2016-11-20 21:18:07 +13:00
Brenda Wallace
f24e02fd11
reduced code duplication again in photos cont spec
2016-11-20 21:13:57 +13:00
Brenda Wallace
dddc7b020d
Corrected description in spec
2016-11-20 21:13:33 +13:00
Brenda Wallace
12a9a0b97d
one more check no alert was generated
2016-11-20 21:13:08 +13:00
Brenda Wallace
6a8f48693b
Reduce code duplication in photos cont spec
2016-11-20 21:12:43 +13:00
Brenda Wallace
50a0668c1d
Check no alert message was generated
2016-11-20 21:11:54 +13:00
Brenda Wallace
a7e88a55b3
Spec for trying to attach photo when not allowed.
2016-11-20 21:03:08 +13:00
Brenda Wallace
d0a1a113b6
Multi-line block changed from {} to do end
2016-11-20 20:29:01 +13:00
Brenda Wallace
a8bffd3bce
White space fix in spec
2016-11-20 20:28:34 +13:00
Brenda Wallace
f6aac07c3d
Flatten params passed in photos controller spec
2016-11-20 20:27:59 +13:00
Brenda Wallace
72f1d83af4
Removed a bunch of blank lines
2016-11-20 20:19:14 +13:00
Brenda Wallace
bdb057ca0f
Removed all trailing white space
2016-11-14 15:05:32 +13:00
Daniel O'Connor
29765ebc19
rubocop --only HashSyntax --auto-correct
2016-08-22 19:02:27 +09:30
Daniel O'Connor
18cd8f5966
#507 #813 Add spec
2016-05-19 15:53:11 -04:00
Daniel O'Connor
4b4e0cf69a
$ rubocop --only HashSyntax --auto-correct
...
483 files inspected, 2018 offenses detected, 2018 offenses corrected
2016-05-19 15:53:11 -04:00
Cesy
01b9e76814
Merge pull request #860 from CloCkWeRX/fix_warnings
...
Fix WARNING: Using the `raise_error` matcher without providing a specific error
2016-04-09 13:26:11 +01:00
Daniel O'Connor
a3ad9189b1
Fix WARNING: Using the raise_error matcher without providing a specific error or message risks false positives, since raise_error will match when Ruby raises a NoMethodError, NameError or ArgumentError, potentially allowing the expectation to pass without even executing the method you are intending to call. Actual error raised was #<ActiveRecord::RecordNotFound: Couldn't find Member with 'id'=9999>. Instead consider providing a specific error class or message. This message can be supressed by setting: RSpec::Expectations.configuration.warn_about_potential_false_positives = false. Called from /home/travis/build/Growstuff/growstuff/spec/controllers/member_controller_spec.rb:65:in `block (3 levels) in <top (required)>'.
2016-04-07 10:41:35 +09:30
Daniel O'Connor
c3a883de16
Ensure we choose a plant part
2016-04-07 09:47:53 +09:30
