Daniel O'Connor
c3d9885525
Merge pull request #987 from CloCkWeRX/upgradazzle_rails
...
Upgrade to rails 4.2.0+ (round 2)
2016-06-29 14:47:05 +09:30
Mackenzie Morgan
7a53e96d52
test the default case
2016-06-19 22:52:51 -04:00
Mackenzie Morgan
b28d146de7
use default of info
...
add tests
2016-06-19 22:42:20 -04:00
Miles Gould
1b07632c69
Block external URLs in features
...
https://github.com/teampoltergeist/poltergeist/issues/375#issuecomment-42620085
suggested that this might help with our intermittent "Request to
http://localhost:8081 failed to reach server, check DNS and/or server
status" errors in CI - the theory being that the error message is
misleading, and it's actually a daughter request to an external service
timing out. Seems worth a shot. It also ought to speed up testing, but
the effect is slight (20s out of 3.5 minutes) on my machine.
I've blacklisted only URLs I could find in app/views or by tcpdumping a
test run, because I couldn't get whitelisting to work.
2016-06-17 21:12:25 +01:00
Daniel O'Connor
0620646c6d
Fix failing specs
...
- Updated assert_select behaviour given this is now based on nokogiri
- Adjust some specs not to look for a specific asset name, but a behaviour
- Adjust some specs for HTML5 style attributes instead of xhtml style
- Fix tests that did not render before
2016-06-10 16:01:30 +09:30
Daniel O'Connor
7fe75ee52a
Fix DEPRECATION WARNING: #deliver is deprecated.
2016-06-10 15:45:01 +09:30
Lucas Nogueira
9ce097b7d6
Fix SimpleCov Deprecation Warning
2016-06-09 17:42:11 -03:00
pozorvlak
b03ccce575
Merge pull request #980 from lucasnogueira/replace_pluralize
...
Replace pluralize calls
2016-06-09 16:39:34 +01:00
Lucas Nogueira
5dbd5bc1d2
Correct minor typos
2016-06-09 08:21:28 -03:00
Lucas Nogueira
905710b6e9
Helper for plural localization
2016-06-08 21:55:33 -03:00
pozorvlak
936aa17ecc
Remove references to vendor directory
...
This consisted of instructions to various code-quality tools to
ignore it.
2016-06-07 17:43:36 +00:00
Cesy
7885257fae
Merge pull request #943 from CloCkWeRX/adjust_helper
...
Deal with .nil quantity of a seed in rendering helper
2016-06-04 12:41:03 +01:00
Daniel O'Connor
a8d22709e6
Add explict test coverage of the helper with nil seeds (page level tests already cover this rendering on crop detail in general)
2016-06-04 20:51:20 +09:30
DV Dasari
ed4269ea4c
fixing grammar in test descriptions
2016-06-03 07:54:24 -05:00
DV Dasari
085fcc958e
Add test coverage for GardensHelper
2016-06-02 22:22:14 -05:00
Cesy Avon
fc38e1edea
Issue #476 test update
2016-06-02 14:58:10 +00:00
Cesy Avon
259c1e1731
Fix #476 show edited and posted date on posts and comments
2016-06-02 14:37:33 +00:00
DV Dasari
21d86a8c2d
improve the test descriptions to be more readable
2016-06-01 09:46:22 -05:00
DV Dasari
848c7e117b
Add test coverage for Seeds Helper
2016-06-01 09:46:22 -05:00
Miles Gould
6dd7ec9f95
Fix coverage calculations
...
SimpleCov was reporting 0% coverage for any files loaded before
`SimpleCov.start` was called, even if they were fully tested. This patch
loads the application *after* starting SimpleCov, leading to more
accurate coverage figures.
2016-06-01 14:54:13 +01:00
Eric Tillberg
2ac901c891
feature test for issue 910
2016-05-30 09:06:09 -04:00
Mackenzie Morgan
13dc87f368
Optional field improvements
...
* Added custom matcher `have_optional(field id name goes here)`
* Fix partial
* Add tests
2016-05-27 11:26:36 -04:00
Mackenzie Morgan
fc0116182f
Merge branch 'dev' of gitmaco:Growstuff/growstuff into bug-#848
2016-05-27 11:24:37 -04:00
Miles Gould
1009570102
Check href attribute of links in planting reminder
...
To check the target of a link, you need to pass it to `has_link` as an
`href` keyword argument. We were passing it as a positional argument,
which meant that
- it was ignored, weakening the tests
- the output of rspec filled up with annoying warnings.
Fixes #928 .
2016-05-27 15:46:21 +01:00
Mackenzie Morgan
47f42d0ffa
Merge branch 'dev' of gitmaco:Growstuff/growstuff into bug-#848
2016-05-27 10:22:35 -04:00
Miles Gould
23d21be73f
Delete debugging puts statement from spec
...
Fixes the "rspec output includes an HTML page dump" issue noted at
2089866756 (diff-6464240396bc745d7e89a408c200fd3aR15)
2016-05-27 14:04:30 +01:00
pozorvlak
25f8d2ca44
Merge pull request #924 from maco/capybara-tools
...
Add capybara-screenshot to assist with feature testing
2016-05-27 13:18:26 +01:00
Mackenzie Morgan
75631da398
Set filename of screenshot to test name
2016-05-27 00:21:02 -04:00
Mackenzie Morgan
2089866756
Display one line of description in harvest card, then go to ellipsis and put read more on next line
...
Fixes #854
2016-05-26 23:08:23 -04:00
Mackenzie Morgan
8d982c7e3e
Add capybara-screenshot to assist with feature testing
2016-05-26 22:39:58 -04:00
Mackenzie Morgan
079cecc529
Swap over to having "(Optional)" (or translation) after optional form elements rather than using placeholder text
...
Fixes #848
2016-05-26 16:53:46 -04:00
Mackenzie Morgan
58f4ae32d0
test update
2016-05-26 12:28:58 -04:00
pozorvlak
d6999b2a8a
Merge pull request #879 from Growstuff/code_climate
...
Add code climate to README
2016-05-23 19:00:26 +01:00
pozorvlak
ae482ecab6
Merge pull request #802 from cesy/issue690
...
Issue 690 Switch on CMS and remove old files
2016-05-23 12:24:49 +01:00
Daniel O'Connor
dc9ee18e96
Update stale test expectation
2016-05-23 12:56:37 +09:30
Daniel O'Connor
b4060b7903
Update stale test expectation
2016-05-23 12:55:50 +09:30
Cesy
29102e3b52
Cleaning up more tests
2016-05-22 16:05:07 +00:00
Cesy
8c0fc54344
Sorting tests related to moving to CMS
2016-05-22 16:04:39 +00:00
Daniel O'Connor
18cd8f5966
#507 #813 Add spec
2016-05-19 15:53:11 -04:00
Daniel O'Connor
4b4e0cf69a
$ rubocop --only HashSyntax --auto-correct
...
483 files inspected, 2018 offenses detected, 2018 offenses corrected
2016-05-19 15:53:11 -04:00
Mackenzie Morgan
8659ebca2d
switch from less to sass
...
* dependency hell + bit rot on upstream libraries prevents installation on OS X
2016-05-19 15:52:54 -04:00
Mackenzie
925027f7f0
add code climate test reporter
2016-05-17 14:02:42 -04:00
Cesy
260b16da11
Merge pull request #865 from CloCkWeRX/fix_progress
...
Fix progress calculations
2016-04-21 08:02:37 +01:00
Daniel O'Connor
12ad16a05a
Newlines
2016-04-13 08:41:05 +09:30
Daniel O'Connor
82553d6e0a
Avoid time travel in favour of calculating a number of past/future dates
2016-04-11 09:29:06 +09:30
Daniel O'Connor
3644a8124f
Tweak specs, implementation properly
2016-04-09 22:54:03 +09:30
Daniel O'Connor
5cfa051d75
Update expectations
2016-04-09 22:43:17 +09:30
Cesy
01b9e76814
Merge pull request #860 from CloCkWeRX/fix_warnings
...
Fix WARNING: Using the `raise_error` matcher without providing a specific error
2016-04-09 13:26:11 +01:00
Daniel O'Connor
7bb7a18b66
Fixes #850 Refactors percentage grown to model, stops rendering progress bars in situations it doesn't make sense. Adds specs.
2016-04-09 21:45:13 +09:30
Daniel O'Connor
a3ad9189b1
Fix WARNING: Using the raise_error matcher without providing a specific error or message risks false positives, since raise_error will match when Ruby raises a NoMethodError, NameError or ArgumentError, potentially allowing the expectation to pass without even executing the method you are intending to call. Actual error raised was #<ActiveRecord::RecordNotFound: Couldn't find Member with 'id'=9999>. Instead consider providing a specific error class or message. This message can be supressed by setting: RSpec::Expectations.configuration.warn_about_potential_false_positives = false. Called from /home/travis/build/Growstuff/growstuff/spec/controllers/member_controller_spec.rb:65:in `block (3 levels) in <top (required)>'.
2016-04-07 10:41:35 +09:30
