Brenda Wallace
fdfb116d92
Ignore one Style/ClassAndModuleChildren
2017-10-19 08:22:40 +13:00
Brenda Wallace
c28ae4fe83
Use ! to indicate the method changes class variables
2017-10-19 08:22:40 +13:00
Brenda Wallace
4b4669459e
Fixed duplicated code in growstuff member link markdown
2017-10-19 08:22:40 +13:00
Brenda Wallace
77902ad300
Moved member look up to a method (less duplicate code)
2017-10-19 08:22:40 +13:00
Brenda Wallace
f314fcd919
Fixed members link in growstuff markdown
2017-10-19 08:22:40 +13:00
Brenda Wallace
8171c12a5b
Fixed links to crops in growstuff markdown
2017-10-19 08:22:40 +13:00
Brenda Wallace
bf189092ea
More simplification of growstuff markup
2017-10-19 08:22:40 +13:00
Brenda Wallace
a539a47044
Reduced complexity of growstuff_markdown
2017-10-19 08:22:40 +13:00
Brenda Wallace
0ecc65bbe0
rubocop fix for redundant self
2017-03-02 22:21:15 +13:00
Brenda Wallace
e229438997
rubocop fox for numeric literals
2017-03-01 17:46:12 +13:00
Brenda Wallace
abbd2cf0a4
fix bug: look up parent crop by name in csv import
2017-02-23 15:35:29 +13:00
Brenda Wallace
4e722dd123
Move crop csv import to own file
2017-02-23 15:35:29 +13:00
Miles Gould
9030e5b978
Merge branch 'dev' into test_runners
2017-02-16 13:31:39 +00:00
Brenda Wallace
2b03381a24
Removed trailing commas
2017-02-15 23:33:06 +00:00
Brenda Wallace
be2426c99f
Use timezone when creating dates
2017-02-10 21:53:18 +13:00
Miles Gould
2accb727e5
Describe rake static
2017-02-07 14:38:04 +00:00
Miles Gould
68120c5bbe
Make rake spec depend on rake assets:precompile
2017-02-07 14:27:14 +00:00
Miles Gould
71ec9fd2d3
Run JS tests from rake and rake spec:unit
2017-02-07 14:27:14 +00:00
Miles Gould
7672b9ffc8
Add spec:unit Rake task
2017-02-07 14:27:14 +00:00
Miles Gould
8d237cc2ee
Make rake run specs and static checks by default
2017-02-07 14:27:14 +00:00
Brenda Wallace
370938c9f9
change deliver_later to deliver_now, so we don't sys.exit() crash
2017-01-22 21:22:30 +13:00
Shiny
ee7fbb9ab9
Merge branch 'dev' into bw/guard-clauses
2016-12-21 20:53:47 +13:00
Miles Gould
b8385afb2f
Remove apparently-unused Geocodable.geocode method
...
We have unit tests for geocoding, but it's not being covered, so I
assume it's being shadowed by a method installed directly from Geocoder.
2016-12-19 20:14:05 +00:00
Brenda Wallace
ca7868b79a
Use guard clauses
2016-12-14 21:28:35 +00:00
Brenda Wallace
92195d51d2
Removed redundant returns
2016-12-04 21:21:35 +00:00
Shiny
1388aa3b06
Merge branch 'dev' into bw/useless-assignments
2016-12-03 08:23:19 +13:00
Daniel O'Connor
fa65be40a4
lib/tasks/i18n.rake:8:37: W: Lint/UnusedBlockArgument: Unused block argument - t. If it's necessary, use _ or _t as an argument name to indicate that it won't be used.
2016-12-02 15:51:29 +10:30
Jim Stallings
fe6e269c64
GS-658 - i18n automation POC
2016-12-02 15:34:38 +10:30
Jim Stallings
81f2fa5fa4
GS-658: sort locale keys, add rake task for it
2016-12-02 15:31:07 +10:30
Brenda Wallace
37adbe5f48
Moved case-insensitve login look up to method
2016-12-01 20:25:19 +13:00
Shiny
b454132cae
Merge branch 'dev' into bw/useless-assignments
2016-12-01 12:51:13 +13:00
Miles Gould
6be9640625
Run tests with rake when DB does not yet exist
...
Previously, `rake spec` ran the tests whether or not the `growstuff_test`
database existed or not, but `rake` crashed unless it had already been
created. The problem was that `rake` was trying to load the environment,
which required the presence of a DB; `rake spec` was running this with
the `dev` environment, so succeeded if `growstuff_dev` existed, but
`rake` was running everything with the `test` environment, so would fail
if `growstuff_test` did not exist.
This patch adds `db:create` to the dependencies of the `spec` task,
forcing an unadorned `rake` to create all necessary databases first.
2016-11-30 11:35:35 +00:00
Brenda Wallace
8c7fcd9d49
Fixed all useless assignments
2016-11-26 19:36:59 +13:00
Brenda Wallace
bcdd2a9167
Changed called to rails dynamic find_by
2016-11-26 15:55:38 +13:00
Brenda Wallace
723ebff923
Spacing fixes
2016-11-26 12:13:17 +13:00
Brenda Wallace
62e7c716dd
Removed extra empty blank lines
2016-11-26 12:06:02 +13:00
Brenda Wallace
c878baa886
Indented parameters cleanup
2016-11-26 11:41:07 +13:00
Brenda Wallace
83392ddda1
Indentation clean ups
2016-11-26 10:51:54 +13:00
Brenda Wallace
be67b858b4
Merge remote-tracking branch 'upstream/dev' into bw/long-lines-fixed
...
Conflicts:
lib/tasks/growstuff.rake
2016-11-25 08:18:18 +13:00
Brenda Wallace
18a8d6c5bf
Re-instate usage info when args not as expected
2016-11-23 20:38:46 +13:00
Brenda Wallace
37d01e831f
Reduced code duplication in growstuff.rake
2016-11-23 20:27:20 +13:00
Brenda Wallace
2872a1c29d
Wrapped all long lines.
...
reduced rubocop's line length limit to 120
2016-11-17 22:02:18 +13:00
Brenda Wallace
6bd9bd98d9
Removed extra blank lines, & added a end of file
2016-11-16 12:52:48 +13:00
Brenda Wallace
bdb057ca0f
Removed all trailing white space
2016-11-14 15:05:32 +13:00
Cesy
fe137a11bb
Merge pull request #1031 from CloCkWeRX/queue_mail
...
Queue mail in sidekiq
2016-08-24 10:38:13 +01:00
Daniel O'Connor
29765ebc19
rubocop --only HashSyntax --auto-correct
2016-08-22 19:02:27 +09:30
Daniel O'Connor
87352b04f1
Refactor to a method to DRY, even if its not 100% the best spot for it to live long term
2016-08-22 18:52:12 +09:30
Daniel O'Connor
5d70d822eb
#951 Swap to deliver_later implementation
2016-08-16 10:55:40 +09:30
Daniel O'Connor
43e7d6f7c2
Merge remote-tracking branch 'upstream/dev' into add_facebook_signup
2016-07-05 03:09:36 +09:30
Daniel O'Connor
7fe75ee52a
Fix DEPRECATION WARNING: #deliver is deprecated.
2016-06-10 15:45:01 +09:30
