Brenda Wallace
2b0f199329
change string replacement for performance reasons
2017-12-06 15:19:34 +13:00
Brenda Wallace
24f18f78da
use bare percent literals
2017-12-06 14:33:51 +13:00
Brenda Wallace
3cc637017d
Avoid {} for multiline
2017-12-06 14:29:21 +13:00
Brenda Wallace
37f9dcd7dd
for simple loops, use Integer.times
2017-12-06 14:26:58 +13:00
Brenda Wallace
f516ef2e57
Don't use :: for method calls
2017-12-06 14:24:17 +13:00
Brenda Wallace
515325c44e
Fixed up % delimiters
2017-12-06 14:14:31 +13:00
Brenda Wallace
2d00206abf
Converted sprintf to format
2017-12-06 14:10:26 +13:00
Brenda Wallace
f499f245de
Added new line after block end, for rubocpo
2017-12-06 14:08:05 +13:00
Brenda Wallace
35414391c3
modified spec to please rubocop
2017-12-06 14:07:18 +13:00
Brenda Wallace
1f7f4f52d1
Updated ability_spec.rb to use block end new lines
2017-12-06 14:02:48 +13:00
Brenda Wallace
a6a7f789a3
Rubocop upgrade (and some style fixes)
2017-12-01 21:07:39 +13:00
Brenda Wallace
6ed7376c58
Name garden in spec to ensure it's ordered first
2017-11-29 20:59:37 +13:00
Brenda Wallace
c8a200bf19
Changed selector in view spec
...
it was having trouble finding the link
2017-11-29 20:59:37 +13:00
Brenda Wallace
a62b668781
Fix up duplicate order item in controller spec, and DRY
2017-11-29 20:59:37 +13:00
Brenda Wallace
09f82d5995
Tidy up home/crops partial view
2017-11-29 20:59:37 +13:00
Brenda Wallace
8d0bec34a6
Crops controller spec, use let, other cleanup
2017-11-29 20:59:37 +13:00
Brenda Wallace
3058160a59
Removed an orderng spec for gardens
2017-11-29 20:59:37 +13:00
Brenda Wallace
b813669d71
Updated shop controller specs
2017-11-29 20:59:37 +13:00
Brenda Wallace
9c993e9f47
Plantings controller ordering and specs
2017-11-29 20:59:37 +13:00
Brenda Wallace
d5fece87d0
Tests for comments#index (and bugfix)
2017-11-29 20:59:37 +13:00
Brenda Wallace
33816d4312
Use faker gem, in account types - and add controller specs
2017-11-29 20:59:37 +13:00
Brenda Wallace
6aa689b0d8
Removed some model ordering specs
2017-11-29 20:59:37 +13:00
Brenda Wallace
962b3b574d
Fixed up planting spec to not care about ordering
2017-11-29 20:59:37 +13:00
Brenda Wallace
d77d1d9a77
spec for notifications needs to be agnostic about the order
2017-11-29 20:59:37 +13:00
Brenda Wallace
bd063be3a9
Fix gardens actions, and add specs
...
A bug slipped into all garden display pages - and there were no tests that caught it.
This adds feature specs for gardens#index, which would have detected the un-initialised
variable in haml
2017-11-19 16:31:17 +13:00
Logan Gingerich
ede5187369
Whitespace fix, spec fix, and spec addition
2017-11-19 11:13:41 +13:00
Brenda Wallace
dafaffcd73
Path remains same after sign out for our test cases
2017-11-18 22:25:58 +13:00
Brenda Wallace
3e149a5d1d
Feature spec for showing item details on photo adding page
2017-11-18 22:25:58 +13:00
Brenda Wallace
c20d9b78c5
Reduced the tests of signout on photos/new
2017-11-18 22:25:58 +13:00
Brenda Wallace
7906d50d13
Shaved some yaks to remove a rescue from a controller
2017-11-18 22:25:58 +13:00
Brenda Wallace
3969f410f1
Tidy up photos logic, and test of signin/out on photos#new
2017-11-18 22:25:58 +13:00
Logan Gingerich
6304f230a5
Refactored and specs updated
2017-11-18 22:25:58 +13:00
milesgould
d8bf8ae4df
De-deprecate controller and view specs
...
We deprecated controller and view specs on the grounds that they were
brittle, and were a poorer measure of user experience than feature
specs. However, feature specs have their own problems: they're much
slower to run, and flakier (see #901 ). We also ran into a few cases
where feature specs erroneously passed because they were checking for
the presence of a string that occurred in the error page!
Hence, we're cautiously un-deprecating controller and view specs.
Fixes #1132
2017-11-17 16:51:24 +00:00
Brenda Wallace
c747d46ab5
Request spec for seeds api
2017-11-17 23:22:10 +13:00
Brenda Wallace
3009ed2d83
Merge branch 'api' of github.com:Br3nda/growstuff into api
2017-11-17 23:16:16 +13:00
Shiny
f68a15c04e
Merge branch 'dev' into api
2017-11-17 22:02:12 +13:00
Brenda Wallace
c4a1806a87
Request spec for photos api
2017-11-17 22:01:37 +13:00
Brenda Wallace
fa5e151af0
Request spec for photos api
2017-11-17 22:00:32 +13:00
Brenda Wallace
13e8d1f5a5
Merge remote-tracking branch 'upstream/dev' into api
2017-11-17 21:51:39 +13:00
Brenda Wallace
67dec795a0
Reinstated test of first harvest prediction display
2017-11-17 21:50:59 +13:00
Brenda Wallace
8884056ff3
Run existing crop specs with annual crop
2017-11-17 21:50:59 +13:00
Brenda Wallace
1b4d77e017
Requests spec for member api
2017-11-13 20:03:39 +13:00
Brenda Wallace
08e7c7dd29
Request specs for harvests api
2017-11-13 19:19:18 +13:00
Brenda Wallace
5fec826c41
Add more attributes to crops
2017-11-13 19:19:18 +13:00
Brenda Wallace
c29234c40c
Request specs for crops api
2017-11-13 19:19:18 +13:00
Brenda Wallace
2f0cb5c815
DRY the api specs
2017-11-13 19:19:18 +13:00
Brenda Wallace
b6cbfe25d2
Factory girl becomes factory bot
2017-11-13 19:19:18 +13:00
Brenda Wallace
d8f5876518
Added predictions to planting api, and added specs
2017-11-13 19:19:18 +13:00
Brenda Wallace
ae2cbf0bec
requests spec for modifying immutable gardens on api
2017-11-13 19:19:18 +13:00
Brenda Wallace
d86e0af5ad
Request for for getting api gardens#index
2017-11-13 19:19:18 +13:00
