mirror of
https://github.com/Growstuff/growstuff.git
synced 2026-05-11 09:17:20 -04:00
3b60e8f974
* Implement blocking feature This commit introduces a blocking feature that allows members to block other members. A blocked member is prevented from: - following the blocker - sending private messages to the blocker - replying to the blocker's posts - liking the blocker's content The implementation includes: - A new `Block` model and a corresponding database table. - Updates to the `Member` model to include associations for blocks. - A new `BlocksController` to handle blocking and unblocking actions. - New routes for the `BlocksController`. - UI changes to add block/unblock buttons to the member profile page. - Validations in the `Follow`, `Comment`, and `Like` models to enforce the blocking rules. - A check in the `MessagesController` to prevent sending messages to a member who has blocked the sender. - A callback in the `Block` model to destroy the follow relationship when a block is created. - New feature and model specs to test the blocking functionality. * Implement blocking feature and fix failing tests This commit introduces a blocking feature that allows members to block other members. A blocked member is prevented from: - following the blocker - sending private messages to the blocker - replying to the blocker's posts - liking the blocker's content The implementation includes: - A new `Block` model and a corresponding database table. - Updates to the `Member` model to include associations for blocks. - A new `BlocksController` to handle blocking and unblocking actions. - New routes for the `BlocksController`. - UI changes to add block/unblock buttons to the member profile page. - Validations in the `Follow`, `Comment`, and `Like` models to enforce the blocking rules. - A check in the `MessagesController` to prevent sending messages to a member who has blocked the sender. - A callback in the `Block` model to destroy the follow relationship when a block is created. - New feature and model specs to test the blocking functionality. This commit also fixes a failing test in the blocking feature. The error was caused by the validation being called even when the `member` association was `nil`. A guard has been added to the validation methods in the `Like`, `Follow`, and `Comment` models to prevent this from happening. * Generate schema * Fix tests * Add permissions * Define Block permissions in Ability model The feature specs for member blocking were failing because the "Block" link was not being rendered on member profiles. This was due to the lack of explicit create and destroy permissions for the Block resource in the Ability model, which is used by CanCanCan to authorize actions and by the view to conditionally show links. This change adds the necessary permissions to `member_abilities`: - Allows members to create blocks (except for blocking themselves). - Allows members to destroy blocks where they are the blocker. These rules ensure that the "Block" and "Unblock" links are correctly rendered and authorized for signed-in members. Co-authored-by: CloCkWeRX <365751+CloCkWeRX@users.noreply.github.com> * Comment out specs for now --------- Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com> Co-authored-by: Daniel O'Connor <daniel.oconnor@gmail.com> Co-authored-by: CloCkWeRX <365751+CloCkWeRX@users.noreply.github.com>
72 lines
1.9 KiB
Ruby
72 lines
1.9 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
require 'rails_helper'
|
|
|
|
describe Comment do
|
|
context "basic" do
|
|
let(:comment) { create(:comment) }
|
|
|
|
it "belongs to a post" do
|
|
comment.commentable.should be_an_instance_of Post
|
|
end
|
|
|
|
it "belongs to an author" do
|
|
comment.author.should be_an_instance_of Member
|
|
end
|
|
end
|
|
|
|
context "notifications" do
|
|
it "sends a notification when a comment is posted" do
|
|
expect do
|
|
create(:comment)
|
|
end.to change(Notification, :count).by(1)
|
|
end
|
|
|
|
it "sets the notification fields" do
|
|
@c = create(:comment)
|
|
@n = Notification.first
|
|
@n.sender.should eq @c.author
|
|
@n.recipient.should eq @c.commentable.author
|
|
@n.subject.should include 'commented on'
|
|
@n.body.should eq @c.body
|
|
@n.notifiable.should eq @c.commentable # polymorphic association, this is a Post.
|
|
end
|
|
|
|
it "doesn't send notifications to yourself" do
|
|
@m = create(:member)
|
|
@p = create(:post, author: @m)
|
|
expect do
|
|
create(:comment, commentable: @p, author: @m)
|
|
end.not_to change(Notification, :count)
|
|
end
|
|
end
|
|
|
|
context "when the post author has blocked the comment author" do
|
|
let(:post_author) { create(:member) }
|
|
let(:comment_author) { create(:member) }
|
|
let(:post) { create(:post, author: post_author) }
|
|
|
|
before do
|
|
post_author.blocks.create(blocked: comment_author)
|
|
end
|
|
|
|
it "is not valid" do
|
|
comment = build(:comment, commentable: post, author: comment_author)
|
|
expect(comment).not_to be_valid
|
|
end
|
|
end
|
|
|
|
context "ordering" do
|
|
before do
|
|
@m = create(:member)
|
|
@p = create(:post, author: @m)
|
|
@c1 = create(:comment, commentable: @p, author: @m)
|
|
@c2 = create(:comment, commentable: @p, author: @m)
|
|
end
|
|
|
|
it 'has a scope for ASC order for displaying on post page' do
|
|
described_class.post_order.should eq [@c1, @c2]
|
|
end
|
|
end
|
|
end
|