mirror of
https://github.com/Growstuff/growstuff.git
synced 2026-09-25 15:34:55 -04:00
Brenda WallaceandClaude Sonnet 5
82480f9ce8
* Wait for the page reload in the members list spec The "members list" feature specs click "Show" and then read the list of members right away. "Show" submits a GET form, so the browser loads a whole new page. The spec could read the list from the old page. The old page was then replaced, and Selenium raised StaleElementReferenceError. This failed once in CI on the pull request for #4800: https://github.com/Growstuff/growstuff/actions/runs/35477162596 Both examples now wait for the new URL before they read the list. The URL contains the chosen sort order, so the wait only ends once the new page has loaded. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> * Wait for the place page in the places search spec The "User searches" specs fill in the search form, click "Search", and then read the page straight away. The search goes to /places/search, which redirects to /places/<place>. The spec could read the page while the browser was still moving to the new page. Selenium then raised "Node with given id does not belong to the document". It failed in CI on the first example in "with a valid place": https://github.com/Growstuff/growstuff/actions/runs/35481754102 The search_with helper now waits for the place page URL before it returns. A blank search stays on the same URL, so it does not wait. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> * Rename the places CI workflow from "Admin" to "Places" The workflow in ci-features-places.yml was named "CI Features - Admin". It looks like it was copied from the admin workflow and never renamed. It runs spec/features/places/. Two workflows then had the same name. Every commit showed two "CI Features - Admin" runs. A failing places spec appeared under the admin name, which sent people to the wrong specs: https://github.com/Growstuff/growstuff/actions/runs/35481754102 Branch protection requires a check called "rspec". That is the job name, not the workflow name, so the required check does not change. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> --------- Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>