mirror of
https://github.com/Growstuff/growstuff.git
synced 2026-10-30 10:49:03 -04:00
3b60e8f974
* Implement blocking feature This commit introduces a blocking feature that allows members to block other members. A blocked member is prevented from: - following the blocker - sending private messages to the blocker - replying to the blocker's posts - liking the blocker's content The implementation includes: - A new `Block` model and a corresponding database table. - Updates to the `Member` model to include associations for blocks. - A new `BlocksController` to handle blocking and unblocking actions. - New routes for the `BlocksController`. - UI changes to add block/unblock buttons to the member profile page. - Validations in the `Follow`, `Comment`, and `Like` models to enforce the blocking rules. - A check in the `MessagesController` to prevent sending messages to a member who has blocked the sender. - A callback in the `Block` model to destroy the follow relationship when a block is created. - New feature and model specs to test the blocking functionality. * Implement blocking feature and fix failing tests This commit introduces a blocking feature that allows members to block other members. A blocked member is prevented from: - following the blocker - sending private messages to the blocker - replying to the blocker's posts - liking the blocker's content The implementation includes: - A new `Block` model and a corresponding database table. - Updates to the `Member` model to include associations for blocks. - A new `BlocksController` to handle blocking and unblocking actions. - New routes for the `BlocksController`. - UI changes to add block/unblock buttons to the member profile page. - Validations in the `Follow`, `Comment`, and `Like` models to enforce the blocking rules. - A check in the `MessagesController` to prevent sending messages to a member who has blocked the sender. - A callback in the `Block` model to destroy the follow relationship when a block is created. - New feature and model specs to test the blocking functionality. This commit also fixes a failing test in the blocking feature. The error was caused by the validation being called even when the `member` association was `nil`. A guard has been added to the validation methods in the `Like`, `Follow`, and `Comment` models to prevent this from happening. * Generate schema * Fix tests * Add permissions * Define Block permissions in Ability model The feature specs for member blocking were failing because the "Block" link was not being rendered on member profiles. This was due to the lack of explicit create and destroy permissions for the Block resource in the Ability model, which is used by CanCanCan to authorize actions and by the view to conditionally show links. This change adds the necessary permissions to `member_abilities`: - Allows members to create blocks (except for blocking themselves). - Allows members to destroy blocks where they are the blocker. These rules ensure that the "Block" and "Unblock" links are correctly rendered and authorized for signed-in members. Co-authored-by: CloCkWeRX <365751+CloCkWeRX@users.noreply.github.com> * Comment out specs for now --------- Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com> Co-authored-by: Daniel O'Connor <daniel.oconnor@gmail.com> Co-authored-by: CloCkWeRX <365751+CloCkWeRX@users.noreply.github.com>
100 lines
3.2 KiB
Ruby
100 lines
3.2 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
require 'rails_helper'
|
|
|
|
describe "follows", :js do
|
|
context "when signed out" do
|
|
let(:member) { create(:member) }
|
|
|
|
it "follow buttons on member profile page" do
|
|
visit member_path(member)
|
|
expect(page).to have_no_link "Follow"
|
|
expect(page).to have_no_link "Unfollow"
|
|
end
|
|
end
|
|
|
|
context "when signed in" do
|
|
include_context 'signed in member'
|
|
let(:other_member) { create(:member) }
|
|
|
|
it "your profile doesn't have a follow button" do
|
|
visit member_path(member)
|
|
expect(page).to have_no_link "Follow"
|
|
expect(page).to have_no_link "Unfollow"
|
|
end
|
|
|
|
context "when the other member is blocked" do
|
|
before do
|
|
member.blocks.create(blocked: other_member)
|
|
visit member_path(other_member)
|
|
end
|
|
|
|
it "does not have a follow button" do
|
|
expect(page).to have_no_link "Follow"
|
|
end
|
|
end
|
|
|
|
context "following another member" do
|
|
before { visit member_path(other_member) }
|
|
|
|
it "has a follow button" do
|
|
expect(page).to have_link "Follow", href: follows_path(followed: other_member.slug)
|
|
end
|
|
|
|
it "has correct message and unfollow button" do
|
|
click_link 'Follow'
|
|
expect(page).to have_content "Followed #{other_member.login_name}"
|
|
expect(page).to have_link "Unfollow", href: follow_path(member.get_follow(other_member))
|
|
end
|
|
|
|
it "has a followed member listed in the following page" do
|
|
click_link 'Follow'
|
|
visit member_follows_path(member)
|
|
expect(page).to have_content other_member.login_name
|
|
end
|
|
|
|
it "has correct message and follow button after unfollow" do
|
|
click_link 'Follow'
|
|
click_link 'Unfollow'
|
|
expect(page).to have_content "Unfollowed #{other_member.login_name}"
|
|
visit member_path(other_member) # unfollowing redirects to root
|
|
expect(page).to have_link "Follow", href: follows_path(followed: other_member.slug)
|
|
end
|
|
|
|
it "has member in following list" do
|
|
click_link 'Follow'
|
|
visit member_follows_path(member)
|
|
expect(page).to have_content other_member.login_name
|
|
end
|
|
|
|
it "appears in in followed member's followers list" do
|
|
click_link 'Follow'
|
|
visit member_followers_path(other_member)
|
|
expect(page).to have_content member.login_name
|
|
end
|
|
|
|
it "removes members from following and followers lists after unfollow" do
|
|
expect(member.already_following?(other_member)).to be false
|
|
|
|
click_link 'Follow'
|
|
expect(page).to have_current_path(member_path(other_member))
|
|
expect(page).to have_content "Followed #{other_member.login_name}"
|
|
|
|
member.reload
|
|
expect(member.already_following?(other_member)).to be true
|
|
|
|
click_link 'Unfollow'
|
|
expect(page).to have_current_path(member_path(other_member))
|
|
expect(page).to have_content "Unfollowed #{other_member.login_name}"
|
|
member.reload
|
|
expect(member.already_following?(other_member)).to be false
|
|
|
|
visit member_follows_path(member)
|
|
expect(page).to have_no_content other_member.login_name
|
|
visit member_followers_path(other_member)
|
|
expect(page).to have_content member.login_name
|
|
end
|
|
end
|
|
end
|
|
end
|