mirror of
https://github.com/Growstuff/growstuff.git
synced 2026-02-02 13:41:00 -05:00
d8bf8ae4df
We deprecated controller and view specs on the grounds that they were brittle, and were a poorer measure of user experience than feature specs. However, feature specs have their own problems: they're much slower to run, and flakier (see #901). We also ran into a few cases where feature specs erroneously passed because they were checking for the presence of a string that occurred in the error page! Hence, we're cautiously un-deprecating controller and view specs. Fixes #1132
72 lines
2.5 KiB
Ruby
72 lines
2.5 KiB
Ruby
require 'rails_helper'
|
|
|
|
RSpec.describe GardensController, type: :controller do
|
|
include Devise::Test::ControllerHelpers
|
|
let(:valid_params) { { name: 'My second Garden' } }
|
|
|
|
context "when not signed in" do
|
|
let(:garden) { double('garden') }
|
|
describe 'GET new' do
|
|
before { get :new, id: garden.to_param }
|
|
it { expect(response).to redirect_to(new_member_session_path) }
|
|
end
|
|
describe 'PUT create' do
|
|
before { put :create, garden: valid_params }
|
|
it { expect(response).to redirect_to(new_member_session_path) }
|
|
end
|
|
|
|
describe 'changing existing records' do
|
|
before do
|
|
allow(Garden).to receive(:find).and_return(:garden)
|
|
expect(garden).not_to receive(:save)
|
|
expect(garden).not_to receive(:save!)
|
|
expect(garden).not_to receive(:update)
|
|
expect(garden).not_to receive(:update!)
|
|
expect(garden).not_to receive(:destroy)
|
|
end
|
|
describe 'GET edit' do
|
|
before { get :edit, id: garden.to_param }
|
|
it { expect(response).to redirect_to(new_member_session_path) }
|
|
end
|
|
describe 'POST update' do
|
|
before { post :update, id: garden.to_param, garden: valid_params }
|
|
it { expect(response).to redirect_to(new_member_session_path) }
|
|
end
|
|
describe 'DELETE' do
|
|
before { delete :destroy, id: garden.to_param, params: { garden: valid_params } }
|
|
it { expect(response).to redirect_to(new_member_session_path) }
|
|
end
|
|
end
|
|
end
|
|
context "when signed in" do
|
|
before(:each) { sign_in member }
|
|
|
|
let!(:member) { FactoryBot.create(:member) }
|
|
|
|
describe "for another member's garden" do
|
|
let(:not_my_garden) { double('garden') }
|
|
before do
|
|
expect(Garden).to receive(:find).and_return(:not_my_garden)
|
|
expect(not_my_garden).not_to receive(:save)
|
|
expect(not_my_garden).not_to receive(:save!)
|
|
expect(not_my_garden).not_to receive(:update)
|
|
expect(not_my_garden).not_to receive(:update!)
|
|
expect(not_my_garden).not_to receive(:destroy)
|
|
end
|
|
|
|
describe 'GET edit' do
|
|
before { get :edit, id: not_my_garden.to_param }
|
|
it { expect(response).to redirect_to(root_path) }
|
|
end
|
|
describe 'POST update' do
|
|
before { post :update, id: not_my_garden.to_param, garden: valid_params }
|
|
it { expect(response).to redirect_to(root_path) }
|
|
end
|
|
describe 'DELETE' do
|
|
before { delete :destroy, id: not_my_garden.to_param, params: { garden: valid_params } }
|
|
it { expect(response).to redirect_to(root_path) }
|
|
end
|
|
end
|
|
end
|
|
end
|