mirror of
https://github.com/Growstuff/growstuff.git
synced 2026-02-05 15:11:01 -05:00
4b1cdc5650
I'm not very happy with this change as-is. The tests are very shallow (they wouldn't have caught the bug @tconquest and I found in this code, for instance), and use the deprecated `receive_message_chain` method. From the RSpec docs: "Chains can be arbitrarily long, which makes it quite painless to violate the Law of Demeter in violent ways, so you should consider any use of receive_message_chain a code smell. Even though not all code smells indicate real problems (think fluent interfaces), receive_message_chain still results in brittle examples. For example, if you write allow(foo).to receive_message_chain(:bar, :baz => 37) in a spec and then the implementation calls foo.baz.bar, the stub will not work." Further work needed.