mirror/iNaturalistReactNative
1
0
Fork 0
mirror of https://github.com/inaturalist/iNaturalistReactNative.git synced 2025-12-23 22:18:36 -05:00
Code Issues Packages Projects Releases Wiki Activity

AI Camera gallery button (#1896)

Browse Source 
* Add button to import photos from the gallery to the AI Camera
* Move AI Camera buttons to side rails so it's easier to add new buttons
* Got shutter button closer to spec
* Change e2e to test for element absence instead of status text

Closes #1848
This commit is contained in:
Ken-ichi
2024-07-31 11:14:53 -07:00
committed by GitHub
parent fc4b3caba9
commit 1679f2f24a
8 changed files with 143 additions and 75 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
e2e/signedIn.e2e.js
View File

@@ -179,10 +179,13 @@ describe( "Signed in user", () => {
/ 5. Delete the observations
*/
await deleteObservationByUUID( uuid, username, { uploaded: true } );
// TODO test to make sure the exact observation we created was deleted.
// Testing for the empty list UI isn't adequate because other test runs
// happening in parallel might cause other observations to be there
const deletedObservationText = element( by.text( /1 observation deleted/ ) );
await waitFor( deletedObservationText ).toBeVisible().withTimeout( 10000 );
// It would be nice to test for the "1 observation deleted" status text in
// the toolbar, but that message appears ephemerally and sometimes this
// test doesn't pick it up on the Github runner. Since we created two
// observations, the upload prompt will be the stable status text at this
// point, and we can confirm deletion by testing for the absence of the
// list item for the observation we deleted.
await waitFor( element( by.text( /Upload 1 observation/ ) ) ).toBeVisible( ).withTimeout( 10000 );
await expect( obsListItem ).toBeNotVisible( );
} );
} );