From 5bf82ffb075bdb0eef84d665bd8edc7011090202 Mon Sep 17 00:00:00 2001 From: Ken-ichi Date: Thu, 11 Apr 2024 14:56:14 -0700 Subject: [PATCH] Mark viewed infinite loop (#1386) * Bumped minimum required node version to 18.17 b/c of @react-native-camera-roll/camera-roll@7.5.2 * Prevent infinite useEffect loop in useMarkViewedMutation --- .nvmrc | 2 +- src/components/ObsDetails/hooks/useMarkViewedMutation.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.nvmrc b/.nvmrc index 3c032078a..aacb51810 100644 --- a/.nvmrc +++ b/.nvmrc @@ -1 +1 @@ -18 +18.17 diff --git a/src/components/ObsDetails/hooks/useMarkViewedMutation.js b/src/components/ObsDetails/hooks/useMarkViewedMutation.js index 333ae21c9..1ce61e261 100644 --- a/src/components/ObsDetails/hooks/useMarkViewedMutation.js +++ b/src/components/ObsDetails/hooks/useMarkViewedMutation.js @@ -63,7 +63,7 @@ const useMarkViewedMutation = ( ); useEffect( ( ) => { - if ( !remoteObservation && isMarkingViewed ) { return; } + if ( !remoteObservation || isMarkingViewed ) { return; } if ( localObservation?.unviewed( ) === true ) { setIsMarkingViewed( true ); markViewedMutation.mutate( { id: uuid } );