From d8ca01a176ac46570f5241117fd9babda4309130 Mon Sep 17 00:00:00 2001 From: Johannes Klein Date: Mon, 3 Feb 2025 10:50:21 +0100 Subject: [PATCH] Move Java setup step --- .github/workflows/e2e_android.yml | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/.github/workflows/e2e_android.yml b/.github/workflows/e2e_android.yml index b97915bf3..78aaf0a1c 100644 --- a/.github/workflows/e2e_android.yml +++ b/.github/workflows/e2e_android.yml @@ -39,6 +39,14 @@ jobs: with: node-version: 18 + # Macos-latest runner has 3 Java versions pre-installed, if not specified as here, the build step errors with requiring at least Java 11 or higher + # So, this step is needed for the apk build step, but somehow this is breaking emulator setup, so it is placed here + - name: Set up JDK 11 + uses: actions/setup-java@v4 + with: + java-version: '11' + distribution: 'zulu' + # Use the Android command line tools to download an AOSP emulator image, and setup new avd # The name of the device for testing has to be the same as on the .detoxrc.js file (even if it is not a Pixel) # The mac-os latest runner has 3 different versions of Java pre-installed (8,11,17), and there were errors when setting to use either 11 or 17 explicitly here @@ -95,14 +103,6 @@ jobs: - name: Download the small example cv and geomodel run: npm run add-example-model -- -f=main - # Macos-latest runner has 3 Java versions pre-installed, if not specified as here, the build step errors with requiring at least Java 11 or higher - # So, this step is needed for the apk build step, but somehow this is breaking emulator setup, so it is placed here - - name: Set up JDK 11 - uses: actions/setup-java@v4 - with: - java-version: '11' - distribution: 'zulu' - # This is by far the longest step in this job, currently we are building the apk everytime, maybe there should be a more specific trigger for the entire job - name: Build for detox run: npm run e2e:build:android