Commit Graph

4199 Commits

Author SHA1 Message Date
Johannes Klein
5d022c25b7 Add comment to muted eslint extends 2024-03-29 18:18:39 +01:00
Johannes Klein
486ba4f30f Upgrade React Native to 0.72 (#1337) 2024-03-29 17:52:37 +01:00
Ken-ichi Ueda
d6846de8df Remove Explore back btn when hidden; make sure positional accuracy gets fetched before Suggestions 2024-03-28 17:42:16 -07:00
Amanda Bullington
c21d28ac8e Package upgrades for minor version bumps (#1334)
* Upgrade packages and fix deprecation warning in bottom sheets

* Upgrade packages with minor version updates
2024-03-28 17:37:21 -07:00
Amanda Bullington
065ca6cd71 Store Explore query state (#1322)
* Use stored state in zustand; update navigation packages

* Split up slices; fix back button label in iOS

* Create hook for navigation params'

* Add param to ignore stored state in Explore

* Use saved state params in Explore when navigating from Explore search screens

* Downgrade datetimepicker

* Fix maximum update exceeded error

* Save test fix for later
2024-03-28 15:57:28 -07:00
Johannes Klein
16018e6998 1312 e2e experiments (#1320)
* Bump detox

* Update detox

* Disable one test for now

* Bump detox

* Increase test timeouts

* Collect more logs

* Increase run timeout

* Comment

* Increase timeout

* Replace password autofill workaround

* Move workaround after launchApp

* Upgrade github actions workflows

* Forgot one action

* Update test.yml

* Testing concurrency

* Use concurrency for e2e as well

* Remove previous concurrency code

* Testing different Slack action

* Change slack msg

* Try different msg

* Revert "Try different msg"

This reverts commit ddaad331d1.

* Revert "Change slack msg"

This reverts commit 852204b074.

* Revert "Testing different Slack action"

This reverts commit fb072e65e3.

* Testing some more notify

* Testing notification

* Revert "Testing notification"

This reverts commit 974dfcb32f.

* Revert "Testing some more notify"

This reverts commit 39b3d668e2.
2024-03-28 23:41:40 +01:00
Angie
48db4580d0 Fix notifications indicator not going away after viewed obs (#1333) 2024-03-28 15:06:53 -07:00
Ken-ichi
f1f852a66b I18n source string validation and normalization (#1321)
* Added Fluent validation cmd; stubbed out normalize command
* Added source string normalization; removed numerous duplicate source strings
2024-03-28 14:56:06 -07:00
Amanda Bullington
4988f93ea7 Downgrade: new patch version causes build failure in Xcode 15 (#1332) 2024-03-28 14:19:36 -07:00
Amanda Bullington
55308a8be4 Upgrade packages with patch version bumps (#1331) 2024-03-28 13:17:19 -07:00
dependabot[bot]
caab099098 Bump nokogiri from 1.15.5 to 1.15.6 (#1330)
Bumps [nokogiri](https://github.com/sparklemotion/nokogiri) from 1.15.5 to 1.15.6.
- [Release notes](https://github.com/sparklemotion/nokogiri/releases)
- [Changelog](https://github.com/sparklemotion/nokogiri/blob/main/CHANGELOG.md)
- [Commits](https://github.com/sparklemotion/nokogiri/compare/v1.15.5...v1.15.6)

---
updated-dependencies:
- dependency-name: nokogiri
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-03-28 13:12:54 -07:00
Amanda Bullington
39515c59a1 Update packages related to dependabot (#1329) 2024-03-28 12:52:00 -07:00
dependabot[bot]
26c26cb4a7 Bump postcss from 8.4.23 to 8.4.38 (#1327)
Bumps [postcss](https://github.com/postcss/postcss) from 8.4.23 to 8.4.38.
- [Release notes](https://github.com/postcss/postcss/releases)
- [Changelog](https://github.com/postcss/postcss/blob/main/CHANGELOG.md)
- [Commits](https://github.com/postcss/postcss/compare/8.4.23...8.4.38)

---
updated-dependencies:
- dependency-name: postcss
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-03-28 12:51:46 -07:00
dependabot[bot]
efd4b493aa Bump sanitize-html from 2.11.0 to 2.12.1 (#1325)
Bumps [sanitize-html](https://github.com/apostrophecms/sanitize-html) from 2.11.0 to 2.12.1.
- [Changelog](https://github.com/apostrophecms/sanitize-html/blob/main/CHANGELOG.md)
- [Commits](https://github.com/apostrophecms/sanitize-html/compare/2.11.0...2.12.1)

---
updated-dependencies:
- dependency-name: sanitize-html
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-03-28 12:28:20 -07:00
dependabot[bot]
82324623a0 Bump axios from 0.27.2 to 0.28.0 (#1323)
Bumps [axios](https://github.com/axios/axios) from 0.27.2 to 0.28.0.
- [Release notes](https://github.com/axios/axios/releases)
- [Changelog](https://github.com/axios/axios/blob/v0.28.0/CHANGELOG.md)
- [Commits](https://github.com/axios/axios/compare/v0.27.2...v0.28.0)

---
updated-dependencies:
- dependency-name: axios
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-03-28 12:27:58 -07:00
Ken-ichi
8fb171f5c7 GitGuardian pre-commit hook (#1319)
* Basic GitGuardian pre-commit hook
* Run ggshield when available, otherwise fail for inaturalist.org git identities
* Removed unused pre-commit framework file; added GitGuardian config file
* Updated README
2024-03-27 16:57:20 -07:00
Angie
4b61a30946 Taxon detail map and taxon map screen (#1218)
* Taxon map preview, taxon detail map screen, moved DetailsMap to SharedComponents

* Fix typo, add comment for TODO

* Map shows observation tiles for Taxon, taxon range map zoom better

* Adjust padding for header text

* Several minor fixes

* disable interaction on TaxonDetails map
* disable SpeciesSeenCheckmark when signed out
* Remove x margin on TaxonDetails map
* Fix broken region calculation on TaxonDetails map
* Ensure TaxonDetails map uses same obs search params for bounds calculation
  and tiles

* DetailsMap updates

* Removed containers that weren't adding much logic
* Restyled ObsDetail map model per spec
* Disabled interaction for maps on TaxonDetails and ObsDetails (closes #1233)

* Fix Typos

---------

Co-authored-by: Ken-ichi Ueda <kenichi.ueda@gmail.com>
2024-03-27 16:22:47 -07:00
Angie
f37f92795b 1221 explore screen icons (#1308)
* Identifiers and Observers icons

* Add icons to explore bottomsheet
2024-03-27 16:21:56 -07:00
Amanda Bullington
4916e960c3 Show Suggestions after camera in ObsEdit flow (#1294)
* Navigate user to Suggestions after Camera; add location check to usePrepareStateForObsEdit function

* Test that Camera advances to Suggestions when checkmark tapped

* Use vision result as top suggestion on Suggestions screen

* Write AR nav test; filter vision result from all suggestions list

* Show LocationPermission on camera screen; navigate back from ObsEdit

* Updates to flow so user can back out of ObsEdit to cameras

* Fixes

* Add evidence to existing observation when backing out of ObsEdit flow

* Fix tests

* Add mocks for worklet functions

---------

Co-authored-by: Ken-ichi Ueda <kenichi.ueda@gmail.com>
2024-03-27 12:34:37 -07:00
Johannes Klein
072cf3d690 Refator overall padding to not apply for IconicTaxonChooser (#1317)
Closes #1298
2024-03-27 20:28:19 +01:00
Johannes Klein
e63ebf9147 1301 suggestions spacing (#1316)
* Make confidence indicator not absolute

Closes #1301

* Use flex for explore header taxon

Closes #1297
2024-03-27 20:27:58 +01:00
Ken-ichi Ueda
e5fb9a1aa8 Disable iOS e2e tests on PR and main push until we can figure out how to get it to work consistently 2024-03-27 11:12:04 -07:00
Johannes Klein
7e5a376394 Disable Android e2e except for workflow_dispatch (#1318) 2024-03-27 11:11:53 -07:00
Amanda Bullington
b284bb2b9e Explore filters and navigation entry points (#1306)
* Add test for UserProfile species button from MyObs screen

* Finish initial tests for navigating to Explore from MyObs

* Check API calls are made with correct params

* Use RootExplore screen in CustomTabBar and write test for navigating cyclical Explore -> TaxonDetails

* Add navigation check for UserProfile from root explore screen

* Simplify RootExplore screen; show nearby data for species view

* Mock location permissions for Explore navigation tests

* Update snapshot

* Merge from main

* Fix tests for Explore navigation
2024-03-26 16:59:59 -07:00
Amanda Bullington
408115bec0 Fix nav to Notifications by including ObsStackNavigator; closes #1252 (#1315) 2024-03-26 16:59:43 -07:00
Johannes Klein
0e0a6560ac Vision camera v3 (#1121)
* Bump vision-camera

* Refactor patch

* Move patched orientation into patch functions file

* Update react-native-vision-camera+3.4.1.patch

* Switch to MacOS 13 runner

Vision camera requires XCode 15 to compile.

* Add step to specify XCode 15

* Higher level of logging

* Increase test timeout

* Add comment

* Remove navigation to obs without evidence for signed out user

* Patch for location permission not working on iOS

* Increase setup timeout

* Increase some more timeouts

* Revert back to less logging in CI

* Does it have to do with timeouts?

* Trace log level

* Update README.md

* Disable Homebrew’s auto update and install cleanup

* Setup ruby step

* Install pods only if not cached

* Revert "Install pods only if not cached"

This reverts commit 42a2ea02f9.

* Run simulator in headless mode, record all logs

* Increase timeouts again

* Revert "Remove navigation to obs without evidence for signed out user"

This reverts commit 2b4718f5ce.

* Add boolean to run use effect only once

* Did merge wrong code

* There is one more permission gate when entering obs edit now

* Add permission gate dismissal to signed out user test

* Add comment, rename state

* Lower action timeout

* Update react-native-vision-camera to 3.6, update Reanimated to v3 (#838)

* Bump camera and plugin

* Upgrade Reanimated and libs using it

* Update vision-camera mock

* Remove superfluous patch

* Fix type

* Add mocks for e2e tests because bottom sheet does not work on AOSP

* Update package-lock.json

* Update vision camera

* Bump vision camera

* Update vision camera patch version

* Remove superfluous patch

* Update vision camera

* Update vision-camera and plugin

* Use latest vision plugin = rebased v3

* Run npm clean-start

* No longer needed

* Duplicate prop

* Switch back to v3 code

* Upgrading Detox fixes issue with iOS tests failing

Because of previous lack of permissions.

* Update to latest detox version

* Npm i force

* Vision 3 e2e testing, (#1126)

* Remove jest detox config

* Revert e2e timeout increase

* Revert jest config timeout

* Use macos 14 runner which has XCode 15 per default

* Use latest bottom sheet

* Revert "Use latest bottom sheet"

This reverts commit c66cd09838.

* Adding comma back in

* Remove spaces

* Use latest vision-camera and plugin

* Use release version of vision-camera

* Remove force flag

* Update react-native-worklets-core

* Upgrade reanimated

* Update babel.config to allow nested worklets

* Run frame processor async

* Remove enableGpuBuffers flag

* Remove no longer needed comment

* Update comments about version

* Update vision-camera and plugin

* Code format

* Rename param

* Use latest-plugin

* Remove fps param from camera view

* Change confidenceThreshold to number

* API change for results structure

* Refactor fps to be checked inside hook

As of vision-camera 3.9.1 our camera feed is stuttering when calling the runAtTargetFps function inside the useFrameProcessor hook.
So, what I did here is to track the time and skip the frames that are received before the target fps is reached.

* Remove updates of non-camera related

* Update comment

* Code format

* Snapshot updates

* Revert changes to ios e2e

* Add a log for the average time it takes a frame to be processed

* Use release version of plugin

* Add a patch for runAsync to work in release builds

* Update react-native-worklets-core to 0.4.0

* Use latest plugin version

* Add a shift method to worklet arrays

* Use latest vision-plugin

This makes use of .shift() in worklet array and depends on the previous patch.

* Set result timestamp and show age of result in debug mode

* Fix an error with timestamp being undefined

* Remove log

* Use latest vision plugin

* Change result timestamp to pink

* Comment

---------

Co-authored-by: Ken-ichi Ueda <kenichi.ueda@gmail.com>
2024-03-27 00:47:43 +01:00
Ken-ichi Ueda
b397d0d4f5 Android e2e tests were failing when obs deleted status disappeared too quickly 2024-03-26 15:19:40 -07:00
Ken-ichi
2af42cfb3a Several changes to recent font updates (#1296)
* Restore Whitney Book as default font so <Text> isn't bold by default
* Refactor a function that fetches a class name to simply be a memoized
  string
* Simplified some italicization logic in <ScientificName>
* Fixed bug where higher rank species names were rendered as an illegible gray
  in ObsGridItem
2024-03-26 12:53:18 -07:00
Ken-ichi Ueda
628e2e03d2 Several minor fixes
* Show Explore view bottom sheet when HeaderCount tapped
* Fix ObsDetails crash when obs has no faves or obs POJO passed in
* End padding for description on ObsEdit
* Bottom padding for bottom sheets on devices w/ inset (e.g. no home button)
* Subheading1 is apparently supposed to be Whitney Book
* Second line of taxon name on TaxonDetail should be Subheading1
2024-03-25 18:18:38 -07:00
Ken-ichi Ueda
dccf37ba6b Minor margin fix for the too much evidence alert 2024-03-25 11:23:46 -07:00
budowski
9ccd138f88 Allow adding sounds to existing observations (#1303) 2024-03-25 11:02:29 -07:00
Ken-ichi
97fd4f2874 Try to catch and log errors during upload (#1283)
* Try to catch and log errors during upload
* Wraps some upload async methods with try/catch to attempt to log some
  potential bugs
* Adjusts upload param mappings
* Try to get upload status to more accurately reflect the upload state
* Consistent upload success messaging after single upload
2024-03-22 19:17:45 -07:00
Johannes Klein
5553719a2f Community Taxon improvement DQA (#1291)
* Restyle community taxon section

* Use fave/unfave mutation in case of need_id metric

* Add votes field to Observation

* Change useIsConnected to TS

* Refactor fetching of remote observation into hook

Also includes the code to update local copy of a user's own observation

* Use const as key instead of string

* Remove unused prop

* Only send obs uuid to DQA

* Get obs in DQA container

* Rebuild object that is to check as it was send in nav params

* Refactor qualityGrade

* Refactor set to not loading state

* Update test to reflect fetching of obs

* Refactor too long lines

* Refetch remote observation after success in adding/removing vote

* Change qualitcMetrics to make use of observation.votes as well

Also refactored the object structure to use more efficient and performant filtering and finding in child components.

* Only use data slice for DQA buttons

* Refactor DQAButtons to only work with data slice relevant to that metric

* Special case for needs_id metric

* Also show loading indicator when fetching remote obs

* Add TODO

* Check only for vote of this user

* Optional chaining for user id

* Update test

* Enable fetching of remote if local is falsy

* Invalidate query on mutation

* Only set loading to false after refetch is finished

* Split up DQA test into unit tests and integration tests

* Use factory for mock user

* Add needs_id DQAVoteButtons unit test

* Revert hook to js

* Check for observation before using it

* Undo code style changes

* Remove unused value

* Refactor faves to be derived from votes

* Refactor needs_id interaction into standalone fcts

* Code style
2024-03-22 21:57:28 +01:00
Johannes Klein
f70e1fadfe Margin to DQA bottom
Closes #1278
2024-03-22 10:18:14 +01:00
Ken-ichi Ueda
000e8662dd v0.28.0+80 v0.28.0+80 2024-03-21 16:28:24 -07:00
Ken-ichi Ueda
aec9375cca v0.28.0 2024-03-21 16:27:28 -07:00
Ken-ichi Ueda
04b67febb3 Bugfix: could not unset hrank or lrank w/o triggering API error 2024-03-21 15:11:14 -07:00
Ken-ichi Ueda
e4b1e1bcf0 Fix size of NumberBadge 2024-03-21 14:43:44 -07:00
Angie
822909b002 1279 user profile UI changes for mvp (#1295)
* Follow Button changes

* Change non pressable count icons to gray, removed onPress, hide post mvp sections of userprofile

* createRelationships api call, follow/unfollow functionality

* Unfollow and follow button functionality, refactoring
2024-03-21 09:56:27 -07:00
Ken-ichi
f510a46011 iOS splash screen w/ image (#1292) 2024-03-20 17:16:59 -07:00
Ken-ichi
9ec8448b17 Use text in iOS share dialog to add observation description (#1293) 2024-03-20 16:46:32 -07:00
Johannes Klein
836c01d35a Reset toolbar success state after five seconds (#1290)
* Add timeout that resets upload state after 5s

* Add timeout that resets deletions state after 5s

* Only reset state on no error state
2024-03-19 16:43:43 +01:00
Johannes Klein
63a636937d Explore header UI changes (#1289)
* Refactor NumberBadge

* Restyle filter modal icon based on number of filters

* Refactor colors

* Do not show border and padding if TaxonResult is not in a list

* Add conditional render of info button in TaxonResult

* Restyle explore header

Removes the taxon search function and list of results from the header. Also removes unused explore state and props.

* Wrap Explore in View to hide shadow on top
2024-03-19 13:23:38 +01:00
Ken-ichi Ueda
6eebe0289c Updated Fastlane beta lane to add existing builds to beta groups (#1253) 2024-03-18 17:40:19 -07:00
Ken-ichi Ueda
14a234788d v0.27.0+79 v0.27.0+79 2024-03-18 14:09:40 -07:00
Ken-ichi Ueda
eabbbbddcc Remove alpha channel from all iOS app icon files, which apparently the App Store requires 2024-03-18 14:08:22 -07:00
Ken-ichi Ueda
2d51e6a2cf v0.27.0+78 v0.27.0+78 2024-03-18 13:46:34 -07:00
Ken-ichi Ueda
ca2448ace9 v0.27.0+77 2024-03-18 13:46:13 -07:00
Ken-ichi Ueda
e167d5fa6b Attempt to add a beta release lane 2024-03-18 13:46:13 -07:00
Ken-ichi
c0bd48c19f Allow single observation deletion when editing multiple (#1285) 2024-03-18 09:33:12 -07:00