Commit Graph

4199 Commits

Author SHA1 Message Date
Johannes Klein
df441be337 Camera v2 photo orientation fix for iPhone (#926)
* Revert to version 2 constants naming

* Update visionCameraPatches.js
2023-11-22 16:02:37 +01:00
Angie Ta
d18b30256c Add back ObsStatus to ObsGridItem and tests 2023-11-21 17:23:40 -08:00
Ken-ichi Ueda
21f1f3690b v0.17.0+63 v0.17.0+63 2023-11-20 18:49:16 -08:00
Ken-ichi Ueda
3f7035194c v0.17.0 2023-11-20 18:48:19 -08:00
Ken-ichi Ueda
3bedb5033c Updated to fastlane 2.217.0 2023-11-20 18:47:27 -08:00
Ken-ichi Ueda
5124557d0d Change default Explore params to something more like the web 2023-11-20 18:45:12 -08:00
Ken-ichi Ueda
e162feaf74 Bugfix: edit button was not showing for your own obs downloaded on MyObs 2023-11-20 18:44:42 -08:00
Ken-ichi Ueda
1b415b6727 Bugfix: iPad landscape wasn't showing all pics in StandardCamera delete mode 2023-11-20 16:24:50 -08:00
Ken-ichi
6af81365d8 Restore tap-to-focus by reverting to react-native-vision-camera v2 (#923) 2023-11-20 14:49:30 -08:00
Ken-ichi Ueda
38e75d3cdf Remove some unecessary react-navigation mocks 2023-11-20 11:09:36 -08:00
Angie
ab00dd8f43 Merge pull request #920 from inaturalist/852-observations-show-upload-button-and-incorrect-no-photos-icon-on-explore
852 observations show upload button and incorrect no photos icon on explore
2023-11-17 16:07:22 -08:00
Amanda Bullington
361ad1d1f5 Performance: simplify ObsEditProvider (#908)
* Simplify ObsEditProvider by moving functions into local state & calling reducer less frequently

* Fix delete all observations

* Fixes

* Move index selection to MediaViewer via params

* Access ObsEditContext on top level of ObsEdit and pass props

* Move context to top level screen components

* Fix tests

* Use waitFor to fix ObsDetails integration test

* Alphabetize props; remove realm check; refactor new Id method

---------

Co-authored-by: Ken-ichi Ueda <kenichi.ueda@gmail.com>
2023-11-17 12:35:29 -08:00
Amanda Bullington
7029b30f5b Kebab menu with share option on other users' observations (#915)
* Show kebab menu with share option & link to web observation; closes #884

* Added HeaderKebabMenu tests

* Test fix
2023-11-17 11:15:02 -08:00
Amanda Bullington
35f48547c3 Show observed_at date, not created_at date, on ObsDetail; closes #916 (#919) 2023-11-17 11:14:44 -08:00
Angie Ta
b53a26b8e5 Merge branch 'main' into 852-observations-show-upload-button-and-incorrect-no-photos-icon-on-explore 2023-11-16 19:46:46 -08:00
Angie Ta
85be8dd964 Remove upload and no photos icon in explore observations grid, list and species grid 2023-11-16 18:46:04 -08:00
Ken-ichi Ueda
7fe1f6472b Minor UI changes in response to feedback
* Changed help text when choosing an obs location
* Potentially support an Apple-style share icon on DetailsMap
* Update UI immediately when faving or unfaving instead of waiting for the
  server to respond
* Added a loading indicator to the blank PhotoGallery screen
* Changed notes-editing bottom sheet button from CONFIRM to DONE
2023-11-16 18:16:51 -08:00
Ken-ichi
3f83925774 Photos cant be deleted from camera preview (#910)
Separated PhotoCarousel view and delete into separate buttons

Fixes #837 by separating the two separate press interactions into two separate
buttons, which is probably also better for accessibility (screen reader can
read two separate labels for two separate actions). Also addresses a layout
bug in landscape on iPad.

Also *might* introduce a bug with orientation lock reverting when rotating
device while in delete mode. Only happens in Android, may not be new
2023-11-16 10:05:14 -08:00
Ken-ichi
3c2a43665d Ensure suggestions change when photos change (closes #854) (#909) 2023-11-16 09:50:32 -08:00
Angie Ta
e55c199d1b Merge branch 'main' into 852-observations-show-upload-button-and-incorrect-no-photos-icon-on-explore 2023-11-15 18:32:52 -08:00
Ken-ichi Ueda
f6592c768d Added Explore test to look for correct status 2023-11-15 17:45:00 -08:00
Amanda Bullington
7d55a7b018 Fix broken Explore screen 2023-11-15 16:47:25 -08:00
Amanda Bullington
7de3790230 Performance: move upload reducer out of ObsEditProvider into MyObservationsContainer (#879)
* Move upload functionality into MyObservations, out of ObsEditProvider

* Move upload into helper function

* Fixes for ObsEdit -> MyObs flow

* Progress on making uploads faster

* Update performance test

* Fix toolbar progress

* Fix tests for observation upload flow

* Fixes from code review; fix e2e test for signed in user by bypassing permission gate

* Hide sign up test when keyboard visible; fixes Android e2e test

* Comment out permissions code in e2e test to see if it's only needed locally

* Comment out permissions gate for signed out user iOS

* Use focused hook to stop ObsEdit from rerendering while user is on other screens

* Restore reassure in branch

* e2e code cleanup
2023-11-15 11:40:11 -08:00
Ken-ichi Ueda
3c08edbe61 Added unnecessary iOS permission text
The App Store complained about missing this permission the last time we
submitted a build, even though we never request it. I added it to supress
that warning, but used text to make it clear the user should not be seeing
it.
2023-11-15 11:00:04 -08:00
Angie
5f1afd8e7d Merge pull request #906 from inaturalist/activity-item-kebabmenu-sheets
Activity item withdraw id sheet and kebabmenu component
2023-11-14 19:40:41 -08:00
Angie Ta
22a5c45393 update strings in test file 2023-11-14 18:02:02 -08:00
Angie Ta
26d87aef78 string change in test file 2023-11-14 16:39:33 -08:00
Angie Ta
22ae67f6b9 changed titles of bottomsheets to match designs 2023-11-14 16:13:47 -08:00
Angie Ta
f4eb5388f4 Updated strings, removed kebab menu for non current user activityitem 2023-11-14 00:03:34 -08:00
Angie Ta
5305ddd8a3 Merge branch 'main' into activity-item-kebabmenu-sheets 2023-11-13 23:04:56 -08:00
Angie Ta
a96d1cc9c6 New files 2023-11-13 22:58:19 -08:00
Angie Ta
2983e05a08 ActivityHeaderKebabMenu component, removed flag functionality, WithdrawIDSheet component and tests 2023-11-13 22:49:16 -08:00
Johannes Klein
cedaa68fcd Small UI changes (#903)
* Swap places in Explore segmented button

* Remove identify button from Explore

* Remove explanation text for no activity items
2023-11-13 16:17:41 +01:00
Ken-ichi Ueda
4307ee829e v0.16.0+62 v0.16.0+62 2023-11-10 23:12:11 -05:00
Ken-ichi Ueda
d5876556cb v0.16.0 2023-11-10 23:11:19 -05:00
budowski
940d9c20b1 #781 - Group photos - implement the add button - calling native photo picker (#878) 2023-11-10 14:17:22 -05:00
Ken-ichi Ueda
b31ffc5690 Reassure shell script should be executable 2023-11-09 17:16:09 -05:00
Ken-ichi Ueda
7e7773eff3 Moved developer-focused content into a developer stack navigator
* New Developer stack navigator and screen
* New logs screen
* Moved log reading and sharing into a hook
* Commented out drawer items that take you to placeholder screens
* Fixed back button placement on some screens
2023-11-09 17:12:53 -05:00
Ken-ichi Ueda
33062d2d0c IconicTaxon chooser removes taxon when unknown is selected
As opposed to adding the Life taxon, which should almost never be used in an
identification unless you need to disagree with a kingdom. Per Slack conv w/
Abhas:
https://inaturalist.slack.com/archives/C02G5AATVGA/p1699402467492729?thread_ts=1699288543.440449&cid=C02G5AATVGA
2023-11-09 17:12:53 -05:00
Amanda Bullington
5d45b21570 Performance testing with Reassure (#867)
* Performance test with reassure, danger/CI integration set up

* Remove log

* Fix script location in github actions test

* Run performance tests before regular tests

* Move script

* Make script findable and executable

* Find scripts directory

* Find scripts directory

* Find scripts directory

* Give permission

* Comment out performance test CI

* Remove danger/CI and update naming

* Remove danger from package.json
2023-11-09 09:50:22 -08:00
Ken-ichi
f8c370394d Bugfix: ObsEdit was blank after importing several photos (#868)
The problem seemed to be reverse geocoding the coordinates for each
observation before moving on to ObsEdit, i.e. when that threw an exception it
kind of silently cause Promise.all not to resolve... which is not supposed to
happen for a few reasons, foremost among them that we were catching the error
and returning null instead. So I'm still confused about why exactly this was
happening.

Regardless, geocoding is potentially slow and buggy, so IMO it's better to do
it on ObsEdit than in the provider, and only do it when we need it, i.e. when
the user is actually looking at the obs.

Some other minor changes

* Show loading indicator on GroupPhotos button while creating obs
* fetchPlaceName performs a null check on coords before making a network
  request to test connectivity
* More precise error handling
* Removed some redundant await statements
* Mocked react-native-geocoder-reborn in tests

Closes #857
2023-11-08 10:29:46 -05:00
Ken-ichi Ueda
6ac95e4782 Remove unnecessary wipe of state on blur in TaxonSearch
This was removing the search results when returning from Taxon Detail. Without
it, I think React Navigation is unmounting the component when you go back
from it in the stack, which achieves what I think we want.
2023-11-07 11:27:01 -05:00
Ken-ichi Ueda
516f03c05e Style fix for back button on GroupPhotos 2023-11-06 20:47:34 -05:00
budowski
3c6f453bf3 Native image picker (#828)
Uses a fork of
https://github.com/react-native-image-picker/react-native-image-picker that
forces an old-style Android native photo picker to ensure we get all the
photo metadata we need. Closes #431 and closes #569

---------

Co-authored-by: Ken-ichi Ueda <kenichi.ueda@gmail.com>
2023-11-06 19:41:09 -05:00
Amanda Bullington
1d9adb0f51 More performance improvements (#845)
* Remove console statements in production build

* Move uploadReducer into separate file

* Create reducer for creating obs; combine reducers

* Fixes with createObsReducer

* Move album, passes test states out of global context

* Bug fixes for ObsEdit flow

* Create photo gallery container

* Set accessibility test todo for PhotoGallery

* Improve FlashList performance MyObs

* Prevent flicker on modal close

* Create less rerenders in MyObservations

* Memoize drawer items for less rerendering

* Memoize custom tab bar

* Remove unused libraries and update snapshot

* Fix and prune dependencies

* Add AddObsModal tests

* Fix e2e test android by making comment confirm button visible

* Use callbacks and memoization to cause less rerenders

* Fix tests

* Remove unused code

* Remove log

* Minimize calls to check whether internet is reachable

* Remove unused code
2023-11-06 12:24:31 -08:00
Ken-ichi Ueda
13d2df9a0d Updated README to help troubleshoot running e2e when you don't have the right simulator 2023-11-06 11:22:36 -05:00
Ken-ichi Ueda
8f9b417d0b See if capitalizing Friends actually sends the build to that group 2023-11-06 11:11:28 -05:00
Ken-ichi Ueda
c4f8551be8 v0.15.0+61 v0.15.0+61 2023-11-03 17:36:32 -04:00
Ken-ichi Ueda
5dfae51248 v0.15.0 2023-11-03 17:34:11 -04:00
Ken-ichi
05eb33613b Cover camera ipad rotation (#846)
* Use cover instead of contain for camera view; reposition rotated view for iPad
* Bugfix: focus square was disappearing after rotation
2023-11-03 16:58:07 -04:00