FYI, this also essentially outlaws variables in translation keys because a key
that is only used with interpolated strings will never appear as "used".
Also starts using a convention of adding info to i18n keys that do not relate
to the text after double dashes, e.g. `Unknown--taxon = Unknown` for a string
that is specifically meant to describe a missing taxon but only needs to have
the word "Unknown".
* Changed several accessibilityHints to 3rd person
* Made several accessibilityLabels shorter and more verb-oriented
* Removed many unused i18n keys
* Refactored variables in i18n keys
* Removed some unused code from the old Settings
* Add DateDisplay to ObsCard and make first pass at translation strings
* Add failing tests (due to lack of localization) for timeless dates
* WIP: trying to ensure i18next gets initialized before tests run
The remaining test failures might be legit. This probably breaks the actual
app, though.
* Got the rest of the tests working
* Updated tests to assume UTC
* Updated README to advise against using `npx jest` so test runs always have
the env vars we specify in our `npm test` script
* Moved i18next initialization to an explicitly-named file
* Use i18next init function in app
* Fixed up remaining tests
* Added test for non-English localization of date format
* Cleanup
* Made DateDisplay explicitly handle strings not Dates
* Restore skipped localization tests for MyObservations
* Remove duplicative tests from DateDisplay unit test
* Added note to the README about initializing i18next
* Updated change to DateDisplay in main
---------
Co-authored-by: Ken-ichi Ueda <kenichi.ueda@gmail.com>
* Format exif date as string for upload; remove unused code for handling evidence upload errors; closes#311
* Fix tests; add a new test to check for string formatting
* Fix exif test
* Make sure camera/no evidence still create a new observed_on_string
* Fix failing test with observed_on_string in fake LocalObs; closes#259
* Parse date into local timezone
* #144 - when creating new observation, import first photo EXIF data for location + date
* #144 - usePhotoExif - read partial file data; added testing for usePhotoExif hook
* #144 - import photo exif - use our own react-native-exif-reader library + other fixes (not to automatically fetch location, save original uri)
* Do not save original photo URI in DB, only pass it along to obs edit screen for EXIF parsing
* Upgraded testing library version to support renderHook
Co-authored-by: Ken-ichi Ueda <kenichi.ueda@gmail.com>
These rules are largely based on the AirBnB ones, which are not quite standard
for the React Native world, where Prettier seems to be more common, but I
think they add a lot of useful checks, and unlike Prettier we can customize
them. This also just makes it easier for people on the iNat team to work on
the mobile app.
Some specific changes:
* Added eslint-plugin-react-hooks to eslint rules
* Added eslint-plugin-simple-import-sort to eslint rules
* Bugfix: could not import photo from gallery
* Added support for react-native/no-inline-styles eslint rule
* useUser should not bother fetching a user for a blank userId
* Adds a component for adding identifications, both from Obs Detail and Obs Edit
* Minor style and eslint change to disallow all-caps string literals
Closes#103
Co-authored-by: Ken-ichi Ueda <kenichi.ueda@gmail.com>
* Create basic media viewer with full sized image, selection, carousel, and header
* Create photo delete dialog component
* Wrap camera stack in Mortal component instead of resetting state on camera blur
* Use photo carousel in PhotoPreview for standardized photo sizes
* Make media viewer accessible from ObsEdit
* Remove evidencelist component and use photo carousel instead in ObsEdit/suggestions
* code tweaks
* Create realm ObsPhotos in standard camera for passing to media viewer, ObsEdit
* Move resize image function into Photo model
* Update photo preview to use delete photo functions from photo and obsphoto model
* Allow photo deletion in media viewer from ObsEdit, StandardCamera; switch to Modal view
* Swap in zoom functionality instead of carousel, media viewer
* Remove media viewer from nav, now that it's a modal
* Remove comment
* Update babel config with react-native-paper plugin for production
* Mock RN paper Portal component
* Media viewer takes photo uris; handles obsPhoto updates in ObsEdit and photo uri updates in StandardCamera
* Make sure tests pass with optional chaining for obsPhotos
* Update styling for StandardCamera
* Create obsPhotos attached to photos from camera
* Pass photos to StandardCamera from ObsEdit to reflect any changes made in MediaViewer
* Get tests passing
* Fix flow issues
* Change flow type for photoUris
* Add pre-commit hook for flow
* Fix flow erros
* Break uploader into helper function; add bottom model for uploading from obs list
* Create mapping function for uploading observations to iNat
* Mark observations as uploaded when id is returned from server
* Format dates on obs list
* Save all obs locally before trying to upload
* Resize grouped photo gallery photos for upload
* Resize photos btw group photos screen and obs edit
* Get sound, photo, obs uploads saving to realm and uploading later
* ObsEdit progresses to next or prev screen after one obs is saved locally
* Format date in camera; use time observed to show new local obs in ObsList
* Remove time zone attribute, since this is handled by server
* Submit sound and photo uuids as the file name for sound/photo uploads
* Make obsSounds an array in case there are multiple sounds for upload
* Removing time synced from Photo model bc not sure it's necessary
* Save _synced_at and _created_at time for all remote obs
* Fix back button, obs edit
* Don't show obs edit for unuploaded obs
* Get rid of ObservationProvider, move useObservations hook
* Fix place name; add date/time and location to no evidence uploads
* Add species_guess to observation when taxon_id changes
* Format date from picker; use string for sending to server
* Styling cleanup with react-native-paper; make ObsEdit into section components
* Add vector icons to ios (for searchbar)
* Add empty text to CV suggestions
* Cleanup code for marking records synced & uploading to server
* Use placeholder icons on bottom tab bar
* Add icons to ObsList; fix grid view when photo === null
* Fix jest tests
* Simplify setting an identification in ObsEdit
* Move inline styles to separate files
* Display all relevant saved obs data on ObsDetails; function to check for camel or snake case attributes
* Move logic for creating new sound observation to model, not sound recorder
* Add android vector icons
* Move create obs and create with no evidence into Observation model
* Add mock for react-native-fs
* Show option to edit user obs in ObsDetail; fix captive/geoprivacy/date fields for uploaded obs
* Move obsPhoto creation and obs with obsPhoto creation into models
* Create obs with sound from Obs model
* Create multiple obs from gallery photos; move logic into model
* Pass observation to ObsDetails via navigation to avoid opening and closing realm twice
* Lint error fixes
* Fix jest tests
* Use icons on normal camera
* Use timestamps from gallery and camera for new observations
* Keep simplifying code
* Update version/build number; add key to info.plist for faster ios build
* Remove TranslatedHeadline component
* Move saveLocalObservation logic to model
* Move all FIELDS for api calls into models (except messages, which doesn't have a model yet)
* Only show upload UI if user is logged in
* Fix obs edit link so it works for both logged in and logged out users
* Bug fixes: get fields from models; addListener function in test
* Model code cleanup
* More code cleanup
* Remove unused imports
* Add to user profile
* Create a hook to fetch member projects
* Create custom header for user profile
* Updates to user profile; resize image for CV suggestions; build config for Android
* Bug fixes with obs list & CV suggestion fields
* Add functions for creating id, faving obs and adding comment in obsdetail
* Show comments as activity items; create comments and refetch obs data
* Fix activity item keys
* Add data to data tab, obs detail
* Let user unfave observation
* Fix camera modal
* Get tests passing
* Add gallery library; hide camera stack in drawer navigation since we can't use a tab navigator
* Add gallery permissions ios and android
* Move to obs edit screen when a photo is selected from gallery
* Make sure camera options modal closes on navigate
* Create shared hook for reverse geocoded locations
* Obs edit; dismiss keyboard; uuid generator
* Use popup modal to search for projects / taxa from obs edit & add to obs
* Obs edit updates
* Add i18next mock for global testing
* Add tests for photo gallery
* Add test for obs edit
* Get album picker working and store albums + photos in ObsEditProvider
* Maintain photo selection across multiple photo albums
* Create GroupPhotos screen with photos sorted by timestamp across all albums
* Add styling for group photos
* Pseudocode for grouping photos
* Combine photos into observations in photo gallery
* Remove photos from camera roll selection on group photos screen
* Fix remove photos function
* Finish combine, separate, remove photo functionality
* Display multiple obs and multiple photos on obs edit screen
* Code cleanup
* Code cleanup again
* Show number observation at top of obs edit screen
* Update navigation
* Get one photo gallery test passing
* Fix obs edit test
* Fix warning eslint
* Make tests happy
* Remove unused variable
