From 1aca90a810aaeb26b60a67a9271e2f329da0a5c7 Mon Sep 17 00:00:00 2001
From: tangweikun <819573105@qq.com>
Date: Thu, 23 Jun 2022 21:12:59 +0800
Subject: [PATCH] Fix timeout setting in milliseconds (#4881)

* feat: make NumberSetting support step

* fix: correct request timeout help message

* make default step 1 for NumberInput

* Provide similar experience for other inputs with ms

Co-authored-by: tangweikun <tangweikun@corp.netease.com>
Co-authored-by: gatzjames <jamesgatzos@gmail.com>
---
 .../insomnia/src/ui/components/settings/general.tsx    | 10 ++++++----
 .../src/ui/components/settings/number-setting.tsx      |  3 +++
 2 files changed, 9 insertions(+), 4 deletions(-)

diff --git a/packages/insomnia/src/ui/components/settings/general.tsx b/packages/insomnia/src/ui/components/settings/general.tsx
index 7fba48996c..5c5434916b 100644
--- a/packages/insomnia/src/ui/components/settings/general.tsx
+++ b/packages/insomnia/src/ui/components/settings/general.tsx
@@ -138,11 +138,12 @@ export const General: FC = () => {
         />
 
         <NumberSetting
-          label="Autocomplete popup delay"
+          label="Autocomplete popup delay (ms)"
           setting="autocompleteDelay"
           help="Delay the autocomplete popup by milliseconds. Enter 0 to disable the autocomplete delay."
           min={0}
           max={3000}
+          step={100}
         />
       </div>
 
@@ -286,10 +287,11 @@ export const General: FC = () => {
           min={-1}
         />
         <NumberSetting
-          label="Request timeout"
+          label="Request timeout (ms)"
           setting="timeout"
-          help="Enter the maximum seconds allotted before a request will timeout. Enter -1 to disable timeouts. "
-          min={-1}
+          help="Enter the maximum milliseconds allotted before a request will timeout. Enter 0 to disable timeouts. "
+          min={0}
+          step={100}
         />
       </div>
 
diff --git a/packages/insomnia/src/ui/components/settings/number-setting.tsx b/packages/insomnia/src/ui/components/settings/number-setting.tsx
index 4234015ca2..9c7ae62cca 100644
--- a/packages/insomnia/src/ui/components/settings/number-setting.tsx
+++ b/packages/insomnia/src/ui/components/settings/number-setting.tsx
@@ -13,6 +13,7 @@ interface Props {
   max?: InputHTMLAttributes<HTMLInputElement>['max'];
   min: InputHTMLAttributes<HTMLInputElement>['min'];
   setting: SettingsOfType<number>;
+  step?: InputHTMLAttributes<HTMLInputElement>['step'];
 }
 
 export const NumberSetting: FC<Props> = ({
@@ -21,6 +22,7 @@ export const NumberSetting: FC<Props> = ({
   max,
   min,
   setting,
+  step = 1,
 }) => {
   const settings = useSelector(selectSettings);
 
@@ -54,6 +56,7 @@ export const NumberSetting: FC<Props> = ({
           name={setting}
           onChange={handleOnChange}
           type={'number'}
+          step={step}
         />
       </label>
     </div>