diff --git a/.eslintrc.js b/.eslintrc.js index 12b361761c..2e0c0fc18e 100644 --- a/.eslintrc.js +++ b/.eslintrc.js @@ -97,6 +97,16 @@ module.exports = { 'react/jsx-indent': ['error', 2], 'react/jsx-indent-props': ['error', 2], 'react/prop-types': 'off', + 'react/function-component-definition': ['error', { + 'namedComponents': 'arrow-function', + 'unnamedComponents': 'arrow-function', + }], + 'react/jsx-max-props-per-line': ['error', { 'maximum': 1, 'when': 'multiline' }], + 'react/jsx-closing-bracket-location': ['error', 'line-aligned'], + 'react/prefer-stateless-function': 'warn', // TODO: fix this and change to error + 'react/jsx-key': ['error', { 'checkFragmentShorthand': true }], + 'react/no-array-index-key': 'warn', + 'react/self-closing-comp': 'error', 'react-hooks/exhaustive-deps': 'error', 'react-hooks/rules-of-hooks': 'error', diff --git a/packages/insomnia-app/app/ui/components/analytics.tsx b/packages/insomnia-app/app/ui/components/analytics.tsx index bef190f38c..8b29d8b300 100644 --- a/packages/insomnia-app/app/ui/components/analytics.tsx +++ b/packages/insomnia-app/app/ui/components/analytics.tsx @@ -48,13 +48,15 @@ class Analytics extends PureComponent { radius="3px" size="medium" variant="contained" - onClick={this._handleClickEnableAnalytics}> + onClick={this._handleClickEnableAnalytics} + > Share Usage Analytics diff --git a/packages/insomnia-app/app/ui/components/base/dropdown/dropdown.tsx b/packages/insomnia-app/app/ui/components/base/dropdown/dropdown.tsx index d3d570b487..96b5228c5c 100644 --- a/packages/insomnia-app/app/ui/components/base/dropdown/dropdown.tsx +++ b/packages/insomnia-app/app/ui/components/base/dropdown/dropdown.tsx @@ -381,7 +381,8 @@ class Dropdown extends PureComponent { className={classnames({ active, hide, - })}> + })} + > {child} , ); @@ -412,7 +413,8 @@ class Dropdown extends PureComponent {
+ aria-hidden={!open} + >
{ tabIndex={-1} className={classnames('dropdown__list', { 'dropdown__list--filtering': filterVisible, - })}> + })} + >
{
    + })} + > {dropdownItems}
@@ -453,7 +457,8 @@ class Dropdown extends PureComponent { ref={this._setRef} onClick={this._handleClick} tabIndex={-1} - onMouseDown={Dropdown._handleMouseDown}> + onMouseDown={Dropdown._handleMouseDown} + > {finalChildren}
diff --git a/packages/insomnia-app/app/ui/components/base/modal.tsx b/packages/insomnia-app/app/ui/components/base/modal.tsx index a4d902e01f..1418ac832c 100644 --- a/packages/insomnia-app/app/ui/components/base/modal.tsx +++ b/packages/insomnia-app/app/ui/components/base/modal.tsx @@ -178,7 +178,8 @@ class Modal extends PureComponent { className={classes} style={styles} aria-hidden={!open} - onClick={this._handleClick}> + onClick={this._handleClick} + >
diff --git a/packages/insomnia-app/app/ui/components/buttons/settings-button.tsx b/packages/insomnia-app/app/ui/components/buttons/settings-button.tsx index 32504f7b14..426c829e3d 100644 --- a/packages/insomnia-app/app/ui/components/buttons/settings-button.tsx +++ b/packages/insomnia-app/app/ui/components/buttons/settings-button.tsx @@ -22,7 +22,8 @@ const SettingsButton: FunctionComponent = ({ className, settings }) => ( Preferences ( ) - }> + } + > diff --git a/packages/insomnia-app/app/ui/components/codemirror/code-editor.tsx b/packages/insomnia-app/app/ui/components/codemirror/code-editor.tsx index fbbd67b05b..c9804abf1a 100644 --- a/packages/insomnia-app/app/ui/components/codemirror/code-editor.tsx +++ b/packages/insomnia-app/app/ui/components/codemirror/code-editor.tsx @@ -1205,7 +1205,8 @@ class CodeEditor extends Component { key="prettify" className="btn btn--compact" title="Auto-format request body whitespace" - onClick={this._handleBeautify}> + onClick={this._handleBeautify} + > Beautify {contentTypeName} , ); @@ -1233,7 +1234,8 @@ class CodeEditor extends Component { className={classnames('editor__container', 'input', className)} style={styles} onClick={onClick} - onMouseLeave={onMouseLeave}> + onMouseLeave={onMouseLeave} + >