From 89b58631ca43ae9bf98c19380f714959c4a7b143 Mon Sep 17 00:00:00 2001
From: jackkav <jackkav@gmail.com>
Date: Tue, 18 Mar 2025 09:28:38 +0100
Subject: [PATCH] fix flakey test

---
 .../tests/smoke/global-environments.test.ts   | 28 ++++++++-----------
 1 file changed, 12 insertions(+), 16 deletions(-)

diff --git a/packages/insomnia-smoke-test/tests/smoke/global-environments.test.ts b/packages/insomnia-smoke-test/tests/smoke/global-environments.test.ts
index 4232d93853..7f05f4ed10 100644
--- a/packages/insomnia-smoke-test/tests/smoke/global-environments.test.ts
+++ b/packages/insomnia-smoke-test/tests/smoke/global-environments.test.ts
@@ -5,28 +5,15 @@ import { test } from '../../playwright/test';
 
 test.describe('Global Environments', async () => {
 
-    test('create a new global environment', async ({ page }) => {
-        await page.getByLabel('Create in project').click();
-        await page.getByLabel('Create', { exact: true }).getByText('Environment').click();
-        await page.getByRole('button', { name: 'Create', exact: true }).click();
-        await page.getByTestId('CreateEnvironmentDropdown').click();
-        await page.getByText('Private environment').click();
-        await page.getByLabel('Project Actions').click();
-        await page.getByText('Duplicate').click();
-        await page.getByText('New Environment (Copy)').click();
-    });
-
     test('import and use a global environment from a collection', async ({ app, page }) => {
         await loadFixtureFile('collection-for-global-environments.yaml', app, page);
         await loadFixtureFile('global-environment.yaml', app, page);
 
         await page.getByRole('link', { name: 'collection-for-global-' }).click();
         await page.getByTestId('New Request').getByLabel('GET New Request', { exact: true }).click();
-        // check if it appears red with error message in tag editor
+        // check if it has error message
         await page.getByText('Body', { exact: true }).click();
-        await page.getByText('_[\'global-base\']').click();
-        await expect(page.getByLabel('Live Preview')).toContainText('Failed to render environment variables: _[\'global-base\']');
-        await page.getByRole('button', { name: 'Done' }).click();
+        await expect(page.getByTitle('Failed to render environment variables: _[\'global-base\']')).toHaveText('_[\'global-base\']');
         // check if it appears as a custom message when sending the request
         await page.getByRole('button', { name: 'Send' }).click();
         await page.getByRole('heading', { name: '2 environment variables are' }).click();
@@ -41,7 +28,16 @@ test.describe('Global Environments', async () => {
         await page.locator('pre').filter({ hasText: '| 4444' }).click();
         await page.locator('pre').filter({ hasText: '| 55555' }).click();
     });
-
+    test('create a new global environment', async ({ page }) => {
+        await page.getByLabel('Create in project').click();
+        await page.getByLabel('Create', { exact: true }).getByText('Environment').click();
+        await page.getByRole('button', { name: 'Create', exact: true }).click();
+        await page.getByTestId('CreateEnvironmentDropdown').click();
+        await page.getByText('Private environment').click();
+        await page.getByLabel('Project Actions').click();
+        await page.getByText('Duplicate').click();
+        await page.getByText('New Environment (Copy)').click();
+    });
 });
 async function loadFixtureFile(fixture: string, app, page) {
     const text = await loadFixture(fixture);