From 8e0c0f5e01d45d03900782e80a861663140d41fc Mon Sep 17 00:00:00 2001 From: Bob Qiu Date: Thu, 8 Oct 2026 12:31:39 +0800 Subject: [PATCH] refactor(tests): implement disableRow method for cleaner row disabling in table editor tests --- packages/insomnia-test/pages/environment.page.ts | 13 +++++++++++++ .../environment/table-editor-disable-row.spec.ts | 5 +---- 2 files changed, 14 insertions(+), 4 deletions(-) diff --git a/packages/insomnia-test/pages/environment.page.ts b/packages/insomnia-test/pages/environment.page.ts index 91c5d20e55..952b97b34f 100644 --- a/packages/insomnia-test/pages/environment.page.ts +++ b/packages/insomnia-test/pages/environment.page.ts @@ -98,9 +98,22 @@ export class EnvironmentPage extends BasePage { * @param row - The row locator to delete */ async deleteRow(row: Locator): Promise { + const rows = this.page.locator(this.LISTBOX).locator('[role="option"]'); + const countBefore = await rows.count(); const button = row.getByRole("button", { name: "Delete Row" }); await button.click(); await button.click(); + await expect(rows).toHaveCount(countBefore - 1); + } + + /** + * Disables a key/value pair row and waits for the row to flip to its + * disabled state (its toggle button becomes "Enable Row"). + * @param row - The row locator to disable + */ + async disableRow(row: Locator): Promise { + await row.getByRole("button", { name: "Disable Row" }).click(); + await expect(row.getByRole("button", { name: "Enable Row" })).toBeVisible(); } /** diff --git a/packages/insomnia-test/tests/environment/table-editor-disable-row.spec.ts b/packages/insomnia-test/tests/environment/table-editor-disable-row.spec.ts index 0f8fc563ca..b1be648cb1 100644 --- a/packages/insomnia-test/tests/environment/table-editor-disable-row.spec.ts +++ b/packages/insomnia-test/tests/environment/table-editor-disable-row.spec.ts @@ -37,10 +37,7 @@ test("Verify Disabling A Row In The Table Editor Is Reflected On Read-Back", asy kvPairData: [varA, varB], }); - await environmentPage - .getRow(varA.name) - .getByRole("button", { name: "Disable Row" }) - .click(); + await environmentPage.disableRow(environmentPage.getRow(varA.name)); const variables = await environmentPage.getVariables(); expect(variables).toEqual([