From f48a6469aa46eae7eaded7e46db5dd9898270a77 Mon Sep 17 00:00:00 2001 From: Gregory Schier Date: Wed, 8 May 2019 12:22:16 -0400 Subject: [PATCH] Fix autocomplete value preview showing rendered HTML --- .../components/codemirror/extensions/autocomplete.js | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/packages/insomnia-app/app/ui/components/codemirror/extensions/autocomplete.js b/packages/insomnia-app/app/ui/components/codemirror/extensions/autocomplete.js index 280cde7d0b..bd5bdd8cd0 100644 --- a/packages/insomnia-app/app/ui/components/codemirror/extensions/autocomplete.js +++ b/packages/insomnia-app/app/ui/components/codemirror/extensions/autocomplete.js @@ -414,15 +414,14 @@ function renderHintMatch(li, self, data) { const markedName = replaceWithSurround(displayText, segment, '', ''); const { char, title } = ICONS[data.type]; + const safeValue = escapeHTML(data.displayValue); - let html = ` + li.className += ` fancy-hint type--${data.type}`; + li.innerHTML = `
${markedName}
-
- ${escapeHTML(data.displayValue || '')} +
+ ${safeValue}
`; - - li.innerHTML = html; - li.className += ` fancy-hint type--${data.type}`; }