From 0067cf82ce526cb34028e5288c28d9395eafa5da Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Lubo=C5=A1=20Lu=C5=88=C3=A1k?= Date: Mon, 10 Mar 2008 23:02:01 +0000 Subject: [PATCH] Remove usage of QWidget::show[FullScreen|Maximized|Minimized|Normal](), they do more then just change the state of the window and all these usage cases were wrong (that is, all their usage). For changing the state, use something like window->setWindowState( window->windowState() | Qt::WindowFullScreen ); // set window->setWindowState( window->windowState() & ~Qt::WindowFullScreen ); // reset or simply use the new KToggleFullScreenAction::setFullScreen() helper. svn path=/trunk/KDE/kdebase/apps/konsole/; revision=784333 --- src/MainWindow.cpp | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/MainWindow.cpp b/src/MainWindow.cpp index 9bc7e4866..7ceabe756 100644 --- a/src/MainWindow.cpp +++ b/src/MainWindow.cpp @@ -254,10 +254,11 @@ void MainWindow::setupActions() void MainWindow::viewFullScreen(bool fullScreen) { if ( fullScreen ) - showFullScreen(); + setWindowState( windowState() | Qt::WindowFullScreen ); else - showNormal(); + setWindowState( windowState() & ~Qt::WindowFullScreen ); } + BookmarkHandler* MainWindow::bookmarkHandler() const { return _bookmarkHandler;