mirror/konsole
1
0
Fork 0
mirror of https://github.com/KDE/konsole.git synced 2026-05-03 12:15:33 -04:00
Code Issues Packages Projects Releases Wiki Activity

Disable some more actions for the KPart that have no use in

Browse Source 
it and interfere with applications using the KPart, and add
a lengthy FIXME about why the current approach for this is
insane.

svn path=/trunk/KDE/kdebase/apps/konsole/; revision=949615
This commit is contained in:
Eike Hein
2009-04-05 14:56:39 +00:00
parent 57aa709a5f
commit 02c0e30ef3
1 changed files with 15 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
src/ViewManager.cpp
View File

@@ -656,6 +656,15 @@ void ViewManager::setNavigationMethod(NavigationMethod method)
if ( collection )
{
// FIXME: The following disables certain actions for the KPart that it
// doesn't actually have a use for, to avoid polluting the action/shortcut
// namespace of an application using the KPart (otherwise, a shortcut may
// be in use twice, and the user gets to see an "ambiguous shortcut over-
// load" error dialog). However, this approach sucks - it's the inverse of
// what it should be. Rather than disabling actions not used by the KPart,
// a method should be devised to only enable those that are used, perhaps
// by using a separate action collection.
QAction* action;
action = collection->action( "next-view" );
@@ -672,6 +681,12 @@ void ViewManager::setNavigationMethod(NavigationMethod method)
action = collection->action( "rename-session" );
if ( action ) action->setEnabled( _navigationMethod != NoNavigation );
action = collection->action( "move-view-left" );
if ( action ) action->setEnabled( _navigationMethod != NoNavigation );
action = collection->action( "move-view-right" );
if ( action ) action->setEnabled( _navigationMethod != NoNavigation );
}
}