Swap the order of column(width) and line(height) in method signature

It is more natural to use column x line.

TODO: The current code is inconsistent with itself regarding this issue
This commit is contained in:
Jekyll Wu
2012-06-04 13:49:04 +08:00
parent 85d787e928
commit 045284c405
3 changed files with 7 additions and 7 deletions

View File

@@ -704,7 +704,7 @@ void Session::updateTerminalSize()
void Session::updateWindowSize(int lines, int columns)
{
Q_ASSERT(lines > 0 && columns > 0);
_shellProcess->setWindowSize(lines, columns);
_shellProcess->setWindowSize(columns, lines);
}
void Session::refresh()
{
@@ -723,9 +723,9 @@ void Session::refresh()
// send an email with method or patches to konsole-devel@kde.org
const QSize existingSize = _shellProcess->windowSize();
_shellProcess->setWindowSize(existingSize.height(), existingSize.width() + 1);
_shellProcess->setWindowSize(existingSize.width() + 1, existingSize.height());
usleep(500); // introduce small delay to avoid changing size too quickly
_shellProcess->setWindowSize(existingSize.height(), existingSize.width());
_shellProcess->setWindowSize(existingSize.width(), existingSize.height());
}
bool Session::kill(int signal)