From 09237ee02f0bf998061d092b9ce73dcfafaa795d Mon Sep 17 00:00:00 2001 From: Theodore Wang Date: Fri, 16 Jun 2023 17:10:58 +0000 Subject: [PATCH] Fixed search bar false positive after clear scrollback (and reset) To prevent the search bar from continuing to show a match by emitting green even after clearing scrollback and resetting, search is rerun whenever the searchbar is opened. BUG: 407317 --- src/session/SessionController.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/session/SessionController.cpp b/src/session/SessionController.cpp index 66a0ab16c..1070c962f 100644 --- a/src/session/SessionController.cpp +++ b/src/session/SessionController.cpp @@ -1554,6 +1554,7 @@ void SessionController::searchBarEvent() _searchBar->focusLineEdit(); } else { searchHistory(true); + searchTextChanged(_searchBar->searchText()); _isSearchBarEnabled = true; } } @@ -1644,11 +1645,12 @@ void SessionController::setFindNextPrevEnabled(bool enabled) _findNextAction->setEnabled(enabled); _findPreviousAction->setEnabled(enabled); } + void SessionController::searchTextChanged(const QString &text) { Q_ASSERT(view()->screenWindow()); - if (_searchText == text) { + if (_searchText == text && _isSearchBarEnabled) { return; }