From 66563389614c6e0dde3ff50396ee749cb7dec8ee Mon Sep 17 00:00:00 2001 From: Kurt Hindenburg Date: Tue, 17 Sep 2013 13:44:16 -0400 Subject: [PATCH] Add pragma to keep track of KFileDialog crashes --- src/ColorSchemeEditor.cpp | 1 + src/EditProfileDialog.cpp | 1 + src/SessionController.cpp | 3 +++ 3 files changed, 5 insertions(+) diff --git a/src/ColorSchemeEditor.cpp b/src/ColorSchemeEditor.cpp index 1de719c5b..b307a61e9 100644 --- a/src/ColorSchemeEditor.cpp +++ b/src/ColorSchemeEditor.cpp @@ -159,6 +159,7 @@ void ColorSchemeEditor::editColorItem(QTableWidgetItem* item) } void ColorSchemeEditor::selectWallpaper() { +#pragma message("Fix crashes with KFileDialog") const KUrl url = KFileDialog::getImageOpenUrl(KUrl(_ui->wallpaperPath->text()), this, i18nc("@action:button", "Select wallpaper image file")); diff --git a/src/EditProfileDialog.cpp b/src/EditProfileDialog.cpp index 68e9b845b..9bf42fb92 100644 --- a/src/EditProfileDialog.cpp +++ b/src/EditProfileDialog.cpp @@ -396,6 +396,7 @@ void EditProfileDialog::commandChanged(const QString& command) } void EditProfileDialog::selectInitialDir() { +#pragma message("Fix crashes with KFileDialog") const KUrl url = KFileDialog::getExistingDirectoryUrl(KUrl(_ui->initialDirEdit->text()), this, i18n("Select Initial Directory")); diff --git a/src/SessionController.cpp b/src/SessionController.cpp index 891ad8a32..9c85f3014 100644 --- a/src/SessionController.cpp +++ b/src/SessionController.cpp @@ -1591,6 +1591,7 @@ void SessionController::zmodemDownload() if (zmodem.isEmpty()) { zmodem = QStandardPaths::findExecutable("lrz"); } +#pragma message("Fix crashes with KFileDialog") if (!zmodem.isEmpty()) { const QString path = KFileDialog::getExistingDirectory( KUrl(), _view, @@ -1628,6 +1629,7 @@ void SessionController::zmodemUpload() return; } +#pragma message("Fix crashes with KFileDialog") QStringList files = KFileDialog::getOpenFileNames(KUrl(), QString(), _view, i18n("Select Files for ZModem Upload")); if (!files.isEmpty()) { @@ -1682,6 +1684,7 @@ void SaveHistoryTask::execute() // TODO - show a warning ( preferably passive ) if saving the history output fails // +#pragma message("Fix crashes with KFileDialog") KFileDialog* dialog = new KFileDialog(KUrl(QString(":konsole")) /* check this */, QString(), QApplication::activeWindow()); dialog->setOperationMode(KFileDialog::Saving);