mirror/konsole
1
0
Fork 0
mirror of https://github.com/KDE/konsole.git synced 2026-05-05 05:07:06 -04:00
Code Issues Packages Projects Releases Wiki Activity

Warn users they may need to restart konsole to see transparent background.

Browse Source 
If desktop effect is enabled only after konsole has started, then
users need to restart konsole to see transparent background.

FEATURE: 169305
FIXED-IN: 4.8
This commit is contained in:
Jekyll Wu
2011-09-09 01:04:16 +08:00
parent 3ca9d38075
commit 7d2f153ae6
1 changed files with 25 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
src/EditProfileDialog.cpp
View File

@@ -55,6 +55,10 @@
#include "ShellCommand.h"
#include "TabTitleFormatAction.h"
// FIXME: it feels bad to include a big header file just
// in order to use one of its static members.
#include "TerminalDisplay.h"
using namespace Konsole;
EditProfileDialog::EditProfileDialog(QWidget* parent)
@@ -458,9 +462,7 @@ void EditProfileDialog::setupAppearancePage(const Profile::Ptr info)
SLOT(colorSchemeAnimationUpdate()) );
_ui->transparencyWarningWidget->setVisible(false);
_ui->transparencyWarningWidget->setText(i18n("This color scheme uses a transparent background"
" which does not appear to be supported on your"
" desktop"));
_ui->editColorSchemeButton->setEnabled(false);
_ui->removeColorSchemeButton->setEnabled(false);
@@ -821,8 +823,26 @@ void EditProfileDialog::updateTransparencyWarning()
// zero or one indexes can be selected
foreach( const QModelIndex& index , _ui->colorSchemeList->selectionModel()->selectedIndexes() )
{
bool hasTransparency = index.data(Qt::UserRole+1).value<const ColorScheme*>()->opacity() < 1.0;
_ui->transparencyWarningWidget->setHidden(KWindowSystem::compositingActive() || !hasTransparency);
bool needTransparency = index.data(Qt::UserRole+1).value<const ColorScheme*>()->opacity() < 1.0;
if ( ! needTransparency )
{
_ui->transparencyWarningWidget->setHidden(true);
}
else if ( ! KWindowSystem::compositingActive() )
{
_ui->transparencyWarningWidget->setText(i18n("This color scheme uses a transparent background"
" which does not appear to be supported on your"
" desktop"));
_ui->transparencyWarningWidget->setHidden(false);
}
else if ( ! TerminalDisplay::HAVE_TRANSPARENCY )
{
_ui->transparencyWarningWidget->setText(i18n("Konsole was started before desktop effect is enabled. "
" You need to restart konsole to see transparent background."));
_ui->transparencyWarningWidget->setHidden(false);
}
}
}