Fix tab attach/reattach and simplify tab dnd code

Summary:
This continues the patch series of the rewrite
of the Tab handling code to a more modern approach
using QTabWidget.

This fixes the attach and reattach bug on multiple
konsole windows and reworks the drag & drop code
to a more simplified version of it.

Reviewers: hindenburg, ngraham, sandsmark

Reviewed By: hindenburg

Subscribers: lbergdoll, konsole-devel

Tags: #konsole

Differential Revision: https://phabricator.kde.org/D15377
This commit is contained in:
Tomaz Canabrava
2018-09-16 12:47:34 -04:00
committed by Kurt Hindenburg
parent 86206e97be
commit 8fd74e8b74
6 changed files with 109 additions and 23 deletions

View File

@@ -649,7 +649,7 @@ TabbedViewContainer *ViewManager::createContainer()
return container;
}
void ViewManager::containerMoveViewRequest(int index, int id, bool &success,
void ViewManager::containerMoveViewRequest(int index, int id,
TabbedViewContainer *sourceTabbedContainer)
{
TabbedViewContainer *container = qobject_cast<TabbedViewContainer *>(sender());
@@ -677,7 +677,6 @@ void ViewManager::containerMoveViewRequest(int index, int id, bool &success,
createView(controller->session(), container, index);
controller->session()->refresh();
success = true;
}
void ViewManager::setNavigationMethod(NavigationMethod method)