From 97ce14afef4b0f17d60c58bbbf68e9753f20d944 Mon Sep 17 00:00:00 2001 From: Jekyll Wu Date: Mon, 13 Feb 2012 06:18:04 +0800 Subject: [PATCH] Remove code for tab title formatter %c and %C. Those two formatters have never been actually implemented or revealed to users. It is quite hard to infer what they are supposed to do based upon exising code and commit history --- src/ProcessInfo.cpp | 14 -------------- src/ProcessInfo.h | 8 -------- 2 files changed, 22 deletions(-) diff --git a/src/ProcessInfo.cpp b/src/ProcessInfo.cpp index e95891176..bdd45abcb 100644 --- a/src/ProcessInfo.cpp +++ b/src/ProcessInfo.cpp @@ -125,9 +125,6 @@ QString ProcessInfo::format(const QString& input) const // search for and replace known marker output.replace("%u", userName()); output.replace("%n", name(&ok)); - // TODO: un-comment me when ProcessInfo::formatCommand() is implemented. - //output.replace("%c",formatCommand(name(&ok),arguments(&ok),ShortCommandFormat)); - //output.replace("%C",formatCommand(name(&ok),arguments(&ok),LongCommandFormat)); QString dir = validCurrentDir(); if (output.contains("%D")) { @@ -145,17 +142,6 @@ QString ProcessInfo::format(const QString& input) const return output; } -QString ProcessInfo::formatCommand(const QString& name, - const QVector& arguments, - CommandFormat format) const -{ - Q_UNUSED(name); - Q_UNUSED(format); - - // TODO Implement me - return QStringList(QList::fromVector(arguments)).join(" "); -} - QSet ProcessInfo::_commonDirNames; QSet ProcessInfo::commonDirNames() diff --git a/src/ProcessInfo.h b/src/ProcessInfo.h index cec26ae0b..c144d1bbf 100644 --- a/src/ProcessInfo.h +++ b/src/ProcessInfo.h @@ -286,14 +286,6 @@ private: // space-constrained UI elements (eg. tabs) QString formatShortDir(const QString& dirPath) const; - enum CommandFormat { - ShortCommandFormat, - LongCommandFormat - }; - // takes a process name and its arguments and produces formatted output - QString formatCommand(const QString& name , const QVector& arguments , - CommandFormat format) const; - // valid bits for _fields variable, ensure that // _fields is changed to an int if more than 8 fields are added enum FIELD_BITS {