From a2a54f41d8f6dd60859dd232acd41ff0b0433daa Mon Sep 17 00:00:00 2001
From: Jekyll Wu <adaptee@gmail.com>
Date: Fri, 21 Oct 2011 19:03:45 +0800
Subject: [PATCH] make Session::updateForegroundProcessInfo() easier to
 understand

---
 src/Session.cpp | 15 +++++++--------
 1 file changed, 7 insertions(+), 8 deletions(-)

diff --git a/src/Session.cpp b/src/Session.cpp
index 81da22520..3b537c052 100644
--- a/src/Session.cpp
+++ b/src/Session.cpp
@@ -961,26 +961,25 @@ void Session::updateSessionProcessInfo()
 
 bool Session::updateForegroundProcessInfo()
 {
-    bool valid = (_foregroundProcessInfo != 0);
-
-    // has foreground process changed?
     Q_ASSERT(_shellProcess);
+
     int pid = _shellProcess->foregroundProcessGroup();
     if (pid != _foregroundPid)
     {
         delete _foregroundProcessInfo;
         _foregroundProcessInfo = ProcessInfo::newInstance(pid);
         _foregroundPid = pid;
-        valid = true;
     }
 
-    if (valid)
+    if (_foregroundProcessInfo)
     {
         _foregroundProcessInfo->update();
-        valid = _foregroundProcessInfo->isValid();
+        return _foregroundProcessInfo->isValid();
+    }
+    else
+    {
+        return false;
     }
-
-    return valid;
 }
 
 bool Session::isRemote()