mirror/konsole
1
0
Fork 0
mirror of https://github.com/KDE/konsole.git synced 2026-05-07 14:16:40 -04:00
Code Issues Packages Projects Releases Wiki Activity

Create runtime profile only once per session.

Browse Source 
The patch is provied by Gu Rui <chaos.proton@gmail.com>

REVIEW: 102506
This commit is contained in:
Jekyll Wu
2011-09-01 22:46:33 +08:00
parent 93f98ef422
commit a5eaba7f76
2 changed files with 12 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
src/SessionManager.cpp
View File

@@ -758,18 +758,23 @@ Profile::Ptr SessionManager::findByShortcut(const QKeySequence& shortcut)
void SessionManager::sessionProfileCommandReceived(const QString& text)
{
// FIXME: This is inefficient, it creates a new profile instance for
// each set of changes applied. Instead a new profile should be created
// only the first time changes are applied to a session
Session* session = qobject_cast<Session*>(sender());
Q_ASSERT( session );
ProfileCommandParser parser;
QHash<Profile::Property,QVariant> changes = parser.parse(text);
Profile::Ptr newProfile = Profile::Ptr(new Profile(_sessionProfiles[session]));
Profile::Ptr newProfile;
if ( !_sessionRuntimeProfiles.contains(session) )
{
newProfile = new Profile(_sessionProfiles[session]);
_sessionRuntimeProfiles.insert(session,newProfile);
}
else
{
newProfile = _sessionRuntimeProfiles[session];
}
QHashIterator<Profile::Property,QVariant> iter(changes);
while ( iter.hasNext() )
{