From a6793123dc508f17c71e5d7bce96eba0bad5b8a5 Mon Sep 17 00:00:00 2001 From: Kurt Hindenburg Date: Thu, 31 Jan 2013 10:50:59 -0500 Subject: [PATCH] Add comment about redundant condition This has been there since KDE 4.0 - need to check if there is missing logic or just a mistake. via cppcheck --- src/Vt102Emulation.cpp | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/Vt102Emulation.cpp b/src/Vt102Emulation.cpp index 7b59f7ce2..1ab775894 100644 --- a/src/Vt102Emulation.cpp +++ b/src/Vt102Emulation.cpp @@ -1224,6 +1224,8 @@ void Vt102Emulation::setMode(int m) setScreen(1); break; } + // FIXME: Currently this has a redundant condition as MODES_SCREEN is 6 + // and MODE_NewLine is 5 if (m < MODES_SCREEN || m == MODE_NewLine) { _screen[0]->setMode(m); _screen[1]->setMode(m); @@ -1250,6 +1252,8 @@ void Vt102Emulation::resetMode(int m) setScreen(0); break; } + // FIXME: Currently this has a redundant condition as MODES_SCREEN is 6 + // and MODE_NewLine is 5 if (m < MODES_SCREEN || m == MODE_NewLine) { _screen[0]->resetMode(m); _screen[1]->resetMode(m);