From b5dc7a982daeaec28dfd8d44d1b33013a775c0d4 Mon Sep 17 00:00:00 2001 From: Jekyll Wu Date: Sat, 14 Jan 2012 13:24:58 +0800 Subject: [PATCH] Ensure the 'MenuIndex' entry is never written into profile on disk The current code expects that entry to be absent or has 0 as its value in the profile on disk. However, I guess the code is not strict enough to guarantee that assuption since I have noticed MenuIndex=N several times when checking my profiles. More importantly, the way how MenuIndex interacts with favorite status is not quite staight forward. --- src/Profile.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Profile.cpp b/src/Profile.cpp index 5a382bb1e..c2aa31347 100644 --- a/src/Profile.cpp +++ b/src/Profile.cpp @@ -68,6 +68,7 @@ const Profile::PropertyInfo Profile::DefaultPropertyNames[] = { , { Icon , "Icon" , GENERAL_GROUP , QVariant::String } , { Command , "Command" , 0 , QVariant::String } , { Arguments , "Arguments" , 0 , QVariant::StringList } + , { MenuIndex, "MenuIndex" , 0, QVariant::String } , { Environment , "Environment" , GENERAL_GROUP , QVariant::StringList } , { Directory , "Directory" , GENERAL_GROUP , QVariant::String } , { LocalTabTitleFormat , "LocalTabTitleFormat" , GENERAL_GROUP , QVariant::String } @@ -81,7 +82,6 @@ const Profile::PropertyInfo Profile::DefaultPropertyNames[] = { , { NewTabBehavior , "NewTabBehavior" , GENERAL_GROUP , QVariant::Int } , { StartInCurrentSessionDir , "StartInCurrentSessionDir" , GENERAL_GROUP , QVariant::Bool } , { ShowNewAndCloseTabButtons, "ShowNewAndCloseTabButtons" , GENERAL_GROUP , QVariant::Bool } - , { MenuIndex, "MenuIndex" , GENERAL_GROUP , QVariant::String } , { SilenceSeconds, "SilenceSeconds" , GENERAL_GROUP , QVariant::Int } // Appearance