From c3176abb175d64dab4588ab8700adbe48069fc50 Mon Sep 17 00:00:00 2001
From: Willyanto Willyanto <willyanto39@protonmail.com>
Date: Tue, 20 Dec 2022 22:58:47 +0700
Subject: [PATCH] Perform some initializations in initialization list

Fixes some variable is assigned in constructor body. Consider performing
initialization in initialization list. (CWE-398)
---
 src/ShellCommand.cpp                           | 5 ++---
 src/filterHotSpots/EscapeSequenceUrlFilter.cpp | 4 ++--
 src/session/SessionDisplayConnection.cpp       | 4 ++--
 3 files changed, 6 insertions(+), 7 deletions(-)

diff --git a/src/ShellCommand.cpp b/src/ShellCommand.cpp
index 07a706c41..467a064ea 100644
--- a/src/ShellCommand.cpp
+++ b/src/ShellCommand.cpp
@@ -13,14 +13,13 @@
 using Konsole::ShellCommand;
 
 ShellCommand::ShellCommand(const QString &aCommand)
+    : _arguments(KShell::splitArgs(aCommand))
 {
-    _arguments = KShell::splitArgs(aCommand);
 }
 
 ShellCommand::ShellCommand(const QString &aCommand, const QStringList &aArguments)
+    : _arguments(aArguments)
 {
-    _arguments = aArguments;
-
     if (!_arguments.isEmpty()) {
         _arguments[0] = aCommand;
     }
diff --git a/src/filterHotSpots/EscapeSequenceUrlFilter.cpp b/src/filterHotSpots/EscapeSequenceUrlFilter.cpp
index 2c3095613..01a195a8e 100644
--- a/src/filterHotSpots/EscapeSequenceUrlFilter.cpp
+++ b/src/filterHotSpots/EscapeSequenceUrlFilter.cpp
@@ -15,9 +15,9 @@
 using namespace Konsole;
 
 EscapeSequenceUrlFilter::EscapeSequenceUrlFilter(Session *session, TerminalDisplay *window)
+    : _session(session)
+    , _window(window)
 {
-    _session = session;
-    _window = window;
 }
 
 void EscapeSequenceUrlFilter::process()
diff --git a/src/session/SessionDisplayConnection.cpp b/src/session/SessionDisplayConnection.cpp
index f9d2d1691..d065af42d 100644
--- a/src/session/SessionDisplayConnection.cpp
+++ b/src/session/SessionDisplayConnection.cpp
@@ -15,9 +15,9 @@ namespace Konsole
 {
 SessionDisplayConnection::SessionDisplayConnection(Session *session, TerminalDisplay *view, QObject *parent)
     : QObject(parent)
+    , _session(session)
+    , _view(view)
 {
-    _session = session;
-    _view = view;
 }
 
 QPointer<Session> SessionDisplayConnection::session()