From cd2e674d2110a1d7c10bfcd2f915f63ceeaa05c8 Mon Sep 17 00:00:00 2001 From: Jekyll Wu Date: Thu, 15 Sep 2011 15:11:27 +0800 Subject: [PATCH] Rename to avoid confusion. It is confusing to name a ViewManager* pointer as 'view', especially when it is used in 'view->createView()'. --- src/Application.cpp | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/Application.cpp b/src/Application.cpp index 987d7c5c9..2058546e9 100644 --- a/src/Application.cpp +++ b/src/Application.cpp @@ -429,7 +429,7 @@ void Application::createWindow(Profile::Ptr profile , const QString& directory) window->show(); } -Session* Application::createSession(Profile::Ptr profile, const QString& directory , ViewManager* view) +Session* Application::createSession(Profile::Ptr profile, const QString& directory , ViewManager* viewManager) { if (!profile) profile = SessionManager::instance()->defaultProfile(); @@ -442,12 +442,12 @@ Session* Application::createSession(Profile::Ptr profile, const QString& directo // create view before starting the session process so that the session doesn't suffer // a change in terminal size right after the session starts. some applications such as GNU Screen // and Midnight Commander don't like this happening - view->createView(session); + viewManager->createView(session); return session; } -Session* Application::createSSHSession(Profile::Ptr profile, const KUrl& url, ViewManager* view) +Session* Application::createSSHSession(Profile::Ptr profile, const KUrl& url, ViewManager* viewManager) { if (!profile) profile = SessionManager::instance()->defaultProfile(); @@ -466,7 +466,7 @@ Session* Application::createSSHSession(Profile::Ptr profile, const KUrl& url, Vi // create view before starting the session process so that the session doesn't suffer // a change in terminal size right after the session starts. some applications such as GNU Screen // and Midnight Commander don't like this happening - view->createView(session); + viewManager->createView(session); session->run(); return session;