mirror/konsole
1
0
Fork 0
mirror of https://github.com/KDE/konsole.git synced 2026-03-06 06:57:16 -05:00
Code Issues Packages Projects Releases Wiki Activity

Fix if condition when updating filters

Browse Source 
We want to delete the _escapedUrlFilter if allowEscapedLinks() is false.
This commit is contained in:
Ahmad Samir
2020-11-19 18:02:39 +02:00
committed by Kurt Hindenburg
parent 11987c7ae4
commit d74c0b1533
1 changed files with 6 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src/session/SessionController.cpp
View File

@@ -1304,14 +1304,15 @@ void SessionController::updateFilterList(const Profile::Ptr &profile)
filterChain->addFilter(_urlFilter);
}
const bool allowEscapeSequenceLinks = profile->allowEscapedLinks();
if (allowEscapeSequenceLinks && (_escapedUrlFilter != nullptr)) {
if (profile->allowEscapedLinks()) {
if (_escapedUrlFilter == nullptr) {
_escapedUrlFilter = new EscapeSequenceUrlFilter(_sessionDisplayConnection->session(), _sessionDisplayConnection->view());
filterChain->addFilter(_escapedUrlFilter);
}
} else if (_escapedUrlFilter != nullptr) { // Became disabled, clean up
filterChain->removeFilter(_escapedUrlFilter);
delete _escapedUrlFilter;
_escapedUrlFilter = nullptr;
} else if (allowEscapeSequenceLinks && _escapedUrlFilter == nullptr) {
_escapedUrlFilter = new EscapeSequenceUrlFilter(_sessionDisplayConnection->session(), _sessionDisplayConnection->view());
filterChain->addFilter(_escapedUrlFilter);
}
const bool allowColorFilters = profile->colorFilterEnabled();