mirror/konsole
1
0
Fork 0
mirror of https://github.com/KDE/konsole.git synced 2026-05-04 04:33:38 -04:00
Code Issues Packages Projects Releases Wiki Activity

Prefer foreach(..) over iterating manually for readability

Browse Source
This commit is contained in:
Jekyll Wu
2012-02-13 21:19:06 +08:00
parent 97ce14afef
commit f0529c1c02
9 changed files with 21 additions and 51 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/KeyBindingEditor.cpp
View File

@@ -70,13 +70,9 @@ KeyBindingEditor::~KeyBindingEditor()
void KeyBindingEditor::removeSelectedEntry()
{
QList<QTableWidgetItem*> selectedList = _ui->keyBindingTable->selectedItems();
QList<QTableWidgetItem*> uniqueList;
//Filter unique items
QListIterator<QTableWidgetItem*> iter(selectedList);
while (iter.hasNext()) {
QTableWidgetItem* item = iter.next();
foreach ( QTableWidgetItem* item, _ui->keyBindingTable->selectedItems() ) {
if (item->column() == 1) //Select item at the first column
item = _ui->keyBindingTable->item(item->row(), 0);
@@ -84,10 +80,8 @@ void KeyBindingEditor::removeSelectedEntry()
uniqueList.append(item);
}
iter = QListIterator<QTableWidgetItem*>(uniqueList);
while (iter.hasNext()) {
foreach ( QTableWidgetItem* item, uniqueList ) {
// get the first item in the row which has the entry
QTableWidgetItem* item = iter.next();
KeyboardTranslator::Entry existing = item->data(Qt::UserRole).
value<KeyboardTranslator::Entry>();