Doing an infinite loop is a bad idea. This is linux, things can always
fail. The new logic only does 2 checks with a 5ms wait in between.
Due to the old code Kate often freezes during startup.
This shall fix a minor bug calling hosts that are defined in ~/.ssh/config by their identifier name rather than its HostName.
> Definition:
> "identifier" is called Host in .ssh/config.
Example config in ~/.ssh/config:
> Host core
>
> HostName core.company.com
>
> User sshadmin
You want Konsole to run "ssh core", since calling ssh with a
config identifier makes ssh pull all config from .ssh/config.
Currently Konsole runs "ssh core.company.com" so it takes the hostname
instead of the config identifier.
In the end it does not match any entity in ssh's config and Konsole
would need to establish a correct set of parameters in the call to the
ssh binary.
That error I think is laying in sshmanagerplugin.cpp:205-216
where we need to evolve the if statement.
There was already a merge request for this issue report:
> BUG: https://bugs.kde.org/show_bug.cgi?id=450891
> MR: https://invent.kde.org/utilities/konsole/-/merge_requests/1055
But I think that MR is a bit of a shortcoming and does not take full
advantage of having the ssh binary do its job.
Let me know in case something needs to be aligned with your requirements.
I am new to sw dev and this is my very first patch to a KDE or any cpp/Qt project.
Otherwise, we may try to enter a directory which doesn't even exist on
the local host when opening a new tab, which leads to the session
failing to start with a big red scary error message.
Adds `Ctrl+Insert` as a shortcut to `Copy`; this is an alternate keybinding to `Copy` that works across both KDE and Windows and doesn't conflict with `Ctrl+C` used to terminate terminal programs.
As it was previously, it only worked as intended if the user had only
the binary as the start command (e.g. /bin/bash). Otherwise, it would
had appended the flatpak-spawn related argument after the start command
program.
Instead of passing the start command args to KSandbox::makeHostContext,
this will append them to the ones returned by makeHostContext on the
'postProcessArgs' function. In case Konsole is being run as a Flatpak,
all of said args would be added after '--env=TERM=xterm-256color' and
the program name.
BUG: 497519
