mirror/konsole
1
0
Fork 0
mirror of https://github.com/KDE/konsole.git synced 2026-05-04 20:55:56 -04:00
Code Issues Packages Projects Releases Wiki Activity
4,116 Commits 139 Branches 416 Tags
142e6b73cacf67e7886ea896e2a8a5040a0e92ba
Commit Graph

140 Commits

Author SHA1 Message Date
Jekyll Wu
142e6b73ca Normalize signal/slot 2011-11-07 17:28:58 +08:00
Jekyll Wu
125e2c7bd2 Declare pointer and reference in a consistent way 
Most code use the "const QString& text" form, instead of the "const
QString &text" form. So change the minority to be consistent with
the majority.
 2011-11-06 06:13:28 +08:00
Jekyll Wu
cf92cece2b Remove leading white spaces in blank lines to make them really empty 2011-11-05 07:29:21 +08:00
Jekyll Wu
102371bb3a Rename _closePerUser to _closePerUserRequest for clarity 2011-10-24 18:42:03 +08:00
Jekyll Wu
841206fb13 Title set by dbus method setTitle() should be sticky by default 
It is not intuitive and easy for users to find they need also
call dbus method setTabTitleFormat() to avoid that title being
replaced on session activity.

BUG: 262089
FIXED-IN: 4.8
 2011-10-22 18:56:26 +08:00
Jekyll Wu
1c1981501b Ensure %w and %# are also expaned in the 'Copy input' dialog 
The fix is quite simple. Just move the existing code for expanding
%# and %w into Session::getDynamicTitle(), where all other tab title
formatters are expanded. That also makes the code simple and natural.

BUG: 175755
FIXED-IN:4.8
 2011-10-22 03:18:01 +08:00
Jekyll Wu
07bf74c335 Adjust #include to make the dependency more explicit 2011-10-21 22:09:48 +08:00
Jekyll Wu
a2a54f41d8 make Session::updateForegroundProcessInfo() easier to understand 2011-10-21 19:09:59 +08:00
Jekyll Wu
379c5bb7de Minor change on initial value and code style 2011-10-21 19:09:59 +08:00
Jekyll Wu
3d0b5a74d0 'delete NULL' is always safe 2011-10-21 19:09:51 +08:00
Jekyll Wu
fc6c244335 fix the compiler warning for the order of member initialization 2011-10-21 17:03:59 +08:00
Jekyll Wu
ed88c7f5da Refactor Session::activityStateSet() to make it more readable 2011-10-21 13:23:22 +08:00
Jekyll Wu
277038478b Allow activity notification to be triggered more than once. 
The activity notification is now masked for a while after it is triggered.
That is basically what KDE3 konsole does. The mask interval is intended
to avoid the flooding of notification and is hardcoded as 15 seconds
at the moment. Maybe that interval should be user configurable.

FIXED-IN:4.8
CCBUG: 257752
 2011-10-21 12:37:47 +08:00
Jekyll Wu
b4d30060c2 Rename the timer related with "Monitor Silence" for clarity 
That timer is dedicated for the "Monitor Silence" feature, so
_monitorTimer is a too generic name.
 2011-10-21 05:05:09 +08:00
Jekyll Wu
6ff48dff6a Not a good idea to use _monitor as parameter name 2011-10-21 00:15:30 +08:00
Jekyll Wu
451738cc98 Close the session reliably after the terminal process itself crashes 2011-10-16 04:14:54 +08:00
Jekyll Wu
582364186d Refactor method Session::done(int, QProcess::ExitStatus). 
- make the logic easier to understand
  - ensure the warning message is non-empty
 2011-10-16 04:05:52 +08:00
Jekyll Wu
e3a09c9c4d Close session reliably when the session process doesn't die with SIGHUP. 
BUG:241709
BUG:251566
CCBUG:254600
FIXED-IN: 4.8
REVIEW:102239
 2011-10-03 12:40:04 +08:00
Jekyll Wu
790e835c6f Do not resolve the symlink for initial working directory. 
The patch is from Danny Daemonic <DannyDaemonic@gmail.com>

FEATURE: 242114
FIXED-IN: 4.8
 2011-09-30 23:56:19 +08:00
Jekyll Wu
c7e300a513 Delete another uncessary "#include <assert.h>". 2011-09-27 23:17:03 +08:00
Jekyll Wu
195abc0324 Rename erase char related methods in class Pty. 
erase()    ==> eraseChar()
setErase() ==> setEraseChar()
 2011-09-27 13:27:38 +08:00
Jekyll Wu
272ac9850e Include KDE headers consistently in the from of "#include <KSomething>" . 
However, some KDE headers are still only available in the form of
"#include <ksomething.h>"

krun.h              ==>     KRun
kicon.h             ==>     KIcon
kdebug.h            ==>     KDebug
kshell.h            ==>     KShell
kdialog.h           ==>     KDialog
kconfig.h           ==>     KConfig
klocale.h           ==>     KLocale
kglobal.h           ==>     KGlobal
kcolorutils.h       ==>     KColorUtils
kconfiggroup.h      ==>     KConfigGroup
kdesktopfile.h      ==>     KDesktopFile
kcolorscheme.h      ==>     KColorScheme
kstandarddirs.h     ==>     KStandardDirs
ktemporaryfile.h    ==>     KTemporaryFile
klocalizedstring.h  ==>     KLocalizedString
 2011-09-23 05:04:46 +08:00
Jekyll Wu
2818d96536 Calling Session::run() on a already running sesssion makes no sense. 2011-09-05 15:26:22 +08:00
Jekyll Wu
c246e94fb5 Check whether the pointer _shellProcess is null before using it. 2011-09-05 15:26:07 +08:00
Jekyll Wu
0e184eeda9 KStandardDirs::findExe() is actually a static method. 2011-09-03 17:09:34 +08:00
Jekyll Wu
f5772ab06b Enable copy action only when some text are selected. 
FEATURE: 203768
FIXED-IN: 4.8
 2011-08-27 01:59:18 +08:00
Jekyll Wu
0ddf722e08 Disable clear & reset actions when the secondary screen is in use. 
BUG:204741
FIXED-IN: 4.8
 2011-08-27 00:14:09 +08:00
Jekyll Wu
17588b326f Revert "use qobject_cast in place of old-style c++ type cast." 
That change causes crash when detaching session. Weird.

This reverts commit 458095e8a4.
 2011-08-25 23:59:03 +08:00
Jekyll Wu
458095e8a4 use qobject_cast in place of old-style c++ type cast. 2011-08-25 20:03:02 +08:00
Jekyll Wu
d2ea045040 Make some code slightly more readable. 2011-08-25 19:51:19 +08:00
Jekyll Wu
769f933256 align arguments in the same column. 2011-08-25 15:46:56 +08:00
Jekyll Wu
1514ea7612 Use '{ }' in a consistent way in the "if ... else ..." statement. 2011-08-25 15:38:22 +08:00
Jekyll Wu
024ffb1972 adjust indentation to 4 spaces. 2011-08-25 15:10:32 +08:00
Kurt Hindenburg
df9ac5a70d s/"/' for single character. 2011-08-23 09:12:02 -04:00
Jekyll Wu
6aad97eb01 make bookmark save non-default ssh port if it is used. 
BUG: 238973
FIXED-IN: 4.8
 2011-08-21 09:22:40 +08:00
Jekyll Wu
8801b4ffb5 Member variable _fullScripting is not used any more. 2011-08-11 18:51:24 +08:00
Jekyll Wu
016061eb60 remove code which is duplicated and effectively of no-use . 
The fallback sequence for terminal command is not defined within
Session::checkProgram() anymore.
 2011-08-11 11:32:31 +08:00
Kurt Hindenburg
7e00edd516 Make sure pty device has right size before terminal process queries it. 
Whenever TeminalDisplay is resized, konsole tells the underlying
pty device its new size by calling Pty::setWindowSize(). However,
current code can't guarantee when the terminal process starts and
queries the pty device about its size, the pty device already has the
right info. This has caused some long known bugs, such as #176902.

This patch tries to guarantee that important assumption. It currently
uses a hard-coded small delay, which works pretty well in practice
although not that elegant.

Patch by Jekyll Wu <adaptee@gmail.com>

I think this is better than leaving the situation as it is.  This may
be backported if no issues are found.
BUG: 173999
BUG: 176902
BUG: 203185
BUG: 229058
REVIEW: 102061
FIXED-IN: 4.8
 2011-08-05 10:40:14 -04:00
Montel Laurent
b91f50015d Normalize signals/slots 2011-07-30 14:10:56 +02:00
Kurt Hindenburg
b8b3f23723 Correct non-zero status notification such that it works. 
The non-zero notification was being displayed for zero exit codes.

Thanks again to Jekyll Wu (adaptee@gmail.com) for patch and research.
BUG: 221726
FIXED-IN: 2.8
 2011-07-20 09:53:32 -04:00
Montel Laurent
a955ae6e36 Don't check pointer before to delete it 2011-04-21 13:37:01 +02:00
Kurt Hindenburg
acd507e1a5 Set correct focus in the "rename tab" dialog. 
Currently, the OK button has the focus upon startup. After patch, the
user doesn't need to remember if they need to adjust the remote or
local title.

Patch by Sebastian Kühn

http://git.reviewboard.kde.org/r/100642/
 2011-02-13 21:29:15 -05:00
Kurt Hindenburg
b216cb9daf In the tab title, for %D change the user's home path with a ~ if it starts at the 
beginning.

FEATURE: 206316
FIXED-IN: 4.6

svn path=/trunk/KDE/kdebase/apps/konsole/; revision=1185589
 2010-10-13 19:58:43 +00:00
Kurt Hindenburg
f212b944c7 Use kWarnings for error messages 
svn path=/trunk/KDE/kdebase/apps/konsole/; revision=1148434
 2010-07-10 16:44:45 +00:00
Kurt Hindenburg
3d052f909c Add 2 new dbus methods for setting tab title formats so that they are persistent. 
Thanks to Andrea Solis for original patch.

FIXED_IN: 4.5
BUG: 183963

svn path=/trunk/KDE/kdebase/apps/konsole/; revision=1136726
 2010-06-10 15:09:49 +00:00
Kurt Hindenburg
abacbc3ada Save character encoding to session management. 
BUG: 221450

svn path=/trunk/KDE/kdebase/apps/konsole/; revision=1134480
 2010-06-04 12:33:33 +00:00
Eli MacKenzie
2f6ec63377 Adds support for SHELL_SESSION_ID. 
CCBUG:156563

svn path=/trunk/KDE/kdebase/apps/konsole/; revision=1125733
 2010-05-12 06:15:41 +00:00
Kurt Hindenburg
bc3e902d65 Correct where new Hotspots are calculated upon resize. 
CCBUG: 228443

svn path=/trunk/KDE/kdebase/apps/konsole/; revision=1097379
 2010-03-01 04:10:55 +00:00
Kurt Hindenburg
926f4f085a Add some context for translators 
svn path=/trunk/KDE/kdebase/apps/konsole/; revision=1086337
 2010-02-06 23:08:09 +00:00
Friedrich W. H. Kossebau
1cf6ef9365 changed: made static const data symbols really static const 
svn path=/trunk/KDE/kdebase/apps/konsole/; revision=1080302
 2010-01-26 02:57:09 +00:00