Commit Graph

79 Commits

Author SHA1 Message Date
Jekyll Wu
14bcc3366f Use NewProfile only when needed
This fixes the problme of empty profile name when invoking konsole in
the simplest way.

This is a follow-up of commit ba84ff30fa
2012-02-05 01:06:26 +08:00
Jekyll Wu
588aa92a21 A little more constness 2012-02-04 15:48:12 +08:00
Jekyll Wu
4156806b73 Make the definition of static member outstanding 2012-02-04 15:32:51 +08:00
Jekyll Wu
837ab5a664 Revert the boolean logic to make the code more natural 2012-02-04 15:30:13 +08:00
Jekyll Wu
28741c9153 Deal with option "-e" in a more profile-oriented way
Since "New Tab" always use default profile now, we can deal with that
option in a more elegant way, instead of a hack.

This basically revert commit 35fae00159
2012-02-04 01:10:44 +08:00
Jekyll Wu
ba84ff30fa Get rid of _defaultProfile from class MainWindow
REVIEW:103819
2012-02-04 00:58:51 +08:00
Jekyll Wu
6b6a5944f6 Prefer foreach(...) over while(...) for simplicity and readability 2012-01-22 10:21:45 +08:00
Jekyll Wu
40f8bf736a Rename for clarity: closeAll() ==> closeAllSessions() 2012-01-16 13:31:04 +08:00
Jekyll Wu
48abb9d99f Be consistent: do not call session->run() directly in stand-alone Konsole
This is a follow up for the commit fixing BKO 176902.

For konsolepart, need more investigation.
2012-01-15 19:49:56 +08:00
Jekyll Wu
3ae465cedf Change the default global shortcut for --background-mode from F12 to Ctrl+Shift+F12
F12 is too common. Change it to reduce the chance of conflict
2012-01-12 16:19:50 +08:00
Jekyll Wu
37fc995af4 Show the global shortcut for background window in the shortcuts dialog
I'm not sure whether that can be called as improvement. That global
shortcut has always been configurable through systemsettings. Now the
global shortcut is also configurable thourgh shoutcuts dialog, but it
is only available in the background window when it is shown.

I wonder how many users know and really use the --background-mode
option. It feels to me more like a clever trick than a mature feature.
2012-01-12 15:31:54 +08:00
Kurt Hindenburg
bb3805de2e Remove unused ::self() 2012-01-03 11:48:08 -05:00
Kurt Hindenburg
ba77864413 Minor style changes
Use 'git diff -w --ignore-all-space' for non-whitespace changes.
2012-01-03 11:37:27 -05:00
Kurt Hindenburg
c11ab0ecc4 Minor whitespace change.
Use 'git diff -w --ignore-all-space' to see non-whitespace changes.
2011-12-30 10:28:53 -05:00
Kurt Hindenburg
1baa56feda White space changes - astyle and Qt normalize don't like each other.
Use 'git diff -w --ignore-all-space' to see non-whitespace changes.
2011-12-25 13:13:55 -05:00
Kurt Hindenburg
75d2260534 Keep lines < 80 columns for readability; minor style changes. 2011-12-24 18:51:10 -05:00
Kurt Hindenburg
e1d23238ee Apply astyle-kdelibs
Over the years, the coding style is all over the place.

Use 'git diff -w --ignore-all-space' to see non-whitespace changes.
2011-12-23 22:37:55 -05:00
Jekyll Wu
903dbe1b7f Make the code slightly more readable 2011-11-06 05:26:54 +08:00
Jekyll Wu
330de6c6f4 Fix some spelling problems 2011-11-06 03:41:20 +08:00
Jekyll Wu
cf92cece2b Remove leading white spaces in blank lines to make them really empty 2011-11-05 07:29:21 +08:00
Jekyll Wu
e825a8e0b6 Prefer forward declaration when it is enough 2011-11-01 13:41:54 +08:00
Jekyll Wu
ae44eb4c4b Save default-profile/favorites/shortcuts settings into disk ASAP.
Those settings are now synced into disk right after the
ManageProfilesDialog is closed.

BUG: 200987
FIXED-IN: 4.8
REVIEW:102781
2011-10-06 17:48:25 +08:00
Kurt Hindenburg
0c0874f98a On MacOSX, put menus inside konsole window.
KDE's menuBar()->isTopLevelMenu() hasn't worked for a while.  Without a
replacement, let's just put the menus inside the main window.  This
also makes the keyboard shortcut to show menus look reasonable (instead
of floating).
2011-09-24 09:31:58 -04:00
Jekyll Wu
cd2e674d21 Rename to avoid confusion.
It is confusing to name a ViewManager* pointer as 'view', especially
when it is used in 'view->createView()'.
2011-09-15 15:11:27 +08:00
Kurt Hindenburg
35fae00159 When using -e <command> don't save to profile for new tabs.
Currently using -e <command> will cause all new tabs/windows to run
    <command>.  This patch fixes that such that new tabs/windows will start
    the default profile.

    Patch by Gu Rui <chaos.proton@gmail.com> with minor edit by self.
    FIXED-IN: 4.8
    REVIEW: 102602
    CCBUG: 192212
2011-09-13 18:26:15 -09:00
Jekyll Wu
de61d40c63 Include Qt headers in the form of "#include <Module/Class>" 2011-09-06 06:42:42 +08:00
Jekyll Wu
2d8b4a0a63 Delete one line of no use. 2011-08-30 07:57:55 +08:00
Jekyll Wu
a52cd60e9e Delete 2 un-used member variables. 2011-08-30 07:47:36 +08:00
Jekyll Wu
dfcd06dfcf adjust indentation. 2011-08-15 06:14:28 +08:00
Jekyll Wu
d1dc4669d3 remove duplicated #include. 2011-08-10 09:09:51 +08:00
Kurt Hindenburg
7e00edd516 Make sure pty device has right size before terminal process queries it.
Whenever TeminalDisplay is resized, konsole tells the underlying
pty device its new size by calling Pty::setWindowSize(). However,
current code can't guarantee when the terminal process starts and
queries the pty device about its size, the pty device already has the
right info. This has caused some long known bugs, such as #176902.

This patch tries to guarantee that important assumption. It currently
uses a hard-coded small delay, which works pretty well in practice
although not that elegant.

Patch by Jekyll Wu <adaptee@gmail.com>

I think this is better than leaving the situation as it is.  This may
be backported if no issues are found.
BUG: 173999
BUG: 176902
BUG: 203185
BUG: 229058
REVIEW: 102061
FIXED-IN: 4.8
2011-08-05 10:40:14 -04:00
Montel Laurent
b91f50015d Normalize signals/slots 2011-07-30 14:10:56 +02:00
Kurt Hindenburg
23062bcc0d Allow profile filenames to have multiple '.'s.
After this hostname.local.profile will work with --profile and
--list-profiles.  Also, the profile path file is checked if it is a
directory.
BUG: 250399
FIXED-IN: 4.6.3
2011-04-24 00:06:02 -04:00
Kurt Hindenburg
78f0d054ff Add command-line option --list-profile-properties
This new option will list all the profile properties' name and type.
This info can then be used with the -p name=value; command line option.
2011-02-28 20:19:52 -05:00
Laurent Montel
dd46511de1 Use QLatin1String in setObjectName (added with a script)
svn path=/trunk/KDE/kdebase/apps/konsole/; revision=1178049
2010-09-22 07:35:22 +00:00
Kurt Hindenburg
d5a31b44e5 minor krazy fix for single char QString
svn path=/trunk/KDE/kdebase/apps/konsole/; revision=1122317
2010-05-03 15:18:09 +00:00
Kurt Hindenburg
024bcfdbec Allow tab commands and their titles to be read from a file on the command line.
# Examples below:
title Heading to earth;; command: ssh earth
title Top this!;; top

Original patch by Thomas Dreibholz; hacking/changes/bugs are all mine.

BUG: 235410

svn path=/trunk/KDE/kdebase/apps/konsole/; revision=1121586
2010-05-01 20:11:55 +00:00
Kurt Hindenburg
996f6a0430 Quit after --list-profiles is used; otherwise dbus process id is left alive.
BUG: 192241

svn path=/trunk/KDE/kdebase/apps/konsole/; revision=1096175
2010-02-26 05:40:25 +00:00
Kurt Hindenburg
b2a291b01f Allow 'Open Folder in Tabs' to support SSH bookmarks.
Thanks to Will Angenent for patch.

BUG: 177637

svn path=/trunk/KDE/kdebase/apps/konsole/; revision=1033653
2009-10-10 17:35:15 +00:00
Fredrik Höglund
1fcde703b1 Get rid of the ARGB visual hack, and use Qt::WA_TranslucentBackground instead.
svn path=/trunk/KDE/kdebase/apps/konsole/; revision=1032123
2009-10-06 22:46:01 +00:00
Harald Fernengel
db7a1edeed use the new AA_MacDontSwapCtrlAndMeta application attribute on MAC OS X to
ensure that Konsole gets the raw and unswapped meta keys.

This enables us to use CTRL-C in konsole on the mac again :)

svn path=/trunk/KDE/kdebase/apps/konsole/; revision=1029769
2009-09-30 17:38:13 +00:00
Kurt Hindenburg
df31057755 On the command line expand ./ for -e only.
CCBUG: 202302

svn path=/trunk/KDE/kdebase/apps/konsole/; revision=1028021
2009-09-25 14:26:03 +00:00
Kurt Hindenburg
d4bb1e1a68 Correct spelling using US English.
SVN_SILENT

svn path=/trunk/KDE/kdebase/apps/konsole/; revision=989146
2009-06-29 15:16:28 +00:00
Robert Knight
dd9df43b44 Remove emacs mode information from the bottom of some source files.
If this information is put anywhere it should be in a single file instead
of duplicated for each file.  In fact, it shouldn't be needed at all since
we have the same rules on tabs and tab sizes as most other parts of kdebase


svn path=/trunk/KDE/kdebase/apps/konsole/; revision=946369
2009-03-29 11:12:57 +00:00
Robert Knight
ef3e43e11d Initial implementation of session management in Konsole.
Patch from Stefan Becker <stefan.becker@nokia.com>

Thank-you very much Stefan!

CCBUG: 152761


svn path=/trunk/KDE/kdebase/apps/konsole/; revision=867323
2008-10-03 10:38:50 +00:00
Robert Knight
956277c014 Convert tabs to 4 spaces to match kdelibs conventions. Previously
there was a mix of tabs and spaces for indentation.

CCMAIL:Stefan.Becker@nokia.com


svn path=/trunk/KDE/kdebase/apps/konsole/; revision=863326
2008-09-21 20:06:58 +00:00
Albert Astals Cid
1222b0e15b avoid unnecessary copies by using const & in foreach
svn path=/trunk/KDE/kdebase/apps/konsole/; revision=800783
2008-04-24 20:41:04 +00:00
Robert Knight
5d9997446e Update copyright year to 2008. Remove '(C)' from copyright lines.
svn path=/trunk/KDE/kdebase/apps/konsole/; revision=800631
2008-04-24 14:53:43 +00:00
Friedrich W. H. Kossebau
199dc3e99a set global program icon via KAboutData, not directly
svn path=/trunk/KDE/kdebase/apps/konsole/; revision=799282
2008-04-20 23:35:54 +00:00
Jordi Polo
deb9d1e50d The inherence chain can mistakenly be cut with an empty profile.
Use default profiles instead of empty profiles.


svn path=/trunk/KDE/kdebase/apps/konsole/; revision=795383
2008-04-10 03:45:07 +00:00