Summary:
pretty vital (at least for me) if one doesn't have compositing.
we can't use the normal QPalette::Inactive because of color schemes,
but I made the new scrollbar color code follow the same dimming colors.
Test Plan:
tested with and without compositing, with and without scrollbar,
and dark and light color schemes.
Reviewers: hindenburg, #konsole
Reviewed By: hindenburg, #konsole
Subscribers: anthonyfieroni, konsole-devel, #konsole
Tags: #konsole
Differential Revision: https://phabricator.kde.org/D16198
Summary:
As part of the QTabBar refactoring, honouring of the new tab behaviour
setting was lost. Restore using a simpler implementation that simply
asks QTabWidget for the current index.
BUG: 396701
Reviewers: #konsole, hindenburg, tcanabrava
Subscribers: konsole-devel
Tags: #konsole
Differential Revision: https://phabricator.kde.org/D15828
This commit breaks sessionProfileCommandReceived
causing crashes in programs such as nvim.
I'm reverting it for now while I can't dig deeper.
This reverts commit 99f233b9a1.
Summary:
There's no point in returning null if we have a default
and we would check for null and query for the default
in all cases that we used it.
Export the private header ColorScheme
It's going to be used from Parts and App
Add ColorScheme() to the Profile
The profile used to hold the ColorScheme name, but if you
want to query for the ColorScheme you had to call ViewManager
but there's a class ColorSchemeManager that ViewManager used to call
Just make things simple:
- Profile has a colorScheme that it queries from the ColorSchemeManager
- Use profile->colorScheme() when you wanna something from the
colorScheme at the profile.
Reviewers: #konsole, hindenburg
Reviewed By: #konsole, hindenburg
Subscribers: konsole-devel
Tags: #konsole
Differential Revision: https://phabricator.kde.org/D13854
Summary:
Adds option to reverse the order of URL hints such that the last URL
(the bottom-most one) has the number 1 and the numbers increase from
bottom to top.
This becomes particularly useful when watching a log or buffer, or in terminal
chat applications. Very often, the most useful URL is the most recent one and
if there are many (> 10) URLs on the screen, the desired one will not get a
hint. Reversing the numbering makes the most recent URL hint take the number 1,
while the oldest will have the highest number or no number at all.{F6244152}
{F6244154}
{F6244155}
Reviewers: #konsole, #vdg, hindenburg
Reviewed By: #konsole, hindenburg
Subscribers: hindenburg, ngraham, konsole-devel
Tags: #konsole
Differential Revision: https://phabricator.kde.org/D15362
Summary:
If you moved the tabs to splits in a way that you have a different
number of tabs in each split, and started closing it, the count()
of the tabs would be different and we would hit an assert.
The fix is simple: don't separate the logic between tabEmpty and
tabDestroyed, if the tab is empty it will be destroyed but we can
treat everything in the tabEmpty signal, this way we will never hit
a dangling pointer.
Because of that it was possible that a splitView had a invalid
activeWidget for a microsecond, when it's deleting itself, so
instead of asserting if we have no active view, I choose to return
a empty list of properties.
Reviewers: hindenburg, ngraham, sandsmark
Reviewed By: hindenburg
Subscribers: konsole-devel
Tags: #konsole
Differential Revision: https://phabricator.kde.org/D15379
Summary:
This continues the patch series of the rewrite
of the Tab handling code to a more modern approach
using QTabWidget.
This fixes the attach and reattach bug on multiple
konsole windows and reworks the drag & drop code
to a more simplified version of it.
Reviewers: hindenburg, ngraham, sandsmark
Reviewed By: hindenburg
Subscribers: lbergdoll, konsole-devel
Tags: #konsole
Differential Revision: https://phabricator.kde.org/D15377
Summary:
Show tabbar and hide tabbar got lost in the transition to a modern
QTabBar, this re-enables them. These options will override the
current settings if you use --hide-tabbar or --show-tabbar.
Changing these options in the settings will change these settings.
To use the current preferences just start konsole without --hide-tabbar
or --show-tabbar
Reviewers: #konsole, sandsmark, hindenburg
Reviewed By: #konsole, hindenburg
Subscribers: ngraham, konsole-devel
Tags: #konsole
Differential Revision: https://phabricator.kde.org/D14294
Builds have been failing since this new QTabBar code was committed
since QOperatingSystemVersion::currentType() is Qt5.9+. We currently
only require Qt5.6 and I don't want to change that just for this.
ENABLE_DETACHING is only set to false for MacOSX/Darwin.
(Detaching is still broken atm)
Move out of the CMake the check for crashes in detaching
It's better to check that in the code - I was quite lost
for a while on why there was a DETACHING_ENABLED definition
as it did not made sense
Summary:
this is a WIP, I don't plan to merge this yet, there are many thigns to solve.
Drop the handmade TabWidget used inside of konsole in favor of Qt's QTabWidget
This drops tons of code we manually did, but it also drops a bit of functionality.
Missing features:
- Close Button
- New Tab on double click
- Drag'n Drop
- Detach
and lots of testing.
Subscribers: konsole-devel
Tags: #konsole
Differential Revision: https://phabricator.kde.org/D13882
Summary:
StackedViewContainer is a plain view container with no navigiations.
It can be replaced using TabbedViewContainer and hiding the tabbar.
This will minimize duplicate code and allow easier control of code
in Konsole and KonsolePart.
Test Plan:
Run konsole and konsole part test, and then
use the shortcuts to create tab.
Reviewers: #konsole, hindenburg
Reviewed By: #konsole, hindenburg
Subscribers: pedroarthurp, konsole-devel
Tags: #konsole
Differential Revision: https://phabricator.kde.org/D12964
Summary:
This is not userfully, only adds more code and
the code is happy without it.
Reviewers: #konsole, hindenburg
Reviewed By: #konsole, hindenburg
Subscribers: hindenburg, konsole-devel
Tags: #konsole
Differential Revision: https://phabricator.kde.org/D12965
Summary:
Konsole sends up/down key press events to programs running in the shell
if they indicate they are not interested in mouse events. This adds a
profile property to toggle this behaviour.
BUG: 170582
FIXED-IN: 18.08
Reviewers: #konsole, hindenburg
Reviewed By: #konsole, hindenburg
Subscribers: #konsole
Tags: #konsole
Differential Revision: https://phabricator.kde.org/D12139
It is unclear what causes the session to be invalid when detaching
tabs, but there are enough BRs with the same backtraces to confirm it.
For now, check to prevent crashes.
CCBUG: 390736
The default behavior hasn't change. Toggling this off will cause all
copy/paste to be text only.
BUG: 387397
FIXED-IN: 18.04
Differential Revision: https://phabricator.kde.org/D10448
Note that this does not affect KonsolePart; it is up to the app using
it to enable transparency (see src/tests/demo_konsolepart).
Patch by anemeth
FEATURE: 198175
Differential Revision: https://phabricator.kde.org/D10015
Qt5.9+ changed the way tab widths are handled. Add option to allow
tab width to expanding to full window or as width of tab text.
GUI:
BUG: 380879
FIXED-IN: 17.12
Summary:
BUG: 383603
Add the new KDE standard tab switching shortcuts that were introduced in https://phabricator.kde.org/R237:d85a57645f94d2d087711d7c608a0c5a46ed7ede.
Test Plan: Built and tested with current git master in up-to-date KDE Neon. Expected behavior is seen (default shortcuts have become shift+left/right and cmd+pgup/pgdn).
Reviewers: #kde_applications, #konsole, hindenburg, aacid, ltoscano, pino, dfaure
Reviewed By: dfaure
Subscribers: dfaure, davidedmundson, aacid, #konsole
Tags: #konsole
Differential Revision: https://phabricator.kde.org/D7354
DBus slot that returns the unique ids of the sessions in the
current view. The returned list is not sorted.
Differential Revision: https://phabricator.kde.org/D7067
KXMLGUIClient->actionCollection() only returns a non NULL value so I
don't think these checks are needed but for now add Q_ASSERTs and
returns. Previously, the if() didn't cover all the assignments.
