Commit Graph

314 Commits

Author SHA1 Message Date
Jekyll Wu
c8da19dcdd Move the logic of increasing/decreasing font size into TerminalDisplay 2012-05-10 15:24:59 +08:00
Jekyll Wu
67e0e16e8f Trivial rename & adjustment of the bell code 2012-05-10 14:45:13 +08:00
Jekyll Wu
49bb363e23 Remove one comment obsoleted for a long time 2012-05-10 13:58:48 +08:00
Jekyll Wu
a0f502e1a2 Remove global object base_color_table
It is basically the same as ColorScheme::defaultTable(with slight
difference). There is no need to keep two default color tables.
2012-05-08 20:28:00 +08:00
Jekyll Wu
2a92a3a7c2 Do not clear selection after pasting.
The old behavior has a long history, initially introduced by commit
1e3c3e27 more than 10 years ago. I fail to understand its intention
(some safeguard?), and I think keeping the selection is more useful in
work flow.

Keep it in master branch for now.  No backporting.

CCBUG: 240335
2012-05-08 00:44:47 +08:00
Jekyll Wu
2def15a2db Do not forward the button release event when Shift is also pressed.
BUG: 299437
FIXED-IN: 4.8.4
2012-05-06 01:28:03 +08:00
Jekyll Wu
bb818010b4 Add two profile options for the copy & paste behavior of mouse
* support "automatially copy selected text into clipboard"
  * mouse middle button can be customized to paste from selectio or
    clipboard

The first feature might look like a unnecessary duplicate of the
"synchronize selection and clipboard" feature of Klipper. However, that
klipper feature is generally problematic, while doing it only in Konsole
is generally useful and harmless.

FEATURE: 183490
FIXED-IN: 4.9.0
REVIEW: 103861
DIGEST:
2012-04-25 12:55:38 +08:00
Frederik Gladhorn
1b351b3c9b Build with Qt 4.7.
Text updates for accessibility were added
in Qt 4.8.

CCMAIL: adaptee@gmail.com
CCMAIL: kurt.hindenburg@gmail.com
2012-04-11 15:27:12 +02:00
Kurt Hindenburg
5b083640ce whitespace and style fixes
Use 'git diff -w --ignore-all-space' to see non-whitespace changes
2012-04-05 11:08:53 -04:00
Frederik Gladhorn
7e0ba7079a Accessible interface for TerminalDisplay
This allows screen readers to read the output
in the konsole window.
2012-03-29 20:00:35 +02:00
Jekyll Wu
597dbfc42e Key_Slash, Key_Period and Key_Space should never trigger action
Those three keys are essential when using terminal/shell.

The old code exhibit its problem when konsolepart is embedded in a
application where developers or users might have assigned such keys as
shortcut. A good example is the "Find Text as You Type" action in
Konqueror.

Maybe all single keys should be treated specially to avoid triggering
actions.
2012-03-23 00:09:51 +08:00
Kurt Hindenburg
683566cee3 On MacOSX don't emit configureRequest upon contextMenuEvent
When opening the Scrollback or Edit Profile via the context menu,
the context menu will re-appear along w/ the dialog.

related 33be288c03 commit
2012-03-21 08:41:04 -04:00
Jekyll Wu
2f6d64fe5a Merge Profile::BellModeEnum and TerminalDisplay::BellMode into Enum::BellModeEnum 2012-03-19 16:08:55 +08:00
Jekyll Wu
cf0a3e3cd0 Merge Profile::TripleClickModeEnum and TerminalDisplay::TripleClickMode into Enum::TripleClickModeEnum 2012-03-19 16:08:54 +08:00
Jekyll Wu
0e35037be6 Merge Profile::CursorShapeEnum and TerminalDisplay::KeyboardCursorShape into Enum::CursorShapeEnum 2012-03-19 16:08:54 +08:00
Jekyll Wu
d1a1b11762 Merge Profile::ScrollBarPositionEnum and TerminalDisplay::ScrollBarPosition into Enum::ScrollBarPositionEnum 2012-03-19 16:08:42 +08:00
Kurt Hindenburg
e0862c603a Style fixes - separte commands - remove 2 ; - align { elses 2012-03-18 15:57:48 -04:00
Kurt Hindenburg
519e2614d6 Style fixes - remove spaces before ; and add spaces in for loops 2012-03-18 15:11:06 -04:00
Jekyll Wu
33be288c03 Support showing the context menu by pressing the "Menu" key
REVIEW: 104190
2012-03-18 23:08:14 +08:00
Jekyll Wu
25b8b5353c Trivial style change: remove extra blank lines 2012-03-17 19:53:21 +08:00
Jekyll Wu
7179de8f3d Prefer qobject_cast to dynamic_cast when appropriate 2012-03-16 13:37:15 +08:00
Jekyll Wu
0ff1ab2a02 Krazy fix: duplicate #include 2012-03-09 17:02:12 +08:00
Kurt Hindenburg
7fd6cddb82 Remove unused link tooltip code 2012-03-06 23:35:11 -05:00
Jekyll Wu
f4fb943132 Most of time we only need <KLocalizedString> instead of <KLocale> 2012-03-07 06:48:26 +08:00
Jekyll Wu
6dd15d9061 split class ExtenededCharTable into its own file 2012-03-06 04:44:32 +08:00
Jekyll Wu
a265860c92 More constness 2012-03-04 22:14:12 +08:00
Jekyll Wu
9d73318c9a Remove unneeded #include 2012-03-03 00:12:01 +08:00
Jekyll Wu
a956c2b0dd Remove unused member: _colorsInverted 2012-03-03 00:00:51 +08:00
Jekyll Wu
27d470c0fd Move code around 2012-03-02 23:44:21 +08:00
Jekyll Wu
a37576fe08 Trivial improvement with comment and style 2012-03-02 21:35:00 +08:00
Jekyll Wu
ef62a0002b Move TerminalDisplay::HAVE_TRANSPARNCEY into its own dedicated class
TerminalDisplay.h is a big header. It is not good for several files to
include that big header only in order to use one of its static member.
2012-02-25 21:10:09 +08:00
Jekyll Wu
0331f97b60 Another try of cleaning up of #includes 2012-02-21 05:18:31 +08:00
Jekyll Wu
f42fd4721b Clean up unneeded #includes 2012-02-20 19:41:38 +08:00
Jekyll Wu
f0529c1c02 Prefer foreach(..) over iterating manually for readability 2012-02-13 21:28:48 +08:00
Kurt Hindenburg
47f504785f A quick fix to get fonts to look OK w/ Qt4.8 and bidi off
Hopefully a temp fix for this issue.  It would be better to find out
what happened with Qt4.8 font rendering.

Thanks to people on bug report for research and info.

CCBUG: 280896
2012-02-04 16:21:06 -05:00
Kurt Hindenburg
70422516a0 Fix an issue w/ 19d7990b12 2012-01-28 20:39:58 -05:00
Jekyll Wu
19d7990b12 Rename and move around 2012-01-27 01:09:47 +08:00
Jekyll Wu
c6bd15be8e Minor fix for the UI string in the previous commit 2012-01-27 00:19:46 +08:00
Jekyll Wu
c08484f40a Add action "Change Directory to" for cding into dropped directory.
That action is shown only when:
1). only one item is selected and dropped
2). that item is local instead of remote
3). that item is a directory instead of file

FEATURE: 197867
FIXED-IN: 4.9
2012-01-27 00:06:49 +08:00
Jekyll Wu
f1c4879fd6 Remove unneeded #include 2012-01-23 20:43:02 +08:00
Jekyll Wu
a9f02328ac UI string: 'Paste as text' ==> 'Paste Location'
The old string is not clear enough and might be misunderstood as
"paste the content (as text)"
2012-01-23 19:02:03 +08:00
Kurt Hindenburg
d8e05a0672 Use the Qt versions of strlen, strncpy, strncmp 2012-01-03 23:29:05 -05:00
Kurt Hindenburg
b3ead98353 Apply astyle-kdelibs
Over the years, the coding style is all over the place.

Use 'git diff -w --ignore-all-space' to see non-whitespace changes.
2011-12-24 11:28:25 -05:00
Jekyll Wu
044fdf9020 Always use Left-To-Right as the "document layout" in the terminal area
REVIEW:102976
BUG:279048
FIXED-IN:4.8
2011-11-20 09:05:02 +08:00
Jekyll Wu
125e2c7bd2 Declare pointer and reference in a consistent way
Most code use the "const QString& text" form, instead of the "const
QString &text" form. So change the minority to be consistent with
the majority.
2011-11-06 06:13:28 +08:00
Jekyll Wu
330de6c6f4 Fix some spelling problems 2011-11-06 03:41:20 +08:00
Jekyll Wu
cf92cece2b Remove leading white spaces in blank lines to make them really empty 2011-11-05 07:29:21 +08:00
Jekyll Wu
e825a8e0b6 Prefer forward declaration when it is enough 2011-11-01 13:41:54 +08:00
Jekyll Wu
79a57cea8b Minor change on comment, style and whitespace 2011-10-28 21:43:28 +08:00
Jekyll Wu
a2a3dc9226 More const-ness for better understanding 2011-10-27 23:36:09 +08:00