Commit Graph

130 Commits

Author SHA1 Message Date
Jekyll Wu
2f7a0965f5 Move class ColorSchemeMananger into its own file
class KDE3ColorSchemeReader is also moved since it is supposed to an
compatibility helpr of which class ColorScheme does not need to know,
and eventualy it should be removed
2012-02-29 22:31:56 +08:00
Jekyll Wu
ef62a0002b Move TerminalDisplay::HAVE_TRANSPARNCEY into its own dedicated class
TerminalDisplay.h is a big header. It is not good for several files to
include that big header only in order to use one of its static member.
2012-02-25 21:10:09 +08:00
Jekyll Wu
7412150341 Use KMessageWidget in place of the home made Konsole::WarningBox
The WarningBox.cpp is not deleted at the moment, in case using
KMessageWidget turns out to be problematic .

Note: the miminal requirement for kdelibs is increased to 4.7.0
due to using KMessageWidget.

REVIEW: 104053
2012-02-25 00:43:59 +08:00
Jekyll Wu
85433dc26a Rename: info ==> profile 2012-02-23 21:11:28 +08:00
Jekyll Wu
f42fd4721b Clean up unneeded #includes 2012-02-20 19:41:38 +08:00
Jekyll Wu
f0529c1c02 Prefer foreach(..) over iterating manually for readability 2012-02-13 21:28:48 +08:00
Jekyll Wu
6b6a5944f6 Prefer foreach(...) over while(...) for simplicity and readability 2012-01-22 10:21:45 +08:00
Jekyll Wu
56f3805ac1 Move options influencing tabbar from profiles into global setting 2012-01-22 10:21:44 +08:00
Jekyll Wu
e3e960ab95 Move the 'show menubar' option from profiles into global settings 2012-01-22 10:21:29 +08:00
Jekyll Wu
a278f3b46b A little refinement with the "Seconds to detect silence" option:
*  make the text a litter easier to understand(I hope so)
*  show time unit(second) as suffix in the spinbox
2012-01-12 20:51:09 +08:00
Jekyll Wu
090d379f09 Show the unit of scrollback within the spinbox 2012-01-12 19:01:58 +08:00
Kurt Hindenburg
aa9f6ccc95 Change the font dialog's sample text for terminal usage.
Use the code provided by Thomas Lübking in
https://git.reviewboard.kde.org/r/103357/ to change the font dialog's
sample text.  Since the text entry is large I added a lot of text
that some fonts may appears too similiar in the terminal.
2012-01-01 16:24:18 -05:00
Kurt Hindenburg
707cb69d7b Use QWeakPointer for dialogs 2011-12-25 18:19:11 -05:00
Kurt Hindenburg
1baa56feda White space changes - astyle and Qt normalize don't like each other.
Use 'git diff -w --ignore-all-space' to see non-whitespace changes.
2011-12-25 13:13:55 -05:00
Kurt Hindenburg
7a22f5663e Apply astyle-kdelibs
Over the years, the coding style is all over the place.

Use 'git diff -w --ignore-all-space' to see non-whitespace changes.
2011-12-24 10:17:43 -05:00
Kurt Hindenburg
bc087ae51b Remove unused KDebug includes 2011-12-18 00:01:32 -05:00
Jekyll Wu
b95f9443a0 Trivial change on #include 2011-11-16 13:31:24 +08:00
Jekyll Wu
80ec2d216b Delete some kDebug messages 2011-11-06 03:47:14 +08:00
Jekyll Wu
330de6c6f4 Fix some spelling problems 2011-11-06 03:41:20 +08:00
Jekyll Wu
cf92cece2b Remove leading white spaces in blank lines to make them really empty 2011-11-05 07:29:21 +08:00
Jekyll Wu
fb12b31d57 Move code around 2011-10-30 19:14:49 +08:00
Jekyll Wu
10e1782b23 invert the order of getting focus and selecting all text 2011-10-30 16:21:19 +08:00
Jekyll Wu
7ad55af1fc Implement the "Seconds to detect silence" option from KDE3 konsole.
FEATURE: 195978
FIXED-IN:4.8
REVIEW:102823
2011-10-11 12:30:05 +08:00
Jekyll Wu
8678637392 Trivial change on comment 2011-10-11 04:42:57 +08:00
Jekyll Wu
9ea9d62785 Reimplement the feature of "show/hide the size widget after resising"
This is a follow up of commit b40a006d which closees BUG 169054.
It turns out the old code already has most parts of similar logic.
So remove duplicated logic in the code.
2011-10-10 16:23:22 +08:00
Jekyll Wu
da7c9d254a Set the incremental step of HistorySize as 1/10 of current value. 2011-10-06 21:21:34 +08:00
Jekyll Wu
59963d8b7e Change the type of TripleClickMode property from bool to enum.
Its correspoding UI in the EditProfileDialog is changed from
checkbox to combobox.

REVIEW:102742
2011-09-30 23:14:52 +08:00
Jekyll Wu
d148c18ae3 It is actually the value of perperty, not property name. 2011-09-29 21:30:48 +08:00
Jekyll Wu
45bc66f6fb s/possible/possibilities/ for consistency. 2011-09-29 19:41:28 +08:00
Jekyll Wu
41dd07673f Prefer enum over int. 2011-09-29 19:24:27 +08:00
Jekyll Wu
f8e44c5d63 Rename method to reflect what it actually does.
setupCombo was actually used to setup checkboxes for boolean property.
2011-09-29 19:16:48 +08:00
Jekyll Wu
acd37f7a73 Allow users to control where the newly created tab should be placed.
CCBUG:276872
REVIEW:102685
2011-09-27 06:45:05 +08:00
Jekyll Wu
cfc4bac642 Rename for clairty.
tabmode ==> tabBarMode
tabPosition ==> tabBarPosition
2011-09-25 08:51:13 +08:00
Yuri Chornoivan
ea457d8973 add missing space 2011-09-15 08:18:33 +03:00
Albert Astals Cid
18df5b4731 Small fix in the text
desktop effect -> desktop effects
is -> were
Spacing fix
2011-09-14 21:41:17 +02:00
Jekyll Wu
49c107966b Konsole should never save a profile with empty name into disk.
BUG: 281268
FIXED-IN: 4.8
REVIEW:102559
2011-09-14 23:31:47 +08:00
Jekyll Wu
7d2f153ae6 Warn users they may need to restart konsole to see transparent background.
If desktop effect is enabled only after konsole has started, then
users need to restart konsole to see transparent background.

FEATURE: 169305
FIXED-IN: 4.8
2011-09-09 17:16:27 +08:00
Yuri Chornoivan
cd50a74e7a fix typo: varible -> variable 2011-09-05 07:55:29 +03:00
Jekyll Wu
3c562ef7fe Add tootip for the KTextEdit widget within environment editor.
The code assumes one environment variable per line, but users may
not guess out that assumption without prompt.
2011-09-04 21:11:46 +08:00
Jekyll Wu
a64772444f reorganize some code to make it more readable.
This commit is purely about style and layourt. No functionality changes.
2011-09-04 12:11:17 +08:00
Jekyll Wu
5fb01e1017 slight improvement on style and readability. 2011-09-04 02:09:59 +08:00
Jekyll Wu
4b7ce422a5 The argument should not used before it passes the assertion. 2011-09-04 01:58:59 +08:00
Jekyll Wu
0c5a853e92 Add helper method createTempProfile() to reduce duplicated code. 2011-09-04 01:37:05 +08:00
Jekyll Wu
709445ceee Make sure the _tempProfile is alwasy hidden. 2011-09-04 01:20:14 +08:00
Jekyll Wu
dec20a58a7 Assign new value to _tempProfile in a way clearly indicating its type.
This avoids potential doubt about its type and memory leak.
2011-09-04 01:19:31 +08:00
Jekyll Wu
46b5fbc993 use updateTempProfileProperty() uniformly in class EditProfileDialog. 2011-08-09 14:40:28 +08:00
Kurt Hindenburg
b40a006db8 Add a checkbox to hide the size widget upon resizing window.
Re-add the KDE 3 option to show/hide the size widget when the window is
changed.

Patch is years old from Chali Ahmul M.P.U <chali.ahmul@atlas.cz>
FEATURE: 169054
FIXED-IN: 4.8
2011-07-31 20:56:16 -04:00
Montel Laurent
b91f50015d Normalize signals/slots 2011-07-30 14:10:56 +02:00
Kurt Hindenburg
ecfb037c27 Enable Edit Profile Apply button only when profile has changed.
Keep track of any changes to the Profile and only enable the Apply
button when something has really changed.

Patch by Jekyll Wu adaptee@gmail.com

Might backport to 4.7 if there are no concerns.
BUG: 274501
FIXED-IN: 4.8
REVIEW: 101904
2011-07-16 11:44:02 -04:00
Kurt Hindenburg
48cdd11371 Add profile option to disable underlining links.
Add a configuration item that allows disabling of the underlined links
on mouse hover. The option is profile specific and defaults to the previous
behaviour where links are underlined on hover.

Patch by Amand Tihon <amand.tihon@alrj.com>

BUG: 174261
FIXED-IN: 4.7
CCMAIL: amand.tihon@alrj.com
2011-04-16 13:39:42 -04:00